* [PATCH] configure: run plugin TCG tests again
@ 2024-01-24 11:53 Paolo Bonzini
2024-01-24 17:51 ` Alex Bennée
0 siblings, 1 reply; 2+ messages in thread
From: Paolo Bonzini @ 2024-01-24 11:53 UTC (permalink / raw)
To: qemu-devel; +Cc: alex.bennee
Commit 39fb3cfc28b ("configure: clean up plugin option handling", 2023-10-18)
dropped the CONFIG_PLUGIN line from tests/tcg/config-host.mak, due to confusion
caused by the shadowing of $config_host_mak. However, TCG tests were still
expecting it. Oops.
Put it back, in the meanwhile the shadowing is gone so it's clear that it goes
in the tests/tcg configuration.
Cc: alex.bennee@linaro.org
Fixes: 39fb3cfc28b ("configure: clean up plugin option handling", 2023-10-18)
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
configure | 3 +++
1 file changed, 3 insertions(+)
diff --git a/configure b/configure
index 3d8e24ae011..ff058d6c486 100755
--- a/configure
+++ b/configure
@@ -1644,6 +1644,9 @@ fi
mkdir -p tests/tcg
echo "# Automatically generated by configure - do not modify" > tests/tcg/$config_host_mak
echo "SRC_PATH=$source_path" >> tests/tcg/$config_host_mak
+if test "$plugins" = "yes" ; then
+ echo "CONFIG_PLUGIN=y" >> tests/tcg/$config_host_mak
+fi
tcg_tests_targets=
for target in $target_list; do
--
2.43.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] configure: run plugin TCG tests again
2024-01-24 11:53 [PATCH] configure: run plugin TCG tests again Paolo Bonzini
@ 2024-01-24 17:51 ` Alex Bennée
0 siblings, 0 replies; 2+ messages in thread
From: Alex Bennée @ 2024-01-24 17:51 UTC (permalink / raw)
To: Paolo Bonzini; +Cc: qemu-devel
Paolo Bonzini <pbonzini@redhat.com> writes:
> Commit 39fb3cfc28b ("configure: clean up plugin option handling", 2023-10-18)
> dropped the CONFIG_PLUGIN line from tests/tcg/config-host.mak, due to confusion
> caused by the shadowing of $config_host_mak. However, TCG tests were still
> expecting it. Oops.
>
> Put it back, in the meanwhile the shadowing is gone so it's clear that it goes
> in the tests/tcg configuration.
Queued to testing/next, thanks.
--
Alex Bennée
Virtualisation Tech Lead @ Linaro
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-01-24 17:52 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-01-24 11:53 [PATCH] configure: run plugin TCG tests again Paolo Bonzini
2024-01-24 17:51 ` Alex Bennée
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).