From: Joe Komlodi <komlodi@google.com>
To: qemu-devel@nongnu.org
Cc: venture@google.com, komlodi@google.com, minyard@acm.org
Subject: [PATCH v2 1/3] hw/i2c: core: Add reset
Date: Fri, 26 Jan 2024 00:55:39 +0000 [thread overview]
Message-ID: <20240126005541.1839038-2-komlodi@google.com> (raw)
In-Reply-To: <20240126005541.1839038-1-komlodi@google.com>
It's possible for a reset to come in the middle of a transaction, which
causes the bus to be in an old state when a new transaction comes in.
Signed-off-by: Joe Komlodi <komlodi@google.com>
---
hw/i2c/core.c | 30 +++++++++++++++++++++++++-----
include/hw/i2c/i2c.h | 6 +++++-
2 files changed, 30 insertions(+), 6 deletions(-)
diff --git a/hw/i2c/core.c b/hw/i2c/core.c
index 4cf30b2c86..def4f134d0 100644
--- a/hw/i2c/core.c
+++ b/hw/i2c/core.c
@@ -23,11 +23,31 @@ static Property i2c_props[] = {
DEFINE_PROP_END_OF_LIST(),
};
-static const TypeInfo i2c_bus_info = {
- .name = TYPE_I2C_BUS,
- .parent = TYPE_BUS,
- .instance_size = sizeof(I2CBus),
-};
+static void i2c_bus_enter_reset(Object *obj, ResetType type)
+{
+ I2CBus *bus = I2C_BUS(obj);
+ I2CNode *node, *next;
+
+ bus->broadcast = false;
+ QLIST_FOREACH_SAFE(node, &bus->current_devs, next, next) {
+ QLIST_REMOVE(node, next);
+ g_free(node);
+ }
+}
+
+static void i2c_bus_class_init(ObjectClass *klass, void *data)
+{
+ ResettableClass *rc = RESETTABLE_CLASS(klass);
+ rc->phases.enter = i2c_bus_enter_reset;
+}
+
+ static const TypeInfo i2c_bus_info = {
+ .name = TYPE_I2C_BUS,
+ .parent = TYPE_BUS,
+ .instance_size = sizeof(I2CBus),
+ .class_size = sizeof(I2CBusClass),
+ .class_init = i2c_bus_class_init,
+ };
static int i2c_bus_pre_save(void *opaque)
{
diff --git a/include/hw/i2c/i2c.h b/include/hw/i2c/i2c.h
index 2a3abacd1b..420868a269 100644
--- a/include/hw/i2c/i2c.h
+++ b/include/hw/i2c/i2c.h
@@ -64,7 +64,7 @@ struct I2CSlave {
};
#define TYPE_I2C_BUS "i2c-bus"
-OBJECT_DECLARE_SIMPLE_TYPE(I2CBus, I2C_BUS)
+OBJECT_DECLARE_TYPE(I2CBus, I2CBusClass, I2C_BUS)
typedef struct I2CNode I2CNode;
@@ -83,6 +83,10 @@ struct I2CPendingMaster {
typedef QLIST_HEAD(I2CNodeList, I2CNode) I2CNodeList;
typedef QSIMPLEQ_HEAD(I2CPendingMasters, I2CPendingMaster) I2CPendingMasters;
+struct I2CBusClass {
+ DeviceClass parent_class;
+};
+
struct I2CBus {
BusState qbus;
I2CNodeList current_devs;
--
2.43.0.429.g432eaa2c6b-goog
next prev parent reply other threads:[~2024-01-26 0:56 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-26 0:55 [PATCH v2 0/3] hw/i2c: smbus: Reset fixes Joe Komlodi
2024-01-26 0:55 ` Joe Komlodi [this message]
2024-02-01 15:24 ` [PATCH v2 1/3] hw/i2c: core: Add reset Peter Maydell
2024-02-02 20:44 ` Joe Komlodi
2024-01-26 0:55 ` [PATCH v2 2/3] hw/i2c/smbus_slave: Add object path on error prints Joe Komlodi
2024-02-01 15:14 ` Peter Maydell
2024-01-26 0:55 ` [PATCH v2 3/3] hw/i2c: smbus_slave: Reset state on reset Joe Komlodi
2024-02-01 15:25 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240126005541.1839038-2-komlodi@google.com \
--to=komlodi@google.com \
--cc=minyard@acm.org \
--cc=qemu-devel@nongnu.org \
--cc=venture@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).