qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: peterx@redhat.com
To: qemu-devel@nongnu.org
Cc: Fabiano Rosas <farosas@suse.de>,
	peterx@redhat.com, Peter Maydell <peter.maydell@linaro.org>
Subject: [PULL 06/15] tests/qtest/migration: Don't use -cpu max for aarch64
Date: Fri, 26 Jan 2024 12:17:16 +0800	[thread overview]
Message-ID: <20240126041725.124562-7-peterx@redhat.com> (raw)
In-Reply-To: <20240126041725.124562-1-peterx@redhat.com>

From: Fabiano Rosas <farosas@suse.de>

The 'max' cpu is not expected to be stable in terms of features across
QEMU versions, so it should not be expected to migrate.

While the tests currently all pass with -cpu max, that is only because
we're not testing across QEMU versions, which is the more common
use-case for migration.

We've recently introduced compatibility tests that use two different
QEMU versions and the tests are now failing for aarch64. The next
patch adds those tests to CI, so we cannot use the 'max' cpu
anymore. Replace it with the 'neoverse-n1', which has a fixed set of
features.

Suggested-by: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: Fabiano Rosas <farosas@suse.de>
Link: https://lore.kernel.org/r/20240118164951.30350-2-farosas@suse.de
Signed-off-by: Peter Xu <peterx@redhat.com>
---
 tests/qtest/migration-test.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tests/qtest/migration-test.c b/tests/qtest/migration-test.c
index 7675519cfa..15713f3666 100644
--- a/tests/qtest/migration-test.c
+++ b/tests/qtest/migration-test.c
@@ -820,7 +820,7 @@ static int test_migrate_start(QTestState **from, QTestState **to,
         memory_size = "150M";
         machine_alias = "virt";
         machine_opts = "gic-version=max";
-        arch_opts = g_strdup_printf("-cpu max -kernel %s", bootpath);
+        arch_opts = g_strdup_printf("-cpu neoverse-n1 -kernel %s", bootpath);
         start_address = ARM_TEST_MEM_START;
         end_address = ARM_TEST_MEM_END;
     } else {
-- 
2.43.0



  parent reply	other threads:[~2024-01-26  4:18 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-26  4:17 [PULL 00/15] Migration 20240126 patches peterx
2024-01-26  4:17 ` [PULL 01/15] userfaultfd: use 1ULL to build ioctl masks peterx
2024-01-26  4:17 ` [PULL 02/15] migration: Plug memory leak on HMP migrate error path peterx
2024-01-26  4:17 ` [PULL 03/15] migration: Make threshold_size an uint64_t peterx
2024-01-26  4:17 ` [PULL 04/15] migration: Drop unnecessary check in ram's pending_exact() peterx
2024-01-26  4:17 ` [PULL 05/15] analyze-migration.py: Remove trick on parsing ramblocks peterx
2024-01-26  4:17 ` peterx [this message]
2024-01-26 14:36   ` [PULL 06/15] tests/qtest/migration: Don't use -cpu max for aarch64 Fabiano Rosas
2024-01-26 14:39     ` Peter Maydell
2024-01-26 14:54       ` Fabiano Rosas
2024-01-29  2:51         ` Peter Xu
2024-01-29 12:14           ` Fabiano Rosas
2024-01-29 23:30             ` Fabiano Rosas
2024-01-30 10:18               ` Peter Maydell
2024-01-30 10:48                 ` Peter Xu
2024-01-30 21:23                   ` Fabiano Rosas
2024-01-31  4:04                     ` Peter Xu
2024-01-31 13:09                       ` Fabiano Rosas
2024-02-01  2:56                         ` Peter Xu
     [not found]                           ` <87y1c4ib03.fsf@suse.de>
2024-02-01 23:50                             ` Peter Xu
2024-02-02 10:51                               ` Peter Maydell
2024-02-05  2:56                                 ` Peter Xu
2024-02-12 18:29                                   ` Peter Maydell
2024-02-05  8:35                                 ` Eric Auger
2024-01-26  4:17 ` [PULL 07/15] ci: Add a migration compatibility test job peterx
2024-01-26  4:17 ` [PULL 08/15] ci: Disable migration compatibility tests for aarch64 peterx
2024-01-26  4:17 ` [PULL 09/15] migration/yank: Use channel features peterx
2024-01-26  4:17 ` [PULL 10/15] migration: Fix use-after-free of migration state object peterx
2024-01-26  4:17 ` [PULL 11/15] migration: Take reference to migration state around bg_migration_vm_start_bh peterx
2024-01-26  4:17 ` [PULL 12/15] migration: Reference migration state around loadvm_postcopy_handle_run_bh peterx
2024-01-26  4:17 ` [PULL 13/15] migration: Add a wrapper to qemu_bh_schedule peterx
2024-01-26  4:17 ` [PULL 14/15] migration: Centralize BH creation and dispatch peterx
2024-01-26  4:17 ` [PULL 15/15] Make 'uri' optional for migrate QAPI peterx
2024-01-26 18:16 ` [PULL 00/15] Migration 20240126 patches Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240126041725.124562-7-peterx@redhat.com \
    --to=peterx@redhat.com \
    --cc=farosas@suse.de \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).