From: Richard Henderson <richard.henderson@linaro.org>
To: qemu-devel@nongnu.org
Cc: Anton Johansson <anjo@rev.ng>
Subject: [PATCH 11/33] include/hw/core: Move do_interrupt in TCGCPUOps
Date: Sun, 28 Jan 2024 14:41:51 +1000 [thread overview]
Message-ID: <20240128044213.316480-12-richard.henderson@linaro.org> (raw)
In-Reply-To: <20240128044213.316480-1-richard.henderson@linaro.org>
From: Anton Johansson <anjo@rev.ng>
The ifdef out of which it is moved is not quite right: do_interrupt is
only needed for system mode. Move it to the top of a different ifdef
block, which preserves its position within the structure for that case.
Signed-off-by: Anton Johansson <anjo@rev.ng>
Message-Id: <20240119144024.14289-18-anjo@rev.ng>
[rth: Split from a larger patch and simplified.]
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
include/hw/core/tcg-cpu-ops.h | 7 ++-----
1 file changed, 2 insertions(+), 5 deletions(-)
diff --git a/include/hw/core/tcg-cpu-ops.h b/include/hw/core/tcg-cpu-ops.h
index 479713a36e..d6fe55d471 100644
--- a/include/hw/core/tcg-cpu-ops.h
+++ b/include/hw/core/tcg-cpu-ops.h
@@ -58,11 +58,6 @@ struct TCGCPUOps {
* cpu execution loop (hack for x86 user mode).
*/
void (*fake_user_interrupt)(CPUState *cpu);
-#else
- /**
- * @do_interrupt: Callback for interrupt handling.
- */
- void (*do_interrupt)(CPUState *cpu);
#endif /* !CONFIG_USER_ONLY || !TARGET_I386 */
#ifdef CONFIG_USER_ONLY
/**
@@ -114,6 +109,8 @@ struct TCGCPUOps {
void (*record_sigbus)(CPUState *cpu, vaddr addr,
MMUAccessType access_type, uintptr_t ra);
#else
+ /** @do_interrupt: Callback for interrupt handling. */
+ void (*do_interrupt)(CPUState *cpu);
/** @cpu_exec_interrupt: Callback for processing interrupts in cpu_exec */
bool (*cpu_exec_interrupt)(CPUState *cpu, int interrupt_request);
/**
--
2.34.1
next prev parent reply other threads:[~2024-01-28 4:46 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-28 4:41 [PATCH 00/33] tcg patch queue, pre-pull Richard Henderson
2024-01-28 4:41 ` [PATCH 01/33] cpu-exec: simplify jump cache management Richard Henderson
2024-01-28 4:41 ` [PATCH 02/33] include/exec: Move vaddr defines to separate file Richard Henderson
2024-01-28 4:41 ` [PATCH 03/33] hw/core: Include vaddr.h from cpu.h Richard Henderson
2024-01-28 4:41 ` [PATCH 04/33] target: Use vaddr in gen_intermediate_code Richard Henderson
2024-01-28 4:41 ` [PATCH 05/33] include/exec: Use vaddr in DisasContextBase for virtual addresses Richard Henderson
2024-01-28 4:41 ` [PATCH 06/33] include/exec: typedef abi_ptr to vaddr Richard Henderson
2024-01-28 4:41 ` [PATCH 07/33] target: Uninline cpu_mmu_index() Richard Henderson
2024-01-28 16:41 ` Philippe Mathieu-Daudé
2024-01-28 16:45 ` Philippe Mathieu-Daudé
2024-01-28 4:41 ` [PATCH 08/33] target: Uninline cpu_get_tb_cpu_state() Richard Henderson
2024-01-28 4:41 ` [PATCH 09/33] include/exec: Move PAGE_* macros to common header Richard Henderson
2024-01-28 4:41 ` [PATCH 10/33] include/exec: Move cpu_*()/cpu_env() " Richard Henderson
2024-01-28 16:29 ` Philippe Mathieu-Daudé
2024-01-28 4:41 ` Richard Henderson [this message]
2024-01-28 4:41 ` [PATCH 12/33] include/hw/core: Remove i386 conditional on fake_user_interrupt Richard Henderson
2024-01-28 4:41 ` [PATCH 13/33] linux-user: Allow gdbstub to ignore page protection Richard Henderson
2024-01-28 4:41 ` [PATCH 14/33] tests/tcg: Factor out gdbstub test functions Richard Henderson
2024-01-29 9:38 ` Ilya Leoshkevich
2024-01-28 4:41 ` [PATCH 15/33] tests/tcg: Add the PROT_NONE gdbstub test Richard Henderson
2024-01-28 4:41 ` [PATCH 16/33] accel/tcg/cpu-exec: Use RCU_READ_LOCK_GUARD Richard Henderson
2024-01-28 16:27 ` Philippe Mathieu-Daudé
2024-01-28 4:41 ` [PATCH 17/33] target: Make qemu_target_page_mask() available for *-user Richard Henderson
2024-01-28 4:41 ` [PATCH 18/33] accel/tcg: Make use of qemu_target_page_mask() in perf.c Richard Henderson
2024-01-28 4:41 ` [PATCH 19/33] tcg: Make tb_cflags() usable from target-agnostic code Richard Henderson
2024-01-28 4:42 ` [PATCH 20/33] accel/tcg: Remove #ifdef TARGET_I386 from perf.c Richard Henderson
2024-01-28 4:42 ` [PATCH 21/33] accel/tcg: Move perf and debuginfo support to tcg/ Richard Henderson
2024-01-28 4:42 ` [PATCH 22/33] accel/tcg: Rename tcg_ss[] -> tcg_specific_ss[] in meson Richard Henderson
2024-01-28 4:42 ` [PATCH 23/33] accel/tcg: Rename tcg_cpus_destroy() -> tcg_cpu_destroy() Richard Henderson
2024-01-28 4:42 ` [PATCH 24/33] accel/tcg: Rename tcg_cpus_exec() -> tcg_cpu_exec() Richard Henderson
2024-01-28 4:42 ` [PATCH 25/33] accel/tcg: Un-inline icount_exit_request() for clarity Richard Henderson
2024-01-28 4:42 ` [PATCH 26/33] include/qemu: Add TCGCPUOps typedef to typedefs.h Richard Henderson
2024-01-28 16:24 ` Philippe Mathieu-Daudé
2024-01-28 4:42 ` [PATCH 27/33] target/loongarch: Constify loongarch_tcg_ops Richard Henderson
2024-01-28 4:42 ` [PATCH 28/33] accel/tcg: Use CPUState.cc instead of CPU_GET_CLASS in cpu-exec.c Richard Henderson
2024-01-28 4:42 ` [PATCH 29/33] accel/tcg: Introduce TCGCPUOps::need_replay_interrupt() handler Richard Henderson
2024-01-28 4:42 ` [PATCH 30/33] target/i386: Extract x86_need_replay_interrupt() from accel/tcg/ Richard Henderson
2024-01-28 4:42 ` [PATCH 31/33] accel/tcg: Inline need_replay_interrupt Richard Henderson
2024-01-28 4:42 ` [PATCH 32/33] accel/tcg: Introduce TCGCPUOps::cpu_exec_halt() handler Richard Henderson
2024-01-28 4:42 ` [PATCH 33/33] target/i386: Extract x86_cpu_exec_halt() from accel/tcg/ Richard Henderson
2024-01-28 6:30 ` [PATCH 00/33] tcg patch queue, pre-pull Richard Henderson
2024-01-29 18:36 ` Philippe Mathieu-Daudé
2024-01-28 16:30 ` Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240128044213.316480-12-richard.henderson@linaro.org \
--to=richard.henderson@linaro.org \
--cc=anjo@rev.ng \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).