From: Sven Schnelle <svens@stackframe.org>
To: Thomas Huth <thuth@redhat.com>, Fam Zheng <fam@euphon.net>
Cc: qemu-devel@nongnu.org, deller@gmx.de
Subject: [PATCH] hw/scsi/lsi53c895a: add missing decrement of reentrancy counter
Date: Sun, 28 Jan 2024 21:22:14 +0100 [thread overview]
Message-ID: <20240128202214.2644768-1-svens@stackframe.org> (raw)
When the maximum count of SCRIPTS instructions is reached, the code
stops execution and returns, but fails to decrement the reentrancy
counter. This effectively renders the SCSI controller unusable
because on next entry the reentrancy counter is still above the limit.
This bug was seen on HP-UX 10.20 which seems to trigger SCRIPTS
loops.
Fixes: b987718bbb ("hw/scsi/lsi53c895a: Fix reentrancy issues in the LSI controller (CVE-2023-0330)")
Signed-off-by: Sven Schnelle <svens@stackframe.org>
---
hw/scsi/lsi53c895a.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/hw/scsi/lsi53c895a.c b/hw/scsi/lsi53c895a.c
index 34e3b89287..d607a5f9fb 100644
--- a/hw/scsi/lsi53c895a.c
+++ b/hw/scsi/lsi53c895a.c
@@ -1159,6 +1159,7 @@ again:
lsi_script_scsi_interrupt(s, LSI_SIST0_UDC, 0);
lsi_disconnect(s);
trace_lsi_execute_script_stop();
+ reentrancy_level--;
return;
}
insn = read_dword(s, s->dsp);
--
2.43.0
next reply other threads:[~2024-01-28 20:23 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-28 20:22 Sven Schnelle [this message]
2024-01-29 4:16 ` [PATCH] hw/scsi/lsi53c895a: add missing decrement of reentrancy counter Thomas Huth
2024-01-29 6:17 ` Sven Schnelle
2024-01-29 6:24 ` Michael Tokarev
2024-01-30 18:41 ` Helge Deller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240128202214.2644768-1-svens@stackframe.org \
--to=svens@stackframe.org \
--cc=deller@gmx.de \
--cc=fam@euphon.net \
--cc=qemu-devel@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).