qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: peterx@redhat.com
To: Peter Maydell <peter.maydell@linaro.org>, qemu-devel@nongnu.org
Cc: Fabiano Rosas <farosas@suse.de>, peterx@redhat.com
Subject: [PULL 11/14] migration: Reference migration state around loadvm_postcopy_handle_run_bh
Date: Mon, 29 Jan 2024 11:04:02 +0800	[thread overview]
Message-ID: <20240129030405.177100-12-peterx@redhat.com> (raw)
In-Reply-To: <20240129030405.177100-1-peterx@redhat.com>

From: Fabiano Rosas <farosas@suse.de>

We need to hold a reference to the current_migration object around
async calls to avoid it been freed while still in use. Even on this
load-side function, we might still use the MigrationState, e.g to
check for capabilities.

Signed-off-by: Fabiano Rosas <farosas@suse.de>
Link: https://lore.kernel.org/r/20240119233922.32588-4-farosas@suse.de
Signed-off-by: Peter Xu <peterx@redhat.com>
---
 migration/savevm.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/migration/savevm.c b/migration/savevm.c
index 6410705ebe..93387350c7 100644
--- a/migration/savevm.c
+++ b/migration/savevm.c
@@ -2174,6 +2174,7 @@ static void loadvm_postcopy_handle_run_bh(void *opaque)
     qemu_bh_delete(mis->bh);
 
     trace_vmstate_downtime_checkpoint("dst-postcopy-bh-vm-started");
+    object_unref(OBJECT(migration_get_current()));
 }
 
 /* After all discards we can start running and asking for pages */
@@ -2189,6 +2190,7 @@ static int loadvm_postcopy_handle_run(MigrationIncomingState *mis)
 
     postcopy_state_set(POSTCOPY_INCOMING_RUNNING);
     mis->bh = qemu_bh_new(loadvm_postcopy_handle_run_bh, mis);
+    object_ref(OBJECT(migration_get_current()));
     qemu_bh_schedule(mis->bh);
 
     /* We need to finish reading the stream from the package
-- 
2.43.0



  parent reply	other threads:[~2024-01-29  3:06 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-29  3:03 [PULL 00/14] Migration 20240126 patches peterx
2024-01-29  3:03 ` [PULL 01/14] userfaultfd: use 1ULL to build ioctl masks peterx
2024-01-29  3:03 ` [PULL 02/14] migration: Plug memory leak on HMP migrate error path peterx
2024-01-29  3:03 ` [PULL 03/14] migration: Make threshold_size an uint64_t peterx
2024-01-29  3:03 ` [PULL 04/14] migration: Drop unnecessary check in ram's pending_exact() peterx
2024-01-29  3:03 ` [PULL 05/14] analyze-migration.py: Remove trick on parsing ramblocks peterx
2024-01-29  3:03 ` [PULL 06/14] ci: Add a migration compatibility test job peterx
2024-02-02 13:22   ` Peter Maydell
2024-02-02 13:47     ` Fabiano Rosas
2024-02-05  3:25       ` Peter Xu
2024-02-05 10:22         ` Daniel P. Berrangé
2024-02-05 10:45           ` Peter Xu
2024-02-05 10:49             ` Daniel P. Berrangé
2024-01-29  3:03 ` [PULL 07/14] ci: Disable migration compatibility tests for aarch64 peterx
2024-01-29  3:03 ` [PULL 08/14] migration/yank: Use channel features peterx
2024-01-29  3:04 ` [PULL 09/14] migration: Fix use-after-free of migration state object peterx
2024-01-29  3:04 ` [PULL 10/14] migration: Take reference to migration state around bg_migration_vm_start_bh peterx
2024-01-29  3:04 ` peterx [this message]
2024-01-29  3:04 ` [PULL 12/14] migration: Add a wrapper to qemu_bh_schedule peterx
2024-01-29  3:04 ` [PULL 13/14] migration: Centralize BH creation and dispatch peterx
2024-01-29  3:04 ` [PULL 14/14] Make 'uri' optional for migrate QAPI peterx
2024-01-29 17:22 ` [PULL 00/14] Migration 20240126 patches Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240129030405.177100-12-peterx@redhat.com \
    --to=peterx@redhat.com \
    --cc=farosas@suse.de \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).