qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Eugenio Pérez" <eperezma@redhat.com>
To: qemu-devel@nongnu.org, mst@redhat.com
Cc: si-wei.liu@oracle.com, leiyang@redhat.com, yajunw@nvidia.com,
	Ani Sinha <anisinha@redhat.com>, Jason Wang <jasowang@redhat.com>,
	dtatulea@nvidia.com, mcoqueli@redhat.com
Subject: [PATCH 0/2] Move net backend cleanup to NIC cleanup
Date: Mon, 29 Jan 2024 14:24:05 +0100	[thread overview]
Message-ID: <20240129132407.1474202-1-eperezma@redhat.com> (raw)

Commit a0d7215e33 ("vhost-vdpa: do not cleanup the vdpa/vhost-net
structures if peer nic is present") effectively delayed the backend
cleanup, allowing the frontend or the guest to access it resources as
long as the frontend NIC is still visible to the guest.

However it does not clean up the resources until the qemu process is
over.  This causes an effective leak if the device is deleted with
device_del, as there is no way to close the vdpa device.  This makes
impossible to re-add that device to this or other QEMU instances until
the first instance of QEMU is finished.

Move the cleanup from qemu_cleanup to the NIC deletion.

Fixes: a0d7215e33 ("vhost-vdpa: do not cleanup the vdpa/vhost-net structures if peer nic is present")
Acked-by: Jason Wang <jasowang@redhat.com>
Reported-by: Lei Yang <leiyang@redhat.com>
Signed-off-by: Eugenio Pérez <eperezma@redhat.com>

Eugenio Pérez (2):
  net: parameterize the removing client from nc list
  net: move backend cleanup to NIC cleanup

 net/net.c        | 30 ++++++++++++++++++++----------
 net/vhost-vdpa.c |  8 --------
 2 files changed, 20 insertions(+), 18 deletions(-)

-- 
2.39.3




             reply	other threads:[~2024-01-29 13:25 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-29 13:24 Eugenio Pérez [this message]
2024-01-29 13:24 ` [PATCH 1/2] net: parameterize the removing client from nc list Eugenio Pérez
2024-01-29 13:24 ` [PATCH 2/2] net: move backend cleanup to NIC cleanup Eugenio Pérez
2024-02-01  5:43 ` [PATCH 0/2] Move net " Jason Wang
2024-09-10  3:40   ` Si-Wei Liu
2024-09-10  3:46     ` Jason Wang
2024-09-11  9:04       ` Eugenio Perez Martin
2024-09-11 17:48         ` Eugenio Perez Martin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240129132407.1474202-1-eperezma@redhat.com \
    --to=eperezma@redhat.com \
    --cc=anisinha@redhat.com \
    --cc=dtatulea@nvidia.com \
    --cc=jasowang@redhat.com \
    --cc=leiyang@redhat.com \
    --cc=mcoqueli@redhat.com \
    --cc=mst@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=si-wei.liu@oracle.com \
    --cc=yajunw@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).