qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: qemu-devel@nongnu.org
Cc: qemu-arm@nongnu.org, "Tyrone Ting" <kfting@nuvoton.com>,
	"Subbaraya Sundeep" <sundeep.lkml@gmail.com>,
	"Alistair Francis" <alistair@alistair23.me>,
	"Igor Mitsyanko" <i.mitsyanko@gmail.com>,
	"Hao Wu" <wuhaotsh@google.com>,
	"Edgar E. Iglesias" <edgar.iglesias@gmail.com>,
	"Peter Maydell" <peter.maydell@linaro.org>,
	"Rob Herring" <robh@kernel.org>,
	"Philippe Mathieu-Daudé" <philmd@linaro.org>,
	"Richard Henderson" <richard.henderson@linaro.org>,
	"Gavin Shan" <gshan@redhat.com>
Subject: [PATCH v3 3/9] hw/arm/highbank: Add missing QOM parent for CPU cores
Date: Mon, 29 Jan 2024 16:18:22 +0100	[thread overview]
Message-ID: <20240129151828.59544-4-philmd@linaro.org> (raw)
In-Reply-To: <20240129151828.59544-1-philmd@linaro.org>

QDev objects created with qdev_new() need to manually add
their parent relationship with object_property_add_child().

Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Reviewed-by: Gavin Shan <gshan@redhat.com>
---
 hw/arm/highbank.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/hw/arm/highbank.c b/hw/arm/highbank.c
index e6e27d69af..b8d702c82c 100644
--- a/hw/arm/highbank.c
+++ b/hw/arm/highbank.c
@@ -209,6 +209,7 @@ static void calxeda_init(MachineState *machine, enum cxmachines machine_id)
         cpuobj = object_new(machine->cpu_type);
         cpu = ARM_CPU(cpuobj);
 
+        object_property_add_child(OBJECT(machine), "cpu[*]", cpuobj);
         object_property_set_int(cpuobj, "psci-conduit", QEMU_PSCI_CONDUIT_SMC,
                                 &error_abort);
 
-- 
2.41.0



  parent reply	other threads:[~2024-01-29 15:21 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-29 15:18 [PATCH v3 0/9] hw/arm: Check for CPU types in machine_run_board_init() Philippe Mathieu-Daudé
2024-01-29 15:18 ` [PATCH v3 1/9] hw/arm/exynos: Add missing QOM parent for CPU cores Philippe Mathieu-Daudé
2024-01-29 15:18 ` [PATCH v3 2/9] hw/arm/exynos: Check for CPU types in machine_run_board_init() Philippe Mathieu-Daudé
2024-01-29 15:18 ` Philippe Mathieu-Daudé [this message]
2024-01-29 15:18 ` [PATCH v3 4/9] hw/arm/highbank: " Philippe Mathieu-Daudé
2024-01-29 15:18 ` [PATCH v3 5/9] hw/arm/msf2: Simplify setting MachineClass::valid_cpu_types[] Philippe Mathieu-Daudé
2024-01-29 15:18 ` [PATCH v3 6/9] hw/arm/musca: " Philippe Mathieu-Daudé
2024-01-29 15:18 ` [PATCH v3 7/9] hw/arm/npcm7xx_boards: " Philippe Mathieu-Daudé
2024-01-29 15:18 ` [PATCH v3 8/9] hw/arm/vexpress: Check for CPU types in machine_run_board_init() Philippe Mathieu-Daudé
2024-01-29 15:18 ` [PATCH v3 9/9] hw/arm/zynq: " Philippe Mathieu-Daudé
2024-02-01 14:00 ` [PATCH v3 0/9] hw/arm: " Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240129151828.59544-4-philmd@linaro.org \
    --to=philmd@linaro.org \
    --cc=alistair@alistair23.me \
    --cc=edgar.iglesias@gmail.com \
    --cc=gshan@redhat.com \
    --cc=i.mitsyanko@gmail.com \
    --cc=kfting@nuvoton.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-arm@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=richard.henderson@linaro.org \
    --cc=robh@kernel.org \
    --cc=sundeep.lkml@gmail.com \
    --cc=wuhaotsh@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).