* [PATCH] hw/intc/xics: Include missing 'cpu.h' header
@ 2024-01-29 17:05 Philippe Mathieu-Daudé
2024-01-30 6:42 ` Thomas Huth
0 siblings, 1 reply; 2+ messages in thread
From: Philippe Mathieu-Daudé @ 2024-01-29 17:05 UTC (permalink / raw)
To: qemu-devel
Cc: Cédric Le Goater, Daniel Henrique Barboza,
Harsh Prateek Bora, Nicholas Piggin, David Gibson, qemu-ppc,
Anton Johansson, Thomas Huth, Philippe Mathieu-Daudé
Include missing headers in order to avoid when refactoring
unrelated headers:
hw/intc/xics.c: In function 'icp_realize':
hw/intc/xics.c:304:5: error: unknown type name 'PowerPCCPU'
304 | PowerPCCPU *cpu;
| ^~~~~~~~~~
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
---
hw/intc/xics.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/hw/intc/xics.c b/hw/intc/xics.c
index 8b25787227..700abfa7a6 100644
--- a/hw/intc/xics.c
+++ b/hw/intc/xics.c
@@ -40,6 +40,7 @@
#include "hw/irq.h"
#include "sysemu/kvm.h"
#include "sysemu/reset.h"
+#include "target/ppc/cpu.h"
void icp_pic_print_info(ICPState *icp, Monitor *mon)
{
--
2.41.0
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] hw/intc/xics: Include missing 'cpu.h' header
2024-01-29 17:05 [PATCH] hw/intc/xics: Include missing 'cpu.h' header Philippe Mathieu-Daudé
@ 2024-01-30 6:42 ` Thomas Huth
0 siblings, 0 replies; 2+ messages in thread
From: Thomas Huth @ 2024-01-30 6:42 UTC (permalink / raw)
To: Philippe Mathieu-Daudé, qemu-devel
Cc: Cédric Le Goater, Daniel Henrique Barboza,
Harsh Prateek Bora, Nicholas Piggin, David Gibson, qemu-ppc,
Anton Johansson, QEMU Trivial
On 29/01/2024 18.05, Philippe Mathieu-Daudé wrote:
> Include missing headers in order to avoid when refactoring
> unrelated headers:
>
> hw/intc/xics.c: In function 'icp_realize':
> hw/intc/xics.c:304:5: error: unknown type name 'PowerPCCPU'
> 304 | PowerPCCPU *cpu;
> | ^~~~~~~~~~
>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> ---
> hw/intc/xics.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/hw/intc/xics.c b/hw/intc/xics.c
> index 8b25787227..700abfa7a6 100644
> --- a/hw/intc/xics.c
> +++ b/hw/intc/xics.c
> @@ -40,6 +40,7 @@
> #include "hw/irq.h"
> #include "sysemu/kvm.h"
> #include "sysemu/reset.h"
> +#include "target/ppc/cpu.h"
>
> void icp_pic_print_info(ICPState *icp, Monitor *mon)
> {
Reviewed-by: Thomas Huth <thuth@redhat.com>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-01-30 6:43 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-01-29 17:05 [PATCH] hw/intc/xics: Include missing 'cpu.h' header Philippe Mathieu-Daudé
2024-01-30 6:42 ` Thomas Huth
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).