* [PATCH 0/3] acpi-build: Fix hint messages
@ 2024-01-30 15:56 Greg Kurz
2024-01-30 15:56 ` [PATCH 1/3] hw/i386: Add `\n` to hint message Greg Kurz
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Greg Kurz @ 2024-01-30 15:56 UTC (permalink / raw)
To: qemu-devel
Cc: Peter Maydell, qemu-arm, Shannon Zhao, Paolo Bonzini,
Richard Henderson, Song Gao, Michael S. Tsirkin, Igor Mammedov,
Marcel Apfelbaum, qemu-trivial, Eduardo Habkost, Ani Sinha,
Greg Kurz
ACPI build for ARM, i386 and Loongarch all have the
same warning report with a hint for the user. The
hint is printed with error_printf() as expected but
it lacks the terminating '\n'.
Greg Kurz (3):
hw/i386: Add `\n` to hint message
hw/loongarch: Add `\n` to hint message
hw/arm: Add `\n` to hint message
hw/arm/virt-acpi-build.c | 2 +-
hw/i386/acpi-build.c | 4 ++--
hw/loongarch/acpi-build.c | 2 +-
3 files changed, 4 insertions(+), 4 deletions(-)
--
2.43.0
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH 1/3] hw/i386: Add `\n` to hint message
2024-01-30 15:56 [PATCH 0/3] acpi-build: Fix hint messages Greg Kurz
@ 2024-01-30 15:56 ` Greg Kurz
2024-01-30 16:13 ` Ani Sinha
2024-01-30 15:56 ` [PATCH 2/3] hw/loongarch: " Greg Kurz
2024-01-30 15:56 ` [PATCH 3/3] hw/arm: " Greg Kurz
2 siblings, 1 reply; 6+ messages in thread
From: Greg Kurz @ 2024-01-30 15:56 UTC (permalink / raw)
To: qemu-devel
Cc: Peter Maydell, qemu-arm, Shannon Zhao, Paolo Bonzini,
Richard Henderson, Song Gao, Michael S. Tsirkin, Igor Mammedov,
Marcel Apfelbaum, qemu-trivial, Eduardo Habkost, Ani Sinha,
Greg Kurz
error_fprintf() doesn't add newlines.
Signed-off-by: Greg Kurz <groug@kaod.org>
---
hw/i386/acpi-build.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/hw/i386/acpi-build.c b/hw/i386/acpi-build.c
index edc979379c03..e990b0ae927f 100644
--- a/hw/i386/acpi-build.c
+++ b/hw/i386/acpi-build.c
@@ -2697,7 +2697,7 @@ void acpi_build(AcpiBuildTables *tables, MachineState *machine)
" migration may not work",
tables_blob->len, legacy_table_size);
error_printf("Try removing CPUs, NUMA nodes, memory slots"
- " or PCI bridges.");
+ " or PCI bridges.\n");
}
g_array_set_size(tables_blob, legacy_table_size);
} else {
@@ -2709,7 +2709,7 @@ void acpi_build(AcpiBuildTables *tables, MachineState *machine)
" migration may not work",
tables_blob->len, ACPI_BUILD_TABLE_SIZE / 2);
error_printf("Try removing CPUs, NUMA nodes, memory slots"
- " or PCI bridges.");
+ " or PCI bridges.\n");
}
acpi_align_size(tables_blob, ACPI_BUILD_TABLE_SIZE);
}
--
2.43.0
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH 2/3] hw/loongarch: Add `\n` to hint message
2024-01-30 15:56 [PATCH 0/3] acpi-build: Fix hint messages Greg Kurz
2024-01-30 15:56 ` [PATCH 1/3] hw/i386: Add `\n` to hint message Greg Kurz
@ 2024-01-30 15:56 ` Greg Kurz
2024-01-30 15:56 ` [PATCH 3/3] hw/arm: " Greg Kurz
2 siblings, 0 replies; 6+ messages in thread
From: Greg Kurz @ 2024-01-30 15:56 UTC (permalink / raw)
To: qemu-devel
Cc: Peter Maydell, qemu-arm, Shannon Zhao, Paolo Bonzini,
Richard Henderson, Song Gao, Michael S. Tsirkin, Igor Mammedov,
Marcel Apfelbaum, qemu-trivial, Eduardo Habkost, Ani Sinha,
Greg Kurz
error_fprintf() doesn't add newlines.
Signed-off-by: Greg Kurz <groug@kaod.org>
---
hw/loongarch/acpi-build.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/loongarch/acpi-build.c b/hw/loongarch/acpi-build.c
index 730bc4a748c4..a1c419874123 100644
--- a/hw/loongarch/acpi-build.c
+++ b/hw/loongarch/acpi-build.c
@@ -509,7 +509,7 @@ static void acpi_build(AcpiBuildTables *tables, MachineState *machine)
" migration may not work",
tables_blob->len, ACPI_BUILD_TABLE_SIZE / 2);
error_printf("Try removing CPUs, NUMA nodes, memory slots"
- " or PCI bridges.");
+ " or PCI bridges.\n");
}
acpi_align_size(tables->linker->cmd_blob, ACPI_BUILD_ALIGN_SIZE);
--
2.43.0
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH 3/3] hw/arm: Add `\n` to hint message
2024-01-30 15:56 [PATCH 0/3] acpi-build: Fix hint messages Greg Kurz
2024-01-30 15:56 ` [PATCH 1/3] hw/i386: Add `\n` to hint message Greg Kurz
2024-01-30 15:56 ` [PATCH 2/3] hw/loongarch: " Greg Kurz
@ 2024-01-30 15:56 ` Greg Kurz
2 siblings, 0 replies; 6+ messages in thread
From: Greg Kurz @ 2024-01-30 15:56 UTC (permalink / raw)
To: qemu-devel
Cc: Peter Maydell, qemu-arm, Shannon Zhao, Paolo Bonzini,
Richard Henderson, Song Gao, Michael S. Tsirkin, Igor Mammedov,
Marcel Apfelbaum, qemu-trivial, Eduardo Habkost, Ani Sinha,
Greg Kurz
error_fprintf() doesn't add newlines.
Signed-off-by: Greg Kurz <groug@kaod.org>
---
hw/arm/virt-acpi-build.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/arm/virt-acpi-build.c b/hw/arm/virt-acpi-build.c
index 17aeec7a6f56..48febde1ccd1 100644
--- a/hw/arm/virt-acpi-build.c
+++ b/hw/arm/virt-acpi-build.c
@@ -1008,7 +1008,7 @@ void virt_acpi_build(VirtMachineState *vms, AcpiBuildTables *tables)
" migration may not work",
tables_blob->len, ACPI_BUILD_TABLE_SIZE / 2);
error_printf("Try removing CPUs, NUMA nodes, memory slots"
- " or PCI bridges.");
+ " or PCI bridges.\n");
}
acpi_align_size(tables_blob, ACPI_BUILD_TABLE_SIZE);
--
2.43.0
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH 1/3] hw/i386: Add `\n` to hint message
2024-01-30 15:56 ` [PATCH 1/3] hw/i386: Add `\n` to hint message Greg Kurz
@ 2024-01-30 16:13 ` Ani Sinha
2024-01-30 17:06 ` Greg Kurz
0 siblings, 1 reply; 6+ messages in thread
From: Ani Sinha @ 2024-01-30 16:13 UTC (permalink / raw)
To: Greg Kurz
Cc: QEMU Developers, Peter Maydell, qemu-arm, Shannon Zhao,
Paolo Bonzini, Richard Henderson, Song Gao, Michael S. Tsirkin,
Igor Mammedov, Marcel Apfelbaum, qemu-trivial, Eduardo Habkost
> On 30-Jan-2024, at 21:26, Greg Kurz <groug@kaod.org> wrote:
>
> error_fprintf() doesn't add newlines.
^^^^^^^^^^^^^^^^^
Should be error_printf(). Ditto for other patches.
>
> Signed-off-by: Greg Kurz <groug@kaod.org>
> ---
> hw/i386/acpi-build.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/hw/i386/acpi-build.c b/hw/i386/acpi-build.c
> index edc979379c03..e990b0ae927f 100644
> --- a/hw/i386/acpi-build.c
> +++ b/hw/i386/acpi-build.c
> @@ -2697,7 +2697,7 @@ void acpi_build(AcpiBuildTables *tables, MachineState *machine)
> " migration may not work",
> tables_blob->len, legacy_table_size);
> error_printf("Try removing CPUs, NUMA nodes, memory slots"
> - " or PCI bridges.");
> + " or PCI bridges.\n");
> }
> g_array_set_size(tables_blob, legacy_table_size);
> } else {
> @@ -2709,7 +2709,7 @@ void acpi_build(AcpiBuildTables *tables, MachineState *machine)
> " migration may not work",
> tables_blob->len, ACPI_BUILD_TABLE_SIZE / 2);
> error_printf("Try removing CPUs, NUMA nodes, memory slots"
> - " or PCI bridges.");
> + " or PCI bridges.\n");
> }
> acpi_align_size(tables_blob, ACPI_BUILD_TABLE_SIZE);
> }
> --
> 2.43.0
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 1/3] hw/i386: Add `\n` to hint message
2024-01-30 16:13 ` Ani Sinha
@ 2024-01-30 17:06 ` Greg Kurz
0 siblings, 0 replies; 6+ messages in thread
From: Greg Kurz @ 2024-01-30 17:06 UTC (permalink / raw)
To: Ani Sinha
Cc: QEMU Developers, Peter Maydell, qemu-arm, Shannon Zhao,
Paolo Bonzini, Richard Henderson, Song Gao, Michael S. Tsirkin,
Igor Mammedov, Marcel Apfelbaum, qemu-trivial, Eduardo Habkost
On Tue, 30 Jan 2024 21:43:27 +0530
Ani Sinha <anisinha@redhat.com> wrote:
>
>
> > On 30-Jan-2024, at 21:26, Greg Kurz <groug@kaod.org> wrote:
> >
> > error_fprintf() doesn't add newlines.
>
> ^^^^^^^^^^^^^^^^^
>
> Should be error_printf(). Ditto for other patches.
>
Thanks. Posted a v2.
> >
> > Signed-off-by: Greg Kurz <groug@kaod.org>
> > ---
> > hw/i386/acpi-build.c | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/hw/i386/acpi-build.c b/hw/i386/acpi-build.c
> > index edc979379c03..e990b0ae927f 100644
> > --- a/hw/i386/acpi-build.c
> > +++ b/hw/i386/acpi-build.c
> > @@ -2697,7 +2697,7 @@ void acpi_build(AcpiBuildTables *tables, MachineState *machine)
> > " migration may not work",
> > tables_blob->len, legacy_table_size);
> > error_printf("Try removing CPUs, NUMA nodes, memory slots"
> > - " or PCI bridges.");
> > + " or PCI bridges.\n");
> > }
> > g_array_set_size(tables_blob, legacy_table_size);
> > } else {
> > @@ -2709,7 +2709,7 @@ void acpi_build(AcpiBuildTables *tables, MachineState *machine)
> > " migration may not work",
> > tables_blob->len, ACPI_BUILD_TABLE_SIZE / 2);
> > error_printf("Try removing CPUs, NUMA nodes, memory slots"
> > - " or PCI bridges.");
> > + " or PCI bridges.\n");
> > }
> > acpi_align_size(tables_blob, ACPI_BUILD_TABLE_SIZE);
> > }
> > --
> > 2.43.0
> >
>
--
Greg
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2024-01-30 17:07 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-01-30 15:56 [PATCH 0/3] acpi-build: Fix hint messages Greg Kurz
2024-01-30 15:56 ` [PATCH 1/3] hw/i386: Add `\n` to hint message Greg Kurz
2024-01-30 16:13 ` Ani Sinha
2024-01-30 17:06 ` Greg Kurz
2024-01-30 15:56 ` [PATCH 2/3] hw/loongarch: " Greg Kurz
2024-01-30 15:56 ` [PATCH 3/3] hw/arm: " Greg Kurz
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).