From: Stefan Hajnoczi <stefanha@redhat.com>
To: qemu-devel@nongnu.org
Cc: John Snow <jsnow@redhat.com>, Kevin Wolf <kwolf@redhat.com>,
qemu-block@nongnu.org, Hanna Reitz <hreitz@redhat.com>,
Xiang Zheng <zhengxiang9@huawei.com>
Subject: Re: [PATCH] pflash: fix sectors vs bytes confusion in blk_pread_nonzeroes()
Date: Tue, 30 Jan 2024 16:18:13 -0500 [thread overview]
Message-ID: <20240130211813.GD320474@fedora> (raw)
In-Reply-To: <20240130002712.257815-1-stefanha@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 717 bytes --]
On Mon, Jan 29, 2024 at 07:27:12PM -0500, Stefan Hajnoczi wrote:
> The following expression is incorrect because blk_pread_nonzeroes()
> deals in units of bytes, not sectors:
>
> bytes = MIN(size - offset, BDRV_REQUEST_MAX_SECTORS)
> ^^^^^^^
>
> BDRV_REQUEST_MAX_BYTES is the appropriate constant.
>
> Fixes: a4b15a8b9ef2 ("pflash: Only read non-zero parts of backend image")
> Cc: Xiang Zheng <zhengxiang9@huawei.com>
> Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
> ---
> hw/block/block.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Thanks, applied to my block tree:
https://gitlab.com/stefanha/qemu/commits/block
Stefan
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2024-01-30 21:18 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-30 0:27 [PATCH] pflash: fix sectors vs bytes confusion in blk_pread_nonzeroes() Stefan Hajnoczi
2024-01-30 8:31 ` Philippe Mathieu-Daudé
2024-01-30 21:18 ` Stefan Hajnoczi [this message]
2024-02-01 11:37 ` Michael Tokarev
2024-02-08 21:21 ` Stefan Hajnoczi
2024-02-09 7:44 ` Michael Tokarev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240130211813.GD320474@fedora \
--to=stefanha@redhat.com \
--cc=hreitz@redhat.com \
--cc=jsnow@redhat.com \
--cc=kwolf@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=zhengxiang9@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).