From: dongwon.kim@intel.com
To: qemu-devel@nongnu.org
Subject: [PATCH 3/3] ui/gtk: reset visible flag when window is minimized
Date: Tue, 30 Jan 2024 15:48:40 -0800 [thread overview]
Message-ID: <20240130234840.53122-4-dongwon.kim@intel.com> (raw)
In-Reply-To: <20240130234840.53122-1-dongwon.kim@intel.com>
From: Dongwon Kim <dongwon.kim@intel.com>
Adding a callback for window-state-event that resets the flag, 'visible'
when associated window is minimized or restored. When minimizing, it cancels
any of queued draw events associated with the VC.
Cc: Marc-André Lureau <marcandre.lureau@redhat.com>
Cc: Gerd Hoffmann <kraxel@redhat.com>
Cc: Vivek Kasireddy <vivek.kasireddy@intel.com>
Signed-off-by: Dongwon Kim <dongwon.kim@intel.com>
---
ui/gtk.c | 39 +++++++++++++++++++++++++++++++++++++++
1 file changed, 39 insertions(+)
diff --git a/ui/gtk.c b/ui/gtk.c
index 651ed3492f..5bbcb7de62 100644
--- a/ui/gtk.c
+++ b/ui/gtk.c
@@ -1381,6 +1381,37 @@ static gboolean gd_tab_window_close(GtkWidget *widget, GdkEvent *event,
return TRUE;
}
+static gboolean gd_window_state_event(GtkWidget *widget, GdkEvent *event,
+ void *opaque)
+{
+ VirtualConsole *vc = opaque;
+
+ if (!vc) {
+ return TRUE;
+ }
+
+ if (event->window_state.new_window_state & GDK_WINDOW_STATE_ICONIFIED) {
+ vc->gfx.visible = false;
+ gd_set_ui_size(vc, 0, 0);
+ if (vc->gfx.guest_fb.dmabuf &&
+ vc->gfx.guest_fb.dmabuf->draw_submitted) {
+ vc->gfx.guest_fb.dmabuf->draw_submitted = false;
+ graphic_hw_gl_block(vc->gfx.dcl.con, false);
+ }
+ /* Showing the ui only if window exists except for the current vc as GTK
+ * window for 's' is being used to display the GUI */
+ } else if (vc->window || vc == gd_vc_find_current(vc->s)) {
+ GdkWindow *window;
+ window = gtk_widget_get_window(vc->gfx.drawing_area);
+ gd_set_ui_size(vc, gdk_window_get_width(window),
+ gdk_window_get_height(window));
+
+ vc->gfx.visible = true;
+ }
+
+ return TRUE;
+}
+
static gboolean gd_win_grab(void *opaque)
{
VirtualConsole *vc = opaque;
@@ -1422,6 +1453,9 @@ static void gd_menu_untabify(GtkMenuItem *item, void *opaque)
g_signal_connect(vc->window, "delete-event",
G_CALLBACK(gd_tab_window_close), vc);
+ g_signal_connect(vc->window, "window-state-event",
+ G_CALLBACK(gd_window_state_event), vc);
+
gtk_widget_show_all(vc->window);
if (qemu_console_is_graphic(vc->gfx.dcl.con)) {
@@ -2470,6 +2504,11 @@ static void gtk_display_init(DisplayState *ds, DisplayOptions *opts)
}
vc = gd_vc_find_current(s);
+
+ g_signal_connect(s->window, "window-state-event",
+ G_CALLBACK(gd_window_state_event),
+ vc);
+
gtk_widget_set_sensitive(s->view_menu, vc != NULL);
#ifdef CONFIG_VTE
gtk_widget_set_sensitive(s->copy_item,
--
2.34.1
next prev parent reply other threads:[~2024-01-30 23:50 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-30 23:48 [PATCH 0/3] ui/gtk: introducing vc->visible dongwon.kim
2024-01-30 23:48 ` [PATCH 1/3] ui/gtk: skip drawing guest scanout when associated VC is invisible dongwon.kim
2024-01-31 7:08 ` Marc-André Lureau
2024-01-31 18:56 ` Kim, Dongwon
2024-02-01 6:42 ` Marc-André Lureau
2024-02-01 18:48 ` Kim, Dongwon
2024-03-07 9:46 ` Daniel P. Berrangé
2024-03-07 17:53 ` Kim, Dongwon
2024-03-07 18:01 ` Daniel P. Berrangé
2024-03-07 19:50 ` Kim, Dongwon
2024-03-07 9:40 ` Daniel P. Berrangé
2024-03-07 17:34 ` Kim, Dongwon
2024-01-30 23:48 ` [PATCH 2/3] ui/gtk: set the ui size to 0 when invisible dongwon.kim
2024-01-31 7:12 ` Marc-André Lureau
2024-01-31 19:10 ` Kim, Dongwon
2024-03-07 9:47 ` Daniel P. Berrangé
2024-01-30 23:48 ` dongwon.kim [this message]
2024-03-01 0:05 ` [PATCH 0/3] ui/gtk: introducing vc->visible Kim, Dongwon
2024-03-05 12:18 ` Marc-André Lureau
2024-03-07 9:49 ` Daniel P. Berrangé
2024-03-08 0:56 ` Kim, Dongwon
2024-03-08 7:43 ` Marc-André Lureau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240130234840.53122-4-dongwon.kim@intel.com \
--to=dongwon.kim@intel.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).