From: "Eugenio Pérez" <eperezma@redhat.com>
To: qemu-devel@nongnu.org
Cc: Peter Xu <peterx@redhat.com>,
"Michael S. Tsirkin" <mst@redhat.com>,
Jason Wang <jasowang@redhat.com>,
Laurent Vivier <lvivier@redhat.com>,
Dragos Tatulea <dtatulea@nvidia.com>,
Lei Yang <leiyang@redhat.com>, Parav Pandit <parav@mellanox.com>,
Stefano Garzarella <sgarzare@redhat.com>,
Si-Wei Liu <si-wei.liu@oracle.com>,
Zhu Lingshan <lingshan.zhu@intel.com>
Subject: [PATCH v2 3/7] vdpa: set backend capabilities at vhost_vdpa_init
Date: Thu, 1 Feb 2024 19:09:20 +0100 [thread overview]
Message-ID: <20240201180924.487579-4-eperezma@redhat.com> (raw)
In-Reply-To: <20240201180924.487579-1-eperezma@redhat.com>
The backend does not reset them until the vdpa file descriptor is closed
so there is no harm in doing it only once.
This allows the destination of a live migration to premap memory in
batches, using VHOST_BACKEND_F_IOTLB_BATCH.
Signed-off-by: Eugenio Pérez <eperezma@redhat.com>
---
hw/virtio/vhost-vdpa.c | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/hw/virtio/vhost-vdpa.c b/hw/virtio/vhost-vdpa.c
index 33ae285f87..bd4db7ba5f 100644
--- a/hw/virtio/vhost-vdpa.c
+++ b/hw/virtio/vhost-vdpa.c
@@ -620,6 +620,12 @@ static int vhost_vdpa_init(struct vhost_dev *dev, void *opaque, Error **errp)
v->dev = dev;
dev->opaque = opaque ;
v->shared->listener = vhost_vdpa_memory_listener;
+
+ ret = vhost_vdpa_set_backend_cap(dev);
+ if (unlikely(ret != 0)) {
+ return ret;
+ }
+
vhost_vdpa_init_svq(dev, v);
error_propagate(&dev->migration_blocker, v->migration_blocker);
@@ -1506,7 +1512,6 @@ const VhostOps vdpa_ops = {
.vhost_set_vring_kick = vhost_vdpa_set_vring_kick,
.vhost_set_vring_call = vhost_vdpa_set_vring_call,
.vhost_get_features = vhost_vdpa_get_features,
- .vhost_set_backend_cap = vhost_vdpa_set_backend_cap,
.vhost_set_owner = vhost_vdpa_set_owner,
.vhost_set_vring_endian = NULL,
.vhost_backend_memslots_limit = vhost_vdpa_memslots_limit,
--
2.43.0
next prev parent reply other threads:[~2024-02-01 18:11 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-01 18:09 [PATCH v2 0/7] Move memory listener register to vhost_vdpa_init Eugenio Pérez
2024-02-01 18:09 ` [PATCH v2 1/7] vdpa: check for iova tree initialized at net_client_start Eugenio Pérez
2024-02-01 18:09 ` [PATCH v2 2/7] vdpa: reorder vhost_vdpa_set_backend_cap Eugenio Pérez
2024-02-01 18:09 ` Eugenio Pérez [this message]
2024-02-01 18:09 ` [PATCH v2 4/7] vdpa: add listener_registered Eugenio Pérez
2024-02-01 18:09 ` [PATCH v2 5/7] vdpa: reorder listener assignment Eugenio Pérez
2024-02-01 18:09 ` [PATCH v2 6/7] vdpa: move iova_tree allocation to net_vhost_vdpa_init Eugenio Pérez
2024-02-06 1:10 ` Si-Wei Liu
2024-02-13 10:22 ` Michael S. Tsirkin
2024-02-13 16:26 ` Eugenio Perez Martin
2024-02-14 18:37 ` Si-Wei Liu
2024-02-14 18:29 ` Si-Wei Liu
2024-02-14 19:11 ` Eugenio Perez Martin
2024-04-02 6:19 ` Si-Wei Liu
2024-04-02 12:01 ` Eugenio Perez Martin
2024-04-03 6:53 ` Si-Wei Liu
2024-04-03 8:46 ` Eugenio Perez Martin
2024-02-01 18:09 ` [PATCH v2 7/7] vdpa: move memory listener register to vhost_vdpa_init Eugenio Pérez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240201180924.487579-4-eperezma@redhat.com \
--to=eperezma@redhat.com \
--cc=dtatulea@nvidia.com \
--cc=jasowang@redhat.com \
--cc=leiyang@redhat.com \
--cc=lingshan.zhu@intel.com \
--cc=lvivier@redhat.com \
--cc=mst@redhat.com \
--cc=parav@mellanox.com \
--cc=peterx@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=sgarzare@redhat.com \
--cc=si-wei.liu@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).