From: Ilya Leoshkevich <iii@linux.ibm.com>
To: "Warner Losh" <imp@bsdimp.com>,
"Alex Bennée" <alex.bennee@linaro.org>,
"Laurent Vivier" <laurent@vivier.eu>
Cc: "Kyle Evans" <kevans@freebsd.org>,
"Philippe Mathieu-Daudé" <philmd@linaro.org>,
qemu-devel@nongnu.org, "Ilya Leoshkevich" <iii@linux.ibm.com>
Subject: [PATCH v2 04/11] {linux,bsd}-user: Pass pid to fork_end()
Date: Mon, 5 Feb 2024 12:22:18 +0100 [thread overview]
Message-ID: <20240205112251.121569-5-iii@linux.ibm.com> (raw)
In-Reply-To: <20240205112251.121569-1-iii@linux.ibm.com>
The upcoming follow-fork-mode child support requires knowing the child
pid. Pass it down.
Signed-off-by: Ilya Leoshkevich <iii@linux.ibm.com>
---
bsd-user/freebsd/os-proc.h | 6 +++---
bsd-user/main.c | 4 +++-
bsd-user/qemu.h | 2 +-
linux-user/main.c | 4 +++-
linux-user/syscall.c | 6 +++---
linux-user/user-internals.h | 2 +-
6 files changed, 14 insertions(+), 10 deletions(-)
diff --git a/bsd-user/freebsd/os-proc.h b/bsd-user/freebsd/os-proc.h
index d6418780344..3003c8cb637 100644
--- a/bsd-user/freebsd/os-proc.h
+++ b/bsd-user/freebsd/os-proc.h
@@ -208,7 +208,7 @@ static inline abi_long do_freebsd_fork(void *cpu_env)
*/
set_second_rval(cpu_env, child_flag);
- fork_end(child_flag);
+ fork_end(ret);
return ret;
}
@@ -252,7 +252,7 @@ static inline abi_long do_freebsd_rfork(void *cpu_env, abi_long flags)
* value: 0 for parent process, 1 for child process.
*/
set_second_rval(cpu_env, child_flag);
- fork_end(child_flag);
+ fork_end(ret);
return ret;
@@ -285,7 +285,7 @@ static inline abi_long do_freebsd_pdfork(void *cpu_env, abi_ulong target_fdp,
* value: 0 for parent process, 1 for child process.
*/
set_second_rval(cpu_env, child_flag);
- fork_end(child_flag);
+ fork_end(ret);
return ret;
}
diff --git a/bsd-user/main.c b/bsd-user/main.c
index bfe6888ea89..bc233a85cef 100644
--- a/bsd-user/main.c
+++ b/bsd-user/main.c
@@ -109,8 +109,10 @@ void fork_start(void)
gdbserver_fork_start();
}
-void fork_end(int child)
+void fork_end(abi_long pid)
{
+ int child = pid == 0;
+
if (child) {
CPUState *cpu, *next_cpu;
/*
diff --git a/bsd-user/qemu.h b/bsd-user/qemu.h
index dc842fffa7d..2414a87559b 100644
--- a/bsd-user/qemu.h
+++ b/bsd-user/qemu.h
@@ -180,7 +180,7 @@ void cpu_loop(CPUArchState *env);
char *target_strerror(int err);
int get_osversion(void);
void fork_start(void);
-void fork_end(int child);
+void fork_end(abi_long pid);
#include "qemu/log.h"
diff --git a/linux-user/main.c b/linux-user/main.c
index 8c7bea1c631..f1a0267816b 100644
--- a/linux-user/main.c
+++ b/linux-user/main.c
@@ -147,8 +147,10 @@ void fork_start(void)
gdbserver_fork_start();
}
-void fork_end(int child)
+void fork_end(abi_long pid)
{
+ int child = pid == 0;
+
qemu_plugin_user_postfork(child);
mmap_fork_end(child);
if (child) {
diff --git a/linux-user/syscall.c b/linux-user/syscall.c
index aeb95644873..9e628a0f975 100644
--- a/linux-user/syscall.c
+++ b/linux-user/syscall.c
@@ -6669,7 +6669,7 @@ static int do_fork(CPUArchState *env, unsigned int flags, abi_ulong newsp,
if (ret == 0) {
/* Child Process. */
cpu_clone_regs_child(env, newsp, flags);
- fork_end(1);
+ fork_end(ret);
/* There is a race condition here. The parent process could
theoretically read the TID in the child process before the child
tid is set. This would require using either ptrace
@@ -6700,8 +6700,8 @@ static int do_fork(CPUArchState *env, unsigned int flags, abi_ulong newsp,
}
#endif
put_user_u32(pid_fd, parent_tidptr);
- }
- fork_end(0);
+ }
+ fork_end(ret);
}
g_assert(!cpu_in_exclusive_context(cpu));
}
diff --git a/linux-user/user-internals.h b/linux-user/user-internals.h
index c63ef45fc78..9014014d920 100644
--- a/linux-user/user-internals.h
+++ b/linux-user/user-internals.h
@@ -71,7 +71,7 @@ const char *target_strerror(int err);
int get_osversion(void);
void init_qemu_uname_release(void);
void fork_start(void);
-void fork_end(int child);
+void fork_end(abi_long pid);
/**
* probe_guest_base:
--
2.43.0
next prev parent reply other threads:[~2024-02-05 11:25 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-05 11:22 [PATCH v2 00/11] gdbstub: Implement follow-fork-mode child Ilya Leoshkevich
2024-02-05 11:22 ` [PATCH v2 01/11] gdbstub: Support disablement in a multi-threaded process Ilya Leoshkevich
2024-02-05 11:22 ` [PATCH v2 02/11] {linux,bsd}-user: Update ts_tid after fork() Ilya Leoshkevich
2024-02-05 11:22 ` [PATCH v2 03/11] gdbstub: Introduce gdbserver_fork_start() Ilya Leoshkevich
2024-02-05 11:22 ` Ilya Leoshkevich [this message]
2024-02-05 11:22 ` [PATCH v2 05/11] {linux,bsd}-user: Pass pid to gdbserver_fork() Ilya Leoshkevich
2024-02-05 11:22 ` [PATCH v2 06/11] gdbstub: Call gdbserver_fork() both in parent and in child Ilya Leoshkevich
2024-02-05 11:22 ` [PATCH v2 07/11] gdbstub: Introduce gdb_handle_query_supported_user() Ilya Leoshkevich
2024-02-05 11:22 ` [PATCH v2 08/11] gdbstub: Introduce gdb_handle_set_thread_user() Ilya Leoshkevich
2024-02-05 11:22 ` [PATCH v2 09/11] gdbstub: Introduce gdb_handle_detach_user() Ilya Leoshkevich
2024-02-05 11:22 ` [PATCH v2 10/11] gdbstub: Implement follow-fork-mode child Ilya Leoshkevich
2024-02-05 11:22 ` [PATCH v2 11/11] tests/tcg: Add two follow-fork-mode tests Ilya Leoshkevich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240205112251.121569-5-iii@linux.ibm.com \
--to=iii@linux.ibm.com \
--cc=alex.bennee@linaro.org \
--cc=imp@bsdimp.com \
--cc=kevans@freebsd.org \
--cc=laurent@vivier.eu \
--cc=philmd@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).