From: Ilya Leoshkevich <iii@linux.ibm.com>
To: "Warner Losh" <imp@bsdimp.com>,
"Alex Bennée" <alex.bennee@linaro.org>,
"Laurent Vivier" <laurent@vivier.eu>
Cc: "Kyle Evans" <kevans@freebsd.org>,
"Philippe Mathieu-Daudé" <philmd@linaro.org>,
qemu-devel@nongnu.org, "Ilya Leoshkevich" <iii@linux.ibm.com>
Subject: [PATCH v2 06/11] gdbstub: Call gdbserver_fork() both in parent and in child
Date: Mon, 5 Feb 2024 12:22:20 +0100 [thread overview]
Message-ID: <20240205112251.121569-7-iii@linux.ibm.com> (raw)
In-Reply-To: <20240205112251.121569-1-iii@linux.ibm.com>
The upcoming follow-fork-mode child support requires post-fork message
exchange between the parent and the child. Prepare gdbserver_fork() for
this purpose. Rename it to gdbserver_fork_end() to better reflect its
purpose.
Signed-off-by: Ilya Leoshkevich <iii@linux.ibm.com>
---
bsd-user/main.c | 3 ++-
gdbstub/user.c | 5 ++---
include/gdbstub/user.h | 6 +++---
linux-user/main.c | 2 +-
4 files changed, 8 insertions(+), 8 deletions(-)
diff --git a/bsd-user/main.c b/bsd-user/main.c
index e8c658eda5d..1890d6365f7 100644
--- a/bsd-user/main.c
+++ b/bsd-user/main.c
@@ -131,10 +131,11 @@ void fork_end(abi_long pid)
*/
qemu_init_cpu_list();
((TaskState *)thread_cpu->opaque)->ts_tid = qemu_get_thread_id();
- gdbserver_fork(pid);
+ gdbserver_fork_end(pid);
} else {
mmap_fork_end(child);
cpu_list_unlock();
+ gdbserver_fork_end(pid);
end_exclusive();
}
}
diff --git a/gdbstub/user.c b/gdbstub/user.c
index d3a749f3e7e..df5a618e789 100644
--- a/gdbstub/user.c
+++ b/gdbstub/user.c
@@ -374,10 +374,9 @@ static void disable_gdbstub(void)
}
}
-/* Disable gdb stub for child processes. */
-void gdbserver_fork(pid_t pid)
+void gdbserver_fork_end(pid_t pid)
{
- if (!gdbserver_state.init || gdbserver_user_state.fd < 0) {
+ if (pid != 0 || !gdbserver_state.init || gdbserver_user_state.fd < 0) {
return;
}
disable_gdbstub();
diff --git a/include/gdbstub/user.h b/include/gdbstub/user.h
index 66dd0d319cf..dd03dbdd6df 100644
--- a/include/gdbstub/user.h
+++ b/include/gdbstub/user.h
@@ -51,10 +51,10 @@ void gdb_signalled(CPUArchState *as, int sig);
void gdbserver_fork_start(void);
/**
- * gdbserver_fork() - disable gdb stub for child processes.
- * @cs: CPU
+ * gdbserver_fork_end() - inform gdb of the completed fork()
+ * @pid: 0 if in child process, -1 if fork failed, child process pid otherwise
*/
-void gdbserver_fork(pid_t pid);
+void gdbserver_fork_end(pid_t pid);
/**
* gdb_syscall_entry() - inform gdb of syscall entry and yield control to it
diff --git a/linux-user/main.c b/linux-user/main.c
index ad1c6394520..dde5081e2f4 100644
--- a/linux-user/main.c
+++ b/linux-user/main.c
@@ -164,10 +164,10 @@ void fork_end(abi_long pid)
}
qemu_init_cpu_list();
((TaskState *)thread_cpu->opaque)->ts_tid = qemu_get_thread_id();
- gdbserver_fork(pid);
} else {
cpu_list_unlock();
}
+ gdbserver_fork_end(pid);
/*
* qemu_init_cpu_list() reinitialized the child exclusive state, but we
* also need to keep current_cpu consistent, so call end_exclusive() for
--
2.43.0
next prev parent reply other threads:[~2024-02-05 11:24 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-05 11:22 [PATCH v2 00/11] gdbstub: Implement follow-fork-mode child Ilya Leoshkevich
2024-02-05 11:22 ` [PATCH v2 01/11] gdbstub: Support disablement in a multi-threaded process Ilya Leoshkevich
2024-02-05 11:22 ` [PATCH v2 02/11] {linux,bsd}-user: Update ts_tid after fork() Ilya Leoshkevich
2024-02-05 11:22 ` [PATCH v2 03/11] gdbstub: Introduce gdbserver_fork_start() Ilya Leoshkevich
2024-02-05 11:22 ` [PATCH v2 04/11] {linux,bsd}-user: Pass pid to fork_end() Ilya Leoshkevich
2024-02-05 11:22 ` [PATCH v2 05/11] {linux,bsd}-user: Pass pid to gdbserver_fork() Ilya Leoshkevich
2024-02-05 11:22 ` Ilya Leoshkevich [this message]
2024-02-05 11:22 ` [PATCH v2 07/11] gdbstub: Introduce gdb_handle_query_supported_user() Ilya Leoshkevich
2024-02-05 11:22 ` [PATCH v2 08/11] gdbstub: Introduce gdb_handle_set_thread_user() Ilya Leoshkevich
2024-02-05 11:22 ` [PATCH v2 09/11] gdbstub: Introduce gdb_handle_detach_user() Ilya Leoshkevich
2024-02-05 11:22 ` [PATCH v2 10/11] gdbstub: Implement follow-fork-mode child Ilya Leoshkevich
2024-02-05 11:22 ` [PATCH v2 11/11] tests/tcg: Add two follow-fork-mode tests Ilya Leoshkevich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240205112251.121569-7-iii@linux.ibm.com \
--to=iii@linux.ibm.com \
--cc=alex.bennee@linaro.org \
--cc=imp@bsdimp.com \
--cc=kevans@freebsd.org \
--cc=laurent@vivier.eu \
--cc=philmd@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).