qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Jens Nyberg <jens.nyberg@gmail.com>
To: qemu-devel@nongnu.org
Cc: Jens Nyberg <jens.nyberg@gmail.com>
Subject: [PATCH] hw/i386/multiboot: Make bootloader_name static
Date: Mon,  5 Feb 2024 22:51:48 +0100	[thread overview]
Message-ID: <20240205215148.2356410-1-jens.nyberg@gmail.com> (raw)

Global variable is only used in a single file and should therefor be set to
static in order to avoid name collisions.

Signed-off-by: Jens Nyberg <jens.nyberg@gmail.com>
---
 hw/i386/multiboot.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/hw/i386/multiboot.c b/hw/i386/multiboot.c
index 3332712ab3..6bf6398d01 100644
--- a/hw/i386/multiboot.c
+++ b/hw/i386/multiboot.c
@@ -102,7 +102,7 @@ typedef struct {
     int mb_mods_count;
 } MultibootState;
 
-const char *bootloader_name = "qemu";
+static const char *bootloader_name = "qemu";
 
 static uint32_t mb_add_cmdline(MultibootState *s, const char *cmdline)
 {
-- 
2.43.0



                 reply	other threads:[~2024-02-05 21:53 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240205215148.2356410-1-jens.nyberg@gmail.com \
    --to=jens.nyberg@gmail.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).