From: Taylor Simpson <ltaylorsimpson@gmail.com>
To: qemu-devel@nongnu.org
Cc: bcain@quicinc.com, quic_mathbern@quicinc.com,
sidneym@quicinc.com, quic_mliebel@quicinc.com,
richard.henderson@linaro.org, philmd@linaro.org, ale@rev.ng,
anjo@rev.ng, ltaylorsimpson@gmail.com
Subject: [PATCH v2 0/3] Hexagon (target/hexagon) Only pass env to generated helper when needed
Date: Mon, 5 Feb 2024 17:50:31 -0700 [thread overview]
Message-ID: <20240206005034.267283-1-ltaylorsimpson@gmail.com> (raw)
Currently, we pass env to every generated helper. When the semantics of
the instruction only depend on the arguments, this is unnecessary and
adds extra overhead to the helper call.
**** Changes in v2 ****
- Separate patches to pass P0 and SP explicitly to helpers that need it
- Add the TCG_CALL_NO_RWG_SE flag to any non-HVX helpers that
don't get ptr to env
Taylor Simpson (3):
Hexagon (target/hexagon) Pass P0 explicitly to helpers that need it
Hexagon (target/hexagon) Pass SP explicitly to helpers that need it
Hexagon (target/hexagon) Only pass env to generated helper when needed
target/hexagon/gen_tcg.h | 3 ++
target/hexagon/macros.h | 4 +--
target/hexagon/attribs_def.h.inc | 1 +
target/hexagon/gen_helper_protos.py | 10 ++++++-
target/hexagon/hex_common.py | 44 +++++++++++++++++++++++++----
5 files changed, 54 insertions(+), 8 deletions(-)
--
2.34.1
next reply other threads:[~2024-02-06 0:51 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-06 0:50 Taylor Simpson [this message]
2024-02-06 0:50 ` [PATCH v2 1/3] Hexagon (target/hexagon) Pass P0 explicitly to helpers that need it Taylor Simpson
2024-02-06 0:50 ` [PATCH v2 2/3] Hexagon (target/hexagon) Pass SP " Taylor Simpson
2024-02-06 0:50 ` [PATCH v2 3/3] Hexagon (target/hexagon) Only pass env to generated helper when needed Taylor Simpson
2024-02-07 15:16 ` [PATCH v2 0/3] " Anton Johansson via
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240206005034.267283-1-ltaylorsimpson@gmail.com \
--to=ltaylorsimpson@gmail.com \
--cc=ale@rev.ng \
--cc=anjo@rev.ng \
--cc=bcain@quicinc.com \
--cc=philmd@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=quic_mathbern@quicinc.com \
--cc=quic_mliebel@quicinc.com \
--cc=richard.henderson@linaro.org \
--cc=sidneym@quicinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).