qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: deller@kernel.org
To: qemu-devel@nongnu.org
Cc: Richard Henderson <richard.henderson@linaro.org>,
	Helge Deller <deller@gmx.de>
Subject: [PATCH 02/13] target/hppa: Add "diag 0x101" for console output support
Date: Wed,  7 Feb 2024 19:20:12 +0100	[thread overview]
Message-ID: <20240207182023.36316-3-deller@kernel.org> (raw)
In-Reply-To: <20240207182023.36316-1-deller@kernel.org>

From: Helge Deller <deller@gmx.de>

For debugging purposes at the early stage of the bootup process,
the SeaBIOS-hppa firmware sometimes needs to output characters to the
serial console. Note that the serial console is the default output
method for parisc machines.

At this stage PCI busses and other devices haven't been initialized
yet. So, SeaBIOS-hppa will not be able to find the correct I/O ports
for the serial ports yet.

Instead, add an emulation for the "diag 0x101" opcode to assist here.
Without any other dependencies, SeaBIOS-hppa can then load the character
to be printed in register %r26 and issue the diag assembly instruction.

The qemu diag_console_output() helper function will then print
that character to the first serial port.

Signed-off-by: Helge Deller <deller@gmx.de>
---
 target/hppa/helper.h    |  1 +
 target/hppa/op_helper.c | 32 ++++++++++++++++++++++++++++++++
 target/hppa/translate.c |  6 ++++++
 3 files changed, 39 insertions(+)

diff --git a/target/hppa/helper.h b/target/hppa/helper.h
index 20698f68ed..1bdbcd8f98 100644
--- a/target/hppa/helper.h
+++ b/target/hppa/helper.h
@@ -103,4 +103,5 @@ DEF_HELPER_FLAGS_1(ptlbe, TCG_CALL_NO_RWG, void, env)
 DEF_HELPER_FLAGS_2(lpa, TCG_CALL_NO_WG, tl, env, tl)
 DEF_HELPER_FLAGS_1(change_prot_id, TCG_CALL_NO_RWG, void, env)
 DEF_HELPER_1(diag_btlb, void, env)
+DEF_HELPER_1(diag_console_output, void, env)
 #endif
diff --git a/target/hppa/op_helper.c b/target/hppa/op_helper.c
index b1f24a5aad..2c2c4aa183 100644
--- a/target/hppa/op_helper.c
+++ b/target/hppa/op_helper.c
@@ -24,6 +24,8 @@
 #include "exec/helper-proto.h"
 #include "exec/cpu_ldst.h"
 #include "qemu/timer.h"
+#include "sysemu/sysemu.h"
+#include "chardev/char-fe.h"
 #include "trace.h"
 
 G_NORETURN void HELPER(excp)(CPUHPPAState *env, int excp)
@@ -484,3 +486,33 @@ uint64_t HELPER(hshradd)(uint64_t r1, uint64_t r2, uint32_t sh)
     }
     return ret;
 }
+
+/*
+ * diag_console_output() is a helper function used during the initial bootup
+ * process of the SeaBIOS-hppa firmware.  During the bootup phase, addresses of
+ * serial ports on e.g. PCI busses are unknown and most other devices haven't
+ * been initialized and configured yet.  With help of a simple "diag" assembler
+ * instruction and an ASCII character code in register %r26 firmware can easily
+ * print debug output without any dependencies to the first serial port and use
+ * that as serial console.
+ */
+void HELPER(diag_console_output)(CPUHPPAState *env)
+{
+    CharBackend *serial_backend;
+    Chardev *serial_port;
+    unsigned char c;
+
+    /* find first serial port */
+    serial_port = serial_hd(0);
+    if (!serial_port)
+        return;
+
+    /* get serial_backend for the serial port */
+    serial_backend = serial_port->be;
+    if (!serial_backend ||
+        !qemu_chr_fe_backend_connected(serial_backend))
+        return;
+
+    c = (unsigned char)env->gr[26];
+    qemu_chr_fe_write(serial_backend, &c, sizeof(c));
+}
diff --git a/target/hppa/translate.c b/target/hppa/translate.c
index 08d09d50d7..53ec57ee86 100644
--- a/target/hppa/translate.c
+++ b/target/hppa/translate.c
@@ -4411,6 +4411,12 @@ static bool trans_diag(DisasContext *ctx, arg_diag *a)
         gen_helper_diag_btlb(tcg_env);
         return nullify_end(ctx);
     }
+    if (a->i == 0x101) {
+        /* print char in %r26 to first serial console, used by SeaBIOS-hppa */
+        nullify_over(ctx);
+        gen_helper_diag_console_output(tcg_env);
+        return nullify_end(ctx);
+    }
 #endif
     qemu_log_mask(LOG_UNIMP, "DIAG opcode 0x%04x ignored\n", a->i);
     return true;
-- 
2.43.0



  parent reply	other threads:[~2024-02-07 18:23 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-02-07 18:20 [PATCH 00/13] target/hppa: Enhancements and fixes deller
2024-02-07 18:20 ` [PATCH 01/13] disas/hppa: Add disassembly for qemu specific instructions deller
2024-02-08 20:12   ` Richard Henderson
2024-02-07 18:20 ` deller [this message]
2024-02-08 20:15   ` [PATCH 02/13] target/hppa: Add "diag 0x101" for console output support Richard Henderson
2024-02-07 18:20 ` [PATCH 03/13] target/hppa: Fix PSW_W and PSW_E bits in rsm, ssm and mtsm deller
2024-02-08 20:43   ` Richard Henderson
2024-02-09  8:55     ` Helge Deller
2024-02-07 18:20 ` [PATCH 04/13] hw/pci-host/astro: Avoid aborting on access failure deller
2024-02-08 20:45   ` Richard Henderson
2024-02-07 18:20 ` [PATCH 05/13] hw/pci-host/astro: Implement Hard Fail and Soft Fail mode deller
2024-02-08 20:46   ` Richard Henderson
2024-02-07 18:20 ` [PATCH 06/13] lasi: allow access to LAN MAC address registers deller
2024-02-07 18:20 ` [PATCH 07/13] target/hppa: Implement do_transaction_failed handler for I/O errors deller
2024-02-07 18:20 ` [PATCH 08/13] lasi: Add reset I/O ports for LASI audio and FDC deller
2024-02-07 18:20 ` [PATCH 09/13] target/hppa: Allow read-access to PSW with rsm 0, reg instruction deller
2024-02-08 21:12   ` [PATCH 09/13] target/hppa: Allow read-access to PSW with rsm 0,reg instruction Richard Henderson
2024-02-07 18:20 ` [PATCH 10/13] target/hppa: Check privilege only when PSW.P is set deller
2024-02-08 21:14   ` Richard Henderson
2024-02-07 18:20 ` [PATCH 11/13] target/hppa: PDC_BTLB_INFO uses 32-bit ints deller
2024-02-08 21:17   ` Richard Henderson
2024-02-07 18:20 ` [PATCH 12/13] target/hppa: Update SeaBIOS-hppa to version 16 deller
2024-02-08 21:19   ` Richard Henderson
2024-02-07 18:20 ` [PATCH 13/13] hw/hppa/machine: Load 64-bit firmware on 64-bit machines deller
2024-02-08 21:18   ` Richard Henderson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240207182023.36316-3-deller@kernel.org \
    --to=deller@kernel.org \
    --cc=deller@gmx.de \
    --cc=qemu-devel@nongnu.org \
    --cc=richard.henderson@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).