From: Eric Auger <eric.auger@redhat.com>
To: eric.auger.pro@gmail.com, eric.auger@redhat.com,
qemu-devel@nongnu.org, qemu-arm@nongnu.org,
miguel.luis@oracle.com, haibo.xu@linaro.org,
peter.maydell@linaro.org, richard.henderson@linaro.org,
maz@kernel.org, gkulkarni@amperecomputing.com
Subject: [RFC v2 4/5] target/arm: Enable feature ARM_FEATURE_EL2 if EL2 is supported
Date: Fri, 9 Feb 2024 16:59:16 +0100 [thread overview]
Message-ID: <20240209160039.677865-5-eric.auger@redhat.com> (raw)
In-Reply-To: <20240209160039.677865-1-eric.auger@redhat.com>
From: Haibo Xu <haibo.xu@linaro.org>
KVM_CAP_ARM_EL2 must be supported by the cpu to enable ARM_FEATURE_EL2.
In case the host does support NV, expose the feature.
Signed-off-by: Haibo Xu <haibo.xu@linaro.org>
Signed-off-by: Miguel Luis <miguel.luis@oracle.com>
Signed-off-by: Eric Auger <eric.auger@redhat.com>
---
v1 -> v2:
- remove isar_feature_aa64_aa32_el2 modif in target/arm/cpu.h
[Richard] and use el2_supported in kvm_arch_init_vcpu
---
target/arm/kvm.c | 16 ++++++++++++++++
1 file changed, 16 insertions(+)
diff --git a/target/arm/kvm.c b/target/arm/kvm.c
index 0996866afe..a08bc68a3f 100644
--- a/target/arm/kvm.c
+++ b/target/arm/kvm.c
@@ -238,6 +238,7 @@ static bool kvm_arm_get_host_cpu_features(ARMHostCPUFeatures *ahcf)
*/
int fdarray[3];
bool sve_supported;
+ bool el2_supported;
bool pmu_supported = false;
uint64_t features = 0;
int err;
@@ -268,6 +269,14 @@ static bool kvm_arm_get_host_cpu_features(ARMHostCPUFeatures *ahcf)
init.features[0] |= 1 << KVM_ARM_VCPU_SVE;
}
+ /*
+ * Ask for EL2 if supported.
+ */
+ el2_supported = kvm_arm_el2_supported();
+ if (el2_supported) {
+ init.features[0] |= 1 << KVM_ARM_VCPU_HAS_EL2;
+ }
+
/*
* Ask for Pointer Authentication if supported, so that we get
* the unsanitized field values for AA64ISAR1_EL1.
@@ -449,6 +458,10 @@ static bool kvm_arm_get_host_cpu_features(ARMHostCPUFeatures *ahcf)
features |= 1ULL << ARM_FEATURE_PMU;
features |= 1ULL << ARM_FEATURE_GENERIC_TIMER;
+ if (el2_supported) {
+ features |= 1ULL << ARM_FEATURE_EL2;
+ }
+
ahcf->features = features;
return true;
@@ -1912,6 +1925,9 @@ int kvm_arch_init_vcpu(CPUState *cs)
cpu->kvm_init_features[0] |= (1 << KVM_ARM_VCPU_PTRAUTH_ADDRESS |
1 << KVM_ARM_VCPU_PTRAUTH_GENERIC);
}
+ if (kvm_arm_el2_supported()) {
+ cpu->kvm_init_features[0] |= 1 << KVM_ARM_VCPU_HAS_EL2;
+ }
/* Do KVM_ARM_VCPU_INIT ioctl */
ret = kvm_arm_vcpu_init(cpu);
--
2.41.0
next prev parent reply other threads:[~2024-02-09 16:02 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-09 15:59 [RFC v2 0/5] ARM Nested Virt Support Eric Auger
2024-02-09 15:59 ` [RFC v2 1/5] [Placeholder] headers: Partial headers update for NV2 enablement Eric Auger
2024-02-09 15:59 ` [RFC v2 2/5] hw/arm: Allow setting KVM vGIC maintenance IRQ Eric Auger
2024-03-05 16:46 ` Peter Maydell
2024-03-25 17:50 ` Eric Auger
2024-03-26 11:04 ` Eric Auger
2024-02-09 15:59 ` [RFC v2 3/5] target/arm/kvm: Add helper to detect EL2 when using KVM Eric Auger
2024-02-09 18:54 ` Philippe Mathieu-Daudé
2024-02-09 15:59 ` Eric Auger [this message]
2024-03-05 16:49 ` [RFC v2 4/5] target/arm: Enable feature ARM_FEATURE_EL2 if EL2 is supported Peter Maydell
2024-03-25 18:42 ` Eric Auger
2024-02-09 15:59 ` [RFC v2 5/5] hw/arm/virt: Allow virt extensions with KVM Eric Auger
2024-02-09 18:57 ` [RFC v2 0/5] ARM Nested Virt Support Peter Maydell
2024-02-12 17:15 ` Eric Auger
2024-02-12 17:18 ` Marc Zyngier
2024-03-05 16:57 ` Peter Maydell
2024-03-26 10:09 ` Eric Auger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240209160039.677865-5-eric.auger@redhat.com \
--to=eric.auger@redhat.com \
--cc=eric.auger.pro@gmail.com \
--cc=gkulkarni@amperecomputing.com \
--cc=haibo.xu@linaro.org \
--cc=maz@kernel.org \
--cc=miguel.luis@oracle.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).