From: "Michael S. Tsirkin" <mst@redhat.com>
To: "Philippe Mathieu-Daudé" <philmd@linaro.org>
Cc: qemu-devel@nongnu.org,
Richard Henderson <richard.henderson@linaro.org>,
Marcel Apfelbaum <marcel.apfelbaum@gmail.com>,
John Snow <jsnow@redhat.com>,
qemu-arm@nongnu.org, Paolo Bonzini <pbonzini@redhat.com>,
qemu-block@nongnu.org, Eduardo Habkost <eduardo@habkost.net>
Subject: Re: [PATCH 0/9] hw/ide/ahci: Housekeeping
Date: Tue, 13 Feb 2024 06:04:26 -0500 [thread overview]
Message-ID: <20240213060343-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <20240213081201.78951-1-philmd@linaro.org>
On Tue, Feb 13, 2024 at 09:11:51AM +0100, Philippe Mathieu-Daudé wrote:
> - Split 'ahci.h' as sysbus / pci
> - Inline ahci_get_num_ports()
> - Directly use AHCIState::ports instead of SysbusAHCIState::num_ports
PC part:
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
feel free to merge with rest of patches.
> Philippe Mathieu-Daudé (9):
> hw/i386/q35: Use DEVICE() cast macro with PCIDevice object
> hw/ide/ahci: Expose AHCIPCIState structure
> hw/ide/ahci: Rename AHCI PCI function as 'pdev'
> hw/ide/ahci: Inline ahci_get_num_ports()
> hw/ide/ahci: Pass AHCI context to ahci_ide_create_devs()
> hw/ide/ahci: Convert AHCIState::ports to unsigned
> hw/ide/ahci: Do not pass 'ports' argument to ahci_realize()
> hw/ide/ahci: Remove SysbusAHCIState::num_ports field
> hw/ide/ahci: Move SysBus definitions to 'ahci-sysbus.h'
>
> hw/ide/ahci_internal.h | 10 +--------
> include/hw/arm/allwinner-a10.h | 2 +-
> include/hw/arm/allwinner-r40.h | 2 +-
> include/hw/arm/xlnx-zynqmp.h | 2 +-
> include/hw/ide/ahci-pci.h | 22 ++++++++++++++++++++
> include/hw/ide/ahci-sysbus.h | 35 +++++++++++++++++++++++++++++++
> include/hw/ide/ahci.h | 38 +++-------------------------------
> hw/arm/highbank.c | 2 +-
> hw/arm/sbsa-ref.c | 1 +
> hw/i386/pc_q35.c | 19 ++++++++++-------
> hw/ide/ahci-allwinner.c | 3 +--
> hw/ide/ahci.c | 29 +++++++++-----------------
> hw/ide/ich.c | 4 +++-
> hw/mips/boston.c | 14 +++++++------
> 14 files changed, 99 insertions(+), 84 deletions(-)
> create mode 100644 include/hw/ide/ahci-pci.h
> create mode 100644 include/hw/ide/ahci-sysbus.h
>
> --
> 2.41.0
next prev parent reply other threads:[~2024-02-13 11:05 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-13 8:11 [PATCH 0/9] hw/ide/ahci: Housekeeping Philippe Mathieu-Daudé
2024-02-13 8:11 ` [PATCH 1/9] hw/i386/q35: Use DEVICE() cast macro with PCIDevice object Philippe Mathieu-Daudé
2024-02-13 16:31 ` Richard Henderson
2024-02-13 8:11 ` [PATCH 2/9] hw/ide/ahci: Expose AHCIPCIState structure Philippe Mathieu-Daudé
2024-02-13 16:31 ` Richard Henderson
2024-02-13 8:11 ` [PATCH 3/9] hw/ide/ahci: Rename AHCI PCI function as 'pdev' Philippe Mathieu-Daudé
2024-02-13 16:32 ` Richard Henderson
2024-02-15 15:13 ` Philippe Mathieu-Daudé
2024-02-13 8:11 ` [PATCH 4/9] hw/ide/ahci: Inline ahci_get_num_ports() Philippe Mathieu-Daudé
2024-02-13 16:43 ` Richard Henderson
2024-02-15 15:25 ` Philippe Mathieu-Daudé
2024-02-13 8:11 ` [PATCH 5/9] hw/ide/ahci: Pass AHCI context to ahci_ide_create_devs() Philippe Mathieu-Daudé
2024-02-13 16:44 ` Richard Henderson
2024-02-13 8:11 ` [PATCH 6/9] hw/ide/ahci: Convert AHCIState::ports to unsigned Philippe Mathieu-Daudé
2024-02-13 16:45 ` Richard Henderson
2024-02-13 8:11 ` [PATCH 7/9] hw/ide/ahci: Do not pass 'ports' argument to ahci_realize() Philippe Mathieu-Daudé
2024-02-13 16:48 ` Richard Henderson
2024-02-13 8:11 ` [PATCH 8/9] hw/ide/ahci: Remove SysbusAHCIState::num_ports field Philippe Mathieu-Daudé
2024-02-13 16:50 ` Richard Henderson
2024-02-13 8:12 ` [PATCH 9/9] hw/ide/ahci: Move SysBus definitions to 'ahci-sysbus.h' Philippe Mathieu-Daudé
2024-02-13 11:02 ` Leif Lindholm
2024-02-13 11:04 ` Michael S. Tsirkin [this message]
2024-02-15 17:52 ` [PATCH 0/9] hw/ide/ahci: Housekeeping Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240213060343-mutt-send-email-mst@kernel.org \
--to=mst@redhat.com \
--cc=eduardo@habkost.net \
--cc=jsnow@redhat.com \
--cc=marcel.apfelbaum@gmail.com \
--cc=pbonzini@redhat.com \
--cc=philmd@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).