From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: qemu-devel@nongnu.org
Cc: "Zhao Liu" <zhao1.liu@linux.intel.com>,
"Bernhard Beschow" <shentey@gmail.com>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Mark Cave-Ayland" <mark.cave-ayland@ilande.co.uk>,
"Richard Henderson" <richard.henderson@linaro.org>,
"BALATON Zoltan" <balaton@eik.bme.hu>,
"Michael S. Tsirkin" <mst@redhat.com>,
qemu-block@nongnu.org, qemu-ppc@nongnu.org,
"Philippe Mathieu-Daudé" <philmd@linaro.org>,
"Marcel Apfelbaum" <marcel.apfelbaum@gmail.com>,
"Eduardo Habkost" <eduardo@habkost.net>
Subject: [PATCH v4 04/12] hw/i386/q35: Realize LPC PCI function before accessing it
Date: Tue, 13 Feb 2024 14:03:33 +0100 [thread overview]
Message-ID: <20240213130341.1793-5-philmd@linaro.org> (raw)
In-Reply-To: <20240213130341.1793-1-philmd@linaro.org>
We should not wire IRQs on unrealized device.
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
---
hw/i386/pc_q35.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/hw/i386/pc_q35.c b/hw/i386/pc_q35.c
index 7ca3f465e0..b7c69d55d6 100644
--- a/hw/i386/pc_q35.c
+++ b/hw/i386/pc_q35.c
@@ -248,13 +248,13 @@ static void pc_q35_init(MachineState *machine)
/* create ISA bus */
lpc = pci_new_multifunction(PCI_DEVFN(ICH9_LPC_DEV, ICH9_LPC_FUNC),
TYPE_ICH9_LPC_DEVICE);
- qdev_prop_set_bit(DEVICE(lpc), "smm-enabled",
- x86_machine_is_smm_enabled(x86ms));
lpc_dev = DEVICE(lpc);
+ qdev_prop_set_bit(lpc_dev, "smm-enabled",
+ x86_machine_is_smm_enabled(x86ms));
+ pci_realize_and_unref(lpc, host_bus, &error_fatal);
for (i = 0; i < IOAPIC_NUM_PINS; i++) {
qdev_connect_gpio_out_named(lpc_dev, ICH9_GPIO_GSI, i, x86ms->gsi[i]);
}
- pci_realize_and_unref(lpc, host_bus, &error_fatal);
rtc_state = ISA_DEVICE(object_resolve_path_component(OBJECT(lpc), "rtc"));
--
2.41.0
next prev parent reply other threads:[~2024-02-13 13:05 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-13 13:03 [PATCH v4 00/12] hw: Strengthen SysBus & QBus API Philippe Mathieu-Daudé
2024-02-13 13:03 ` [PATCH v4 01/12] hw/ide/ich9: Use AHCIPCIState typedef Philippe Mathieu-Daudé
2024-02-13 13:03 ` [PATCH v4 02/12] hw/rx/rx62n: Reduce inclusion of 'qemu/units.h' Philippe Mathieu-Daudé
2024-02-13 13:03 ` [PATCH v4 03/12] hw/rx/rx62n: Only call qdev_get_gpio_in() when necessary Philippe Mathieu-Daudé
2024-02-13 13:03 ` Philippe Mathieu-Daudé [this message]
2024-02-13 13:18 ` [PATCH v4 04/12] hw/i386/q35: Realize LPC PCI function before accessing it Damien Hedde
2024-02-13 17:41 ` BALATON Zoltan
2024-02-13 13:03 ` [PATCH v4 05/12] hw/ppc/prep: Realize ISA bridge " Philippe Mathieu-Daudé
2024-02-13 13:03 ` [PATCH v4 06/12] hw/misc/macio: Realize IDE controller " Philippe Mathieu-Daudé
2024-02-13 17:43 ` BALATON Zoltan
2024-02-13 13:03 ` [PATCH v4 07/12] hw/sh4/r2d: " Philippe Mathieu-Daudé
2024-10-22 14:53 ` Michael Tokarev
2024-10-22 18:52 ` Bernhard Beschow
2024-02-13 13:03 ` [PATCH v4 08/12] hw/sparc/sun4m: Realize DMA " Philippe Mathieu-Daudé
2024-02-13 13:03 ` [PATCH v4 09/12] hw/sparc/leon3: Realize GRLIB IRQ " Philippe Mathieu-Daudé
2024-02-13 13:03 ` [PATCH v4 10/12] hw/sparc/leon3: Pass DeviceState opaque argument to leon3_set_pil_in() Philippe Mathieu-Daudé
2024-02-13 20:37 ` Mark Cave-Ayland
2024-02-13 13:03 ` [PATCH v4 11/12] hw/sparc/leon3: Initialize GPIO before realizing CPU devices Philippe Mathieu-Daudé
2024-02-13 20:40 ` Mark Cave-Ayland
2024-02-13 13:03 ` [PATCH v4 12/12] hw/sparc64/cpu: " Philippe Mathieu-Daudé
2024-02-13 13:21 ` Damien Hedde
2024-02-13 17:07 ` [PATCH v4 00/12] hw: Strengthen SysBus & QBus API Richard Henderson
2024-02-15 15:05 ` Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240213130341.1793-5-philmd@linaro.org \
--to=philmd@linaro.org \
--cc=balaton@eik.bme.hu \
--cc=eduardo@habkost.net \
--cc=marcel.apfelbaum@gmail.com \
--cc=mark.cave-ayland@ilande.co.uk \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=shentey@gmail.com \
--cc=zhao1.liu@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).