From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: qemu-devel@nongnu.org
Cc: "Laurent Vivier" <laurent@vivier.eu>,
"Artyom Tarasenko" <atar4qemu@gmail.com>,
"Manos Pitsidianakis" <manos.pitsidianakis@linaro.org>,
"Mark Cave-Ayland" <mark.cave-ayland@ilande.co.uk>,
"Michael Tokarev" <mjt@tls.msk.ru>,
"Pierrick Bouvier" <pierrick.bouvier@linaro.org>,
"Frederic Konrad" <konrad.frederic@yahoo.fr>,
"Clément Chigot" <chigot@adacore.com>,
qemu-trivial@nongnu.org, "Fabien Chouteau" <chouteau@adacore.com>,
"Philippe Mathieu-Daudé" <philmd@linaro.org>
Subject: [PATCH 1/2] hw/sparc/leon3: Remove unused 'env' argument of write_bootloader()
Date: Thu, 15 Feb 2024 14:28:23 +0100 [thread overview]
Message-ID: <20240215132824.67363-2-philmd@linaro.org> (raw)
In-Reply-To: <20240215132824.67363-1-philmd@linaro.org>
'CPUSPARCState *env' argument is unused, remove it.
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
---
hw/sparc/leon3.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/hw/sparc/leon3.c b/hw/sparc/leon3.c
index 2dfb742566..d096fb04cb 100644
--- a/hw/sparc/leon3.c
+++ b/hw/sparc/leon3.c
@@ -94,8 +94,7 @@ static uint32_t *gen_store_u32(uint32_t *code, hwaddr addr, uint32_t val)
* state (eg: initialized by the bootloader). This little code reproduces
* this behavior.
*/
-static void write_bootloader(CPUSPARCState *env, uint8_t *base,
- hwaddr kernel_addr)
+static void write_bootloader(uint8_t *base, hwaddr kernel_addr)
{
uint32_t *p = (uint32_t *) base;
@@ -342,7 +341,7 @@ static void leon3_generic_hw_init(MachineState *machine)
uint8_t *bootloader_entry;
bootloader_entry = memory_region_get_ram_ptr(prom);
- write_bootloader(env, bootloader_entry, entry);
+ write_bootloader(bootloader_entry, entry);
env->pc = LEON3_PROM_OFFSET;
env->npc = LEON3_PROM_OFFSET + 4;
reset_info->entry = LEON3_PROM_OFFSET;
--
2.41.0
next prev parent reply other threads:[~2024-02-15 13:29 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-15 13:28 [PATCH 0/2] hw/sparc/leon3: Trivial cleanups around write_bootloader() Philippe Mathieu-Daudé
2024-02-15 13:28 ` Philippe Mathieu-Daudé [this message]
2024-02-15 14:11 ` [PATCH 1/2] hw/sparc/leon3: Remove unused 'env' argument of write_bootloader() Peter Maydell
2024-02-15 13:28 ` [PATCH 2/2] hw/sparc/leon3: Have write_bootloader() take a void pointer argument Philippe Mathieu-Daudé
2024-02-15 14:13 ` Peter Maydell
2024-02-15 14:24 ` Philippe Mathieu-Daudé
2024-02-15 17:49 ` [PATCH 0/2] hw/sparc/leon3: Trivial cleanups around write_bootloader() Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240215132824.67363-2-philmd@linaro.org \
--to=philmd@linaro.org \
--cc=atar4qemu@gmail.com \
--cc=chigot@adacore.com \
--cc=chouteau@adacore.com \
--cc=konrad.frederic@yahoo.fr \
--cc=laurent@vivier.eu \
--cc=manos.pitsidianakis@linaro.org \
--cc=mark.cave-ayland@ilande.co.uk \
--cc=mjt@tls.msk.ru \
--cc=pierrick.bouvier@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).