qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: qemu-devel@nongnu.org
Cc: qemu-ppc@nongnu.org, qemu-arm@nongnu.org, qemu-block@nongnu.org,
	"Philippe Mathieu-Daudé" <philmd@linaro.org>,
	"Richard Henderson" <richard.henderson@linaro.org>,
	"Jiaxun Yang" <jiaxun.yang@flygoat.com>
Subject: [PULL 09/56] hw/misc/mips_itu: Remove MIPSITUState::saar field
Date: Thu, 15 Feb 2024 18:57:03 +0100	[thread overview]
Message-ID: <20240215175752.82828-10-philmd@linaro.org> (raw)
In-Reply-To: <20240215175752.82828-1-philmd@linaro.org>

This field is not set. Remove it along with the dead
code it was guarding.

Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Message-Id: <20240209090513.9401-7-philmd@linaro.org>
---
 include/hw/misc/mips_itu.h |  3 ---
 hw/misc/mips_itu.c         | 22 +++-------------------
 2 files changed, 3 insertions(+), 22 deletions(-)

diff --git a/include/hw/misc/mips_itu.h b/include/hw/misc/mips_itu.h
index de7400c1fe..27c9a1090d 100644
--- a/include/hw/misc/mips_itu.h
+++ b/include/hw/misc/mips_itu.h
@@ -70,9 +70,6 @@ struct MIPSITUState {
 
     /* ITU Control Register */
     uint64_t icr0;
-
-    /* SAAR */
-    uint64_t *saar;
 };
 
 /* Get ITC Configuration Tag memory region. */
diff --git a/hw/misc/mips_itu.c b/hw/misc/mips_itu.c
index 9705efeafe..f8acfb3ee2 100644
--- a/hw/misc/mips_itu.c
+++ b/hw/misc/mips_itu.c
@@ -94,12 +94,6 @@ static void itc_reconfigure(MIPSITUState *tag)
     uint64_t size = (1 * KiB) + (am[1] & ITC_AM1_ADDR_MASK_MASK);
     bool is_enabled = (am[0] & ITC_AM0_EN_MASK) != 0;
 
-    if (tag->saar) {
-        address = (tag->saar[0] & 0xFFFFFFFFE000ULL) << 4;
-        size = 1ULL << ((tag->saar[0] >> 1) & 0x1f);
-        is_enabled = tag->saar[0] & 1;
-    }
-
     memory_region_transaction_begin();
     if (!(size & (size - 1))) {
         memory_region_set_size(mr, size);
@@ -158,12 +152,7 @@ static inline ITCView get_itc_view(hwaddr addr)
 static inline int get_cell_stride_shift(const MIPSITUState *s)
 {
     /* Minimum interval (for EntryGain = 0) is 128 B */
-    if (s->saar) {
-        return 7 + ((s->icr0 >> ITC_ICR0_BLK_GRAIN) &
-                    ITC_ICR0_BLK_GRAIN_MASK);
-    } else {
-        return 7 + (s->ITCAddressMap[1] & ITC_AM1_ENTRY_GRAIN_MASK);
-    }
+    return 7 + (s->ITCAddressMap[1] & ITC_AM1_ENTRY_GRAIN_MASK);
 }
 
 static inline ITCStorageCell *get_cell(MIPSITUState *s,
@@ -535,15 +524,10 @@ static void mips_itu_reset(DeviceState *dev)
 {
     MIPSITUState *s = MIPS_ITU(dev);
 
-    if (s->saar) {
-        s->saar[0] = 0x11 << 1;
-        s->icr0 = get_num_cells(s) << ITC_ICR0_CELL_NUM;
-    } else {
-        s->ITCAddressMap[0] = 0;
-        s->ITCAddressMap[1] =
+    s->ITCAddressMap[0] = 0;
+    s->ITCAddressMap[1] =
             ((ITC_STORAGE_ADDRSPACE_SZ - 1) & ITC_AM1_ADDR_MASK_MASK) |
             (get_num_cells(s) << ITC_AM1_NUMENTRIES_OFS);
-    }
     itc_reconfigure(s);
 
     itc_reset_cells(s);
-- 
2.41.0



  parent reply	other threads:[~2024-02-15 18:00 UTC|newest]

Thread overview: 60+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-02-15 17:56 [PULL 00/56] Misc HW patches for 2024-02-15 Philippe Mathieu-Daudé
2024-02-15 17:56 ` [PULL 01/56] hw/block/tc58128: Don't emit deprecation warning under qtest Philippe Mathieu-Daudé
2024-02-15 17:56 ` [PULL 02/56] hw/mips: remove unnecessary "select PTIMER" Philippe Mathieu-Daudé
2024-02-15 17:56 ` [PULL 03/56] target/mips: Use qemu_irq typedef for CPUMIPSState::irq member Philippe Mathieu-Daudé
2024-02-15 17:56 ` [PULL 04/56] target/mips: Remove helpers accessing SAAR registers Philippe Mathieu-Daudé
2024-02-15 17:56 ` [PULL 05/56] hw/misc/mips: Reduce itc_reconfigure() scope Philippe Mathieu-Daudé
2024-02-15 17:57 ` [PULL 06/56] target/mips: Remove MIPSITUState::itu field Philippe Mathieu-Daudé
2024-02-15 17:57 ` [PULL 07/56] target/mips: Remove CPUMIPSState::saarp field Philippe Mathieu-Daudé
2024-02-15 17:57 ` [PULL 08/56] hw/misc/mips_itu: Remove MIPSITUState::cpu0 field Philippe Mathieu-Daudé
2024-02-15 17:57 ` Philippe Mathieu-Daudé [this message]
2024-02-15 17:57 ` [PULL 10/56] target/mips: Remove unused mips_def_t::SAARP field Philippe Mathieu-Daudé
2024-02-15 17:57 ` [PULL 11/56] target/mips: Remove CPUMIPSState::CP0_SAAR[2] field Philippe Mathieu-Daudé
2024-02-15 17:57 ` [PULL 12/56] target/mips: Remove helpers accessing SAARI register Philippe Mathieu-Daudé
2024-02-15 17:57 ` [PULL 13/56] target/mips: Remove CPUMIPSState::CP0_SAARI field Philippe Mathieu-Daudé
2024-02-15 17:57 ` [PULL 14/56] target/mips: Remove the unused DisasContext::saar field Philippe Mathieu-Daudé
2024-02-15 17:57 ` [PULL 15/56] hw/isa: clean up Kconfig selections for ISA_SUPERIO Philippe Mathieu-Daudé
2024-02-15 17:57 ` [PULL 16/56] hw/mips/Kconfig: Remove ISA dependencies from MIPSsim board Philippe Mathieu-Daudé
2024-02-15 17:57 ` [PULL 17/56] hw/isa: fix ISA_SUPERIO dependencies Philippe Mathieu-Daudé
2024-02-15 17:57 ` [PULL 18/56] hw/isa: specify instance_size in isa_superio_type_info Philippe Mathieu-Daudé
2024-02-15 17:57 ` [PULL 19/56] hw/isa: extract FDC37M81X to a separate file Philippe Mathieu-Daudé
2024-02-15 17:57 ` [PULL 20/56] hw/rx/rx62n: Reduce inclusion of 'qemu/units.h' Philippe Mathieu-Daudé
2024-02-15 17:57 ` [PULL 21/56] hw/rx/rx62n: Only call qdev_get_gpio_in() when necessary Philippe Mathieu-Daudé
2024-02-15 17:57 ` [PULL 22/56] hw/i386/q35: Realize LPC PCI function before accessing it Philippe Mathieu-Daudé
2024-02-15 17:57 ` [PULL 23/56] hw/ppc/prep: Realize ISA bridge " Philippe Mathieu-Daudé
2024-02-15 17:57 ` [PULL 24/56] hw/misc/macio: Realize IDE controller " Philippe Mathieu-Daudé
2024-02-15 17:57 ` [PULL 25/56] hw/sh4/r2d: " Philippe Mathieu-Daudé
2024-02-15 17:57 ` [PULL 26/56] hw/dma: Pass parent object to i8257_dma_init() Philippe Mathieu-Daudé
2024-02-15 17:57 ` [PULL 27/56] hw/sparc/sun4m: Realize DMA controller before accessing it Philippe Mathieu-Daudé
2024-02-15 17:57 ` [PULL 28/56] hw/sparc64/cpu: Initialize GPIO before realizing CPU devices Philippe Mathieu-Daudé
2024-02-15 17:57 ` [PULL 29/56] target/sparc: Provide hint about CPUSPARCState::irq_manager member Philippe Mathieu-Daudé
2024-02-15 17:57 ` [PULL 30/56] hw/sparc/leon3: Remove duplicate code Philippe Mathieu-Daudé
2024-02-15 17:57 ` [PULL 31/56] hw/sparc/leon3: Remove unused 'env' argument of write_bootloader() Philippe Mathieu-Daudé
2024-02-15 17:57 ` [PULL 32/56] hw/sparc/leon3: Have write_bootloader() take a void pointer argument Philippe Mathieu-Daudé
2024-02-15 17:57 ` [PULL 33/56] hw/sparc/grlib: split out the headers for each peripherals Philippe Mathieu-Daudé
2024-02-15 17:57 ` [PULL 34/56] hw/intc/grlib_irqmp: add ncpus property Philippe Mathieu-Daudé
2024-03-08 13:27   ` Peter Maydell
2024-03-08 15:01     ` Clément Chigot
2024-02-15 17:57 ` [PULL 35/56] hw/intc/grlib_irqmp: implements the multiprocessor status register Philippe Mathieu-Daudé
2024-02-15 17:57 ` [PULL 36/56] hw/intc/grlib_irqmp: implements multicore irq Philippe Mathieu-Daudé
2024-02-15 17:57 ` [PULL 37/56] target/sparc: implement asr17 feature for smp Philippe Mathieu-Daudé
2024-02-15 17:57 ` [PULL 38/56] hw/sparc/leon3: remove SP initialization Philippe Mathieu-Daudé
2024-02-15 17:57 ` [PULL 39/56] hw/sparc/leon3: implement multiprocessor Philippe Mathieu-Daudé
2024-02-15 17:57 ` [PULL 40/56] hw/sparc/leon3: check cpu_id in the tiny bootloader Philippe Mathieu-Daudé
2024-02-15 17:57 ` [PULL 41/56] hw/sparc/leon3: Pass DeviceState opaque argument to leon3_set_pil_in() Philippe Mathieu-Daudé
2024-02-15 17:57 ` [PULL 42/56] hw/sparc/leon3: Pass DeviceState opaque argument to leon3_start_cpu() Philippe Mathieu-Daudé
2024-02-15 17:57 ` [PULL 43/56] hw/sparc/leon3: Initialize GPIO before realizing CPU devices Philippe Mathieu-Daudé
2024-02-15 17:57 ` [PULL 44/56] MAINTAINERS: replace Fabien by myself as Leon3 maintainer Philippe Mathieu-Daudé
2024-02-15 17:57 ` [PULL 45/56] MAINTAINERS: Add myself as reviewer for TCG Plugins Philippe Mathieu-Daudé
2024-02-15 17:57 ` [PULL 46/56] hw/i386/q35: Simplify pc_q35_init() since PCI is always enabled Philippe Mathieu-Daudé
2024-02-15 17:57 ` [PULL 47/56] hw/i386/q35: Use DEVICE() cast macro with PCIDevice object Philippe Mathieu-Daudé
2024-02-15 17:57 ` [PULL 48/56] hw/ide/ahci: Expose AHCIPCIState structure Philippe Mathieu-Daudé
2024-02-15 17:57 ` [PULL 49/56] hw/ide/ahci: Rename AHCI PCI function as 'pdev' Philippe Mathieu-Daudé
2024-02-15 17:57 ` [PULL 50/56] hw/ide/ahci: Inline ahci_get_num_ports() Philippe Mathieu-Daudé
2024-02-15 17:57 ` [PULL 51/56] hw/ide/ahci: Pass AHCI context to ahci_ide_create_devs() Philippe Mathieu-Daudé
2024-02-15 17:57 ` [PULL 52/56] hw/ide/ahci: Convert AHCIState::ports to unsigned Philippe Mathieu-Daudé
2024-02-15 17:57 ` [PULL 53/56] hw/ide/ahci: Do not pass 'ports' argument to ahci_realize() Philippe Mathieu-Daudé
2024-02-15 17:57 ` [PULL 54/56] hw/ide/ahci: Remove SysbusAHCIState::num_ports field Philippe Mathieu-Daudé
2024-02-15 17:57 ` [PULL 55/56] hw/ide/ahci: Move SysBus definitions to 'ahci-sysbus.h' Philippe Mathieu-Daudé
2024-02-15 17:57 ` [PULL 56/56] hw/ide/ich9: Use AHCIPCIState typedef Philippe Mathieu-Daudé
2024-02-16 13:31 ` [PULL 00/56] Misc HW patches for 2024-02-15 Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240215175752.82828-10-philmd@linaro.org \
    --to=philmd@linaro.org \
    --cc=jiaxun.yang@flygoat.com \
    --cc=qemu-arm@nongnu.org \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-ppc@nongnu.org \
    --cc=richard.henderson@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).