From: Abhiram Tilak <atp.exp@gmail.com>
To: qemu-devel@nongnu.org
Cc: peter.maydell@linaro.org, clg@kaod.org,
david@gibson.dropbear.id.au, harshpb@linux.ibm.com,
Abhiram Tilak <atp.exp@gmail.com>
Subject: [PATCH 3/3] misc: ppc/spapr: replace qemu_system_reset_request() calls with watchdog_perform_action()
Date: Fri, 16 Feb 2024 19:21:39 +0530 [thread overview]
Message-ID: <20240216135137.8668-6-atp.exp@gmail.com> (raw)
In-Reply-To: <20240216135137.8668-3-atp.exp@gmail.com>
A few watchdog devices use qemu_system_reset_request(). This is not ideal since
behaviour of watchdog-expiry can't be changed by QMP using `watchdog_action`.
As stated in BiteSizedTasks wiki page, instead of using qemu_system_reset_request()
to reset when a watchdog timer expires, let watchdog_perform_action() decide
what to do.
I am unsure about the changes in `spapr_watchdog.c` in patch 3, it would be great
if any of the maintainers review it.
Resolves: https://gitlab.com/qemu-project/qemu/-/issues/2124
Signed-off-by: Abhiram Tilak <atp.exp@gmail.com>
---
hw/watchdog/spapr_watchdog.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/hw/watchdog/spapr_watchdog.c b/hw/watchdog/spapr_watchdog.c
index 2bb1d3c532..9751b19506 100644
--- a/hw/watchdog/spapr_watchdog.c
+++ b/hw/watchdog/spapr_watchdog.c
@@ -18,6 +18,7 @@
#include "target/ppc/cpu.h"
#include "migration/vmstate.h"
#include "trace.h"
+#include "sysemu/watchdog.h"
#include "hw/ppc/spapr.h"
@@ -114,7 +115,7 @@ static void watchdog_expired(void *pw)
qemu_system_vmstop_request(RUN_STATE_SHUTDOWN);
break;
case PSERIES_WDTF_ACTION_HARD_RESTART:
- qemu_system_reset_request(SHUTDOWN_CAUSE_GUEST_RESET);
+ watchdog_perform_action();
break;
case PSERIES_WDTF_ACTION_DUMP_RESTART:
CPU_FOREACH(cs) {
--
2.42.1
next prev parent reply other threads:[~2024-02-16 13:57 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-16 13:51 [PATCH 0/3] Misc: Make watchdog devices using qemu_system_reset_request() use watchdog_perfom_action() Abhiram Tilak
2024-02-16 13:51 ` [PATCH 1/3] misc: m48t59: replace qemu_system_reset_request() call with watchdog_perform_action() Abhiram Tilak
2024-02-16 14:49 ` Peter Maydell
2024-02-16 18:27 ` atp exp
2024-02-16 13:51 ` [PATCH 2/3] misc: pxa2xx_timer: " Abhiram Tilak
2024-02-16 14:50 ` Peter Maydell
2024-02-16 13:51 ` Abhiram Tilak [this message]
2024-02-16 14:54 ` [PATCH 3/3] misc: ppc/spapr: replace qemu_system_reset_request() calls " Peter Maydell
2024-02-16 18:03 ` atp exp
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240216135137.8668-6-atp.exp@gmail.com \
--to=atp.exp@gmail.com \
--cc=clg@kaod.org \
--cc=david@gibson.dropbear.id.au \
--cc=harshpb@linux.ibm.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).