* [PATCH v2] tests/cdrom-test: Add cdrom test for LoongArch virt machine
@ 2024-02-17 10:02 Bibo Mao
2024-02-19 6:44 ` Thomas Huth
0 siblings, 1 reply; 2+ messages in thread
From: Bibo Mao @ 2024-02-17 10:02 UTC (permalink / raw)
To: Thomas Huth, Philippe Mathieu-Daudé, Laurent Vivier
Cc: Paolo Bonzini, qemu-block, qemu-devel
The cdrom test skips to execute on LoongArch system with command
"make check", this patch enables cdrom test for LoongArch virt
machine platform.
With this patch, cdrom test passes to run on LoongArch virt
machine type.
Signed-off-by: Bibo Mao <maobibo@loongson.cn>
---
Add virtio-blk-pci checking since LoongArch virt machine type does
not support ISA bus and IDE harddisk.
---
tests/qtest/cdrom-test.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/tests/qtest/cdrom-test.c b/tests/qtest/cdrom-test.c
index 0945383789..5d89e62515 100644
--- a/tests/qtest/cdrom-test.c
+++ b/tests/qtest/cdrom-test.c
@@ -271,6 +271,11 @@ int main(int argc, char **argv)
const char *virtmachine[] = { "virt", NULL };
add_cdrom_param_tests(virtmachine);
}
+ } else if (g_str_equal(arch, "loongarch64")) {
+ if (qtest_has_device("virtio-blk-pci")) {
+ const char *virtmachine[] = { "virt", NULL };
+ add_cdrom_param_tests(virtmachine);
+ }
} else {
const char *nonemachine[] = { "none", NULL };
add_cdrom_param_tests(nonemachine);
base-commit: 5767815218efd3cbfd409505ed824d5f356044ae
--
2.39.3
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v2] tests/cdrom-test: Add cdrom test for LoongArch virt machine
2024-02-17 10:02 [PATCH v2] tests/cdrom-test: Add cdrom test for LoongArch virt machine Bibo Mao
@ 2024-02-19 6:44 ` Thomas Huth
0 siblings, 0 replies; 2+ messages in thread
From: Thomas Huth @ 2024-02-19 6:44 UTC (permalink / raw)
To: Bibo Mao, Philippe Mathieu-Daudé, Laurent Vivier
Cc: Paolo Bonzini, qemu-block, qemu-devel
On 17/02/2024 11.02, Bibo Mao wrote:
> The cdrom test skips to execute on LoongArch system with command
> "make check", this patch enables cdrom test for LoongArch virt
> machine platform.
>
> With this patch, cdrom test passes to run on LoongArch virt
> machine type.
>
> Signed-off-by: Bibo Mao <maobibo@loongson.cn>
> ---
> Add virtio-blk-pci checking since LoongArch virt machine type does
> not support ISA bus and IDE harddisk.
>
> ---
> tests/qtest/cdrom-test.c | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/tests/qtest/cdrom-test.c b/tests/qtest/cdrom-test.c
> index 0945383789..5d89e62515 100644
> --- a/tests/qtest/cdrom-test.c
> +++ b/tests/qtest/cdrom-test.c
> @@ -271,6 +271,11 @@ int main(int argc, char **argv)
> const char *virtmachine[] = { "virt", NULL };
> add_cdrom_param_tests(virtmachine);
> }
> + } else if (g_str_equal(arch, "loongarch64")) {
> + if (qtest_has_device("virtio-blk-pci")) {
> + const char *virtmachine[] = { "virt", NULL };
> + add_cdrom_param_tests(virtmachine);
> + }
> } else {
> const char *nonemachine[] = { "none", NULL };
> add_cdrom_param_tests(nonemachine);
>
> base-commit: 5767815218efd3cbfd409505ed824d5f356044ae
Reviewed-by: Thomas Huth <thuth@redhat.com>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-02-19 6:45 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-02-17 10:02 [PATCH v2] tests/cdrom-test: Add cdrom test for LoongArch virt machine Bibo Mao
2024-02-19 6:44 ` Thomas Huth
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).