qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Akihiko Odaki <akihiko.odaki@daynix.com>
To: "Philippe Mathieu-Daudé" <philmd@linaro.org>,
	"Michael S. Tsirkin" <mst@redhat.com>,
	"Marcel Apfelbaum" <marcel.apfelbaum@gmail.com>,
	"Alex Williamson" <alex.williamson@redhat.com>,
	"Cédric Le Goater" <clg@redhat.com>,
	"Paolo Bonzini" <pbonzini@redhat.com>,
	"Daniel P. Berrangé" <berrange@redhat.com>,
	"Eduardo Habkost" <eduardo@habkost.net>,
	"Sriram Yagnaraman" <sriram.yagnaraman@est.tech>,
	"Jason Wang" <jasowang@redhat.com>,
	"Keith Busch" <kbusch@kernel.org>,
	"Klaus Jensen" <its@irrelevant.dk>
Cc: qemu-devel@nongnu.org, qemu-block@nongnu.org,
	 Akihiko Odaki <akihiko.odaki@daynix.com>
Subject: [PATCH v5 09/11] hw/pci: Always call pcie_sriov_pf_reset()
Date: Sun, 18 Feb 2024 13:56:14 +0900	[thread overview]
Message-ID: <20240218-reuse-v5-9-e4fc1c19b5a9@daynix.com> (raw)
In-Reply-To: <20240218-reuse-v5-0-e4fc1c19b5a9@daynix.com>

Call pcie_sriov_pf_reset() from pci_do_device_reset() just as we do
for msi_reset() and msix_reset() to prevent duplicating code for each
SR-IOV PF.

Signed-off-by: Akihiko Odaki <akihiko.odaki@daynix.com>
---
 hw/net/igb.c   | 2 --
 hw/nvme/ctrl.c | 4 ----
 hw/pci/pci.c   | 1 +
 3 files changed, 1 insertion(+), 6 deletions(-)

diff --git a/hw/net/igb.c b/hw/net/igb.c
index 9345506f81ec..9b37523d6df8 100644
--- a/hw/net/igb.c
+++ b/hw/net/igb.c
@@ -488,12 +488,10 @@ static void igb_pci_uninit(PCIDevice *pci_dev)
 
 static void igb_qdev_reset_hold(Object *obj)
 {
-    PCIDevice *d = PCI_DEVICE(obj);
     IGBState *s = IGB(obj);
 
     trace_e1000e_cb_qdev_reset_hold();
 
-    pcie_sriov_pf_reset(d);
     igb_core_reset(&s->core);
 }
 
diff --git a/hw/nvme/ctrl.c b/hw/nvme/ctrl.c
index 7c0d3f108724..c1af4b87b34a 100644
--- a/hw/nvme/ctrl.c
+++ b/hw/nvme/ctrl.c
@@ -7114,10 +7114,6 @@ static void nvme_ctrl_reset(NvmeCtrl *n, NvmeResetType rst)
                 sctrl = &n->sec_ctrl_list.sec[i];
                 nvme_virt_set_state(n, le16_to_cpu(sctrl->scid), false);
             }
-
-            if (rst != NVME_RESET_CONTROLLER) {
-                pcie_sriov_pf_reset(pci_dev);
-            }
         }
 
         if (rst != NVME_RESET_CONTROLLER) {
diff --git a/hw/pci/pci.c b/hw/pci/pci.c
index 47f38375bb09..3d37ddbb101e 100644
--- a/hw/pci/pci.c
+++ b/hw/pci/pci.c
@@ -409,6 +409,7 @@ static void pci_do_device_reset(PCIDevice *dev)
 
     msi_reset(dev);
     msix_reset(dev);
+    pcie_sriov_pf_reset(dev);
 }
 
 /*

-- 
2.43.1



  parent reply	other threads:[~2024-02-18  4:58 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-02-18  4:56 [PATCH v5 00/11] hw/pci: SR-IOV related fixes and improvements Akihiko Odaki
2024-02-18  4:56 ` [PATCH v5 01/11] hw/nvme: Use pcie_sriov_num_vfs() Akihiko Odaki
2024-02-19 12:00   ` Klaus Jensen
2024-02-18  4:56 ` [PATCH v5 02/11] pcie_sriov: Validate NumVFs Akihiko Odaki
2024-02-18 17:36   ` Michael S. Tsirkin
2024-02-19  8:13     ` Akihiko Odaki
2024-02-18  4:56 ` [PATCH v5 03/11] hw/pci: Use -1 as a default value for rombar Akihiko Odaki
2024-02-18  4:56 ` [PATCH v5 04/11] hw/pci: Determine if rombar is explicitly enabled Akihiko Odaki
2024-02-18  4:56 ` [PATCH v5 05/11] vfio: Avoid inspecting option QDict for rombar Akihiko Odaki
2024-02-18 17:26   ` Michael S. Tsirkin
2024-02-18  4:56 ` [PATCH v5 06/11] hw/qdev: Remove opts member Akihiko Odaki
2024-02-18  4:56 ` [PATCH v5 07/11] pcie_sriov: Reset SR-IOV extended capability Akihiko Odaki
2024-02-18  4:56 ` [PATCH v5 08/11] pcie_sriov: Do not reset NumVFs after disabling VFs Akihiko Odaki
2024-02-18  4:56 ` Akihiko Odaki [this message]
2024-02-18  4:56 ` [PATCH v5 10/11] hw/pci: Rename has_power to enabled Akihiko Odaki
2024-02-18  4:56 ` [PATCH v5 11/11] pcie_sriov: Reuse SR-IOV VF device instances Akihiko Odaki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240218-reuse-v5-9-e4fc1c19b5a9@daynix.com \
    --to=akihiko.odaki@daynix.com \
    --cc=alex.williamson@redhat.com \
    --cc=berrange@redhat.com \
    --cc=clg@redhat.com \
    --cc=eduardo@habkost.net \
    --cc=its@irrelevant.dk \
    --cc=jasowang@redhat.com \
    --cc=kbusch@kernel.org \
    --cc=marcel.apfelbaum@gmail.com \
    --cc=mst@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=philmd@linaro.org \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=sriram.yagnaraman@est.tech \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).