qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Joe Komlodi <komlodi@google.com>
To: qemu-devel@nongnu.org
Cc: komlodi@google.com, venture@google.com, minyard@acm.org,
	 peter.maydell@linaro.org
Subject: [PATCH v4 0/3] hw/i2c: smbus: Reset fixes
Date: Tue, 20 Feb 2024 21:11:20 +0000	[thread overview]
Message-ID: <20240220211123.2664977-1-komlodi@google.com> (raw)

Changelog:

v3 -> v4

Patch 1
- Removed the rest of the I3CBus class definition that I forgot to
  remove in v3

v2 -> v3
Patch 1
- Removed I3CBus class definition, since it was unneeded.
- whitespace fixes
- Changed enter_reset to hold_reset

Patch 2
- Moved pointer returned by object_get_canonical_path outside of printf
  so it can be freed

Patch 3
- Changed enter_reset to hold_reset

v1 -> v2
- Dropped 4th patch "hw/i2c: smbus: mux: Reset SMBusDevice state
on reset". After more testing and Corey's comment, I realized it
wasn't needed.

Original message:

Hi all,

This series adds some resets for SMBus and for the I2C core. Along with
it, we make SMBus slave error printing a little more helpful.

These reset issues were very infrequent, they would maybe occur in 1 out
of hundreds of resets in our testing, but the way they happen is pretty
straightforward.

Basically as long as a reset happens in the middle of a transaction, the
state of the old transaction would still partially be there after the
reset. Once a new transaction comes in, the partial stale state can
cause the new transaction to incorrectly fail.

Thanks,
Joe

Joe Komlodi (3):
  hw/i2c: core: Add reset
  hw/i2c/smbus_slave: Add object path on error prints
  hw/i2c: smbus_slave: Reset state on reset

 hw/i2c/core.c        | 19 +++++++++++++++++++
 hw/i2c/smbus_slave.c | 17 +++++++++++++++--
 2 files changed, 34 insertions(+), 2 deletions(-)

-- 
2.44.0.rc0.258.g7320e95886-goog



             reply	other threads:[~2024-02-20 21:12 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-02-20 21:11 Joe Komlodi [this message]
2024-02-20 21:11 ` [PATCH v4 1/3] hw/i2c: core: Add reset Joe Komlodi
2024-02-20 21:11 ` [PATCH v4 2/3] hw/i2c/smbus_slave: Add object path on error prints Joe Komlodi
2024-02-21 18:28   ` Philippe Mathieu-Daudé
2024-02-20 21:11 ` [PATCH v4 3/3] hw/i2c: smbus_slave: Reset state on reset Joe Komlodi
2024-02-22 14:47 ` [PATCH v4 0/3] hw/i2c: smbus: Reset fixes Philippe Mathieu-Daudé

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240220211123.2664977-1-komlodi@google.com \
    --to=komlodi@google.com \
    --cc=minyard@acm.org \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=venture@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).