From: Joe Komlodi <komlodi@google.com>
To: qemu-devel@nongnu.org
Cc: komlodi@google.com, venture@google.com, minyard@acm.org,
peter.maydell@linaro.org
Subject: [PATCH v4 1/3] hw/i2c: core: Add reset
Date: Tue, 20 Feb 2024 21:11:21 +0000 [thread overview]
Message-ID: <20240220211123.2664977-2-komlodi@google.com> (raw)
In-Reply-To: <20240220211123.2664977-1-komlodi@google.com>
It's possible for a reset to come in the middle of a transaction, which
causes the bus to be in an old state when a new transaction comes in.
Signed-off-by: Joe Komlodi <komlodi@google.com>
---
hw/i2c/core.c | 19 +++++++++++++++++++
1 file changed, 19 insertions(+)
diff --git a/hw/i2c/core.c b/hw/i2c/core.c
index 4cf30b2c86..3128067bba 100644
--- a/hw/i2c/core.c
+++ b/hw/i2c/core.c
@@ -23,10 +23,29 @@ static Property i2c_props[] = {
DEFINE_PROP_END_OF_LIST(),
};
+static void i2c_bus_hold_reset(Object *obj)
+{
+ I2CBus *bus = I2C_BUS(obj);
+ I2CNode *node, *next;
+
+ bus->broadcast = false;
+ QLIST_FOREACH_SAFE(node, &bus->current_devs, next, next) {
+ QLIST_REMOVE(node, next);
+ g_free(node);
+ }
+}
+
+static void i2c_bus_class_init(ObjectClass *klass, void *data)
+{
+ ResettableClass *rc = RESETTABLE_CLASS(klass);
+ rc->phases.hold = i2c_bus_hold_reset;
+}
+
static const TypeInfo i2c_bus_info = {
.name = TYPE_I2C_BUS,
.parent = TYPE_BUS,
.instance_size = sizeof(I2CBus),
+ .class_init = i2c_bus_class_init,
};
static int i2c_bus_pre_save(void *opaque)
--
2.44.0.rc0.258.g7320e95886-goog
next prev parent reply other threads:[~2024-02-20 21:12 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-20 21:11 [PATCH v4 0/3] hw/i2c: smbus: Reset fixes Joe Komlodi
2024-02-20 21:11 ` Joe Komlodi [this message]
2024-02-20 21:11 ` [PATCH v4 2/3] hw/i2c/smbus_slave: Add object path on error prints Joe Komlodi
2024-02-21 18:28 ` Philippe Mathieu-Daudé
2024-02-20 21:11 ` [PATCH v4 3/3] hw/i2c: smbus_slave: Reset state on reset Joe Komlodi
2024-02-22 14:47 ` [PATCH v4 0/3] hw/i2c: smbus: Reset fixes Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240220211123.2664977-2-komlodi@google.com \
--to=komlodi@google.com \
--cc=minyard@acm.org \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=venture@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).