qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] qga-win: Add support of Windows Server 2025 in get-osinfo command
@ 2024-02-21  9:51 Dehan Meng
  2024-02-21 10:00 ` Konstantin Kostiuk
  0 siblings, 1 reply; 3+ messages in thread
From: Dehan Meng @ 2024-02-21  9:51 UTC (permalink / raw)
  To: qemu-devel; +Cc: demeng, kkostiuk, michael.roth

Add support of Windows Server 2025 in get-osinfo command

Signed-off-by: Dehan Meng <demeng@redhat.com>
---
 qga/commands-win32.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/qga/commands-win32.c b/qga/commands-win32.c
index 697c65507c..f3c7e604c9 100644
--- a/qga/commands-win32.c
+++ b/qga/commands-win32.c
@@ -2154,6 +2154,7 @@ static ga_win_10_0_t const WIN_10_0_SERVER_VERSION_MATRIX[4] = {
     {14393, "Microsoft Windows Server 2016",    "2016"},
     {17763, "Microsoft Windows Server 2019",    "2019"},
     {20344, "Microsoft Windows Server 2022",    "2022"},
+    {26040, "MIcrosoft Windows Server 2025",    "2025"},
     {0, 0}
 };
 
-- 
2.35.1



^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] qga-win: Add support of Windows Server 2025 in get-osinfo command
  2024-02-21  9:51 [PATCH] qga-win: Add support of Windows Server 2025 in get-osinfo command Dehan Meng
@ 2024-02-21 10:00 ` Konstantin Kostiuk
  2024-02-22  2:56   ` Dehan Meng
  0 siblings, 1 reply; 3+ messages in thread
From: Konstantin Kostiuk @ 2024-02-21 10:00 UTC (permalink / raw)
  To: Dehan Meng; +Cc: qemu-devel, michael.roth

[-- Attachment #1: Type: text/plain, Size: 882 bytes --]

On Wed, Feb 21, 2024 at 11:51 AM Dehan Meng <demeng@redhat.com> wrote:

> Add support of Windows Server 2025 in get-osinfo command
>
> Signed-off-by: Dehan Meng <demeng@redhat.com>
> ---
>  qga/commands-win32.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/qga/commands-win32.c b/qga/commands-win32.c
> index 697c65507c..f3c7e604c9 100644
> --- a/qga/commands-win32.c
> +++ b/qga/commands-win32.c
> @@ -2154,6 +2154,7 @@ static ga_win_10_0_t const
> WIN_10_0_SERVER_VERSION_MATRIX[4] = {
>

You don't update the array size, there are out of range elements


>      {14393, "Microsoft Windows Server 2016",    "2016"},
>      {17763, "Microsoft Windows Server 2019",    "2019"},
>      {20344, "Microsoft Windows Server 2022",    "2022"},
> +    {26040, "MIcrosoft Windows Server 2025",    "2025"},
>      {0, 0}
>  };
>
> --
> 2.35.1
>
>

[-- Attachment #2: Type: text/html, Size: 1563 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] qga-win: Add support of Windows Server 2025 in get-osinfo command
  2024-02-21 10:00 ` Konstantin Kostiuk
@ 2024-02-22  2:56   ` Dehan Meng
  0 siblings, 0 replies; 3+ messages in thread
From: Dehan Meng @ 2024-02-22  2:56 UTC (permalink / raw)
  To: Konstantin Kostiuk; +Cc: qemu-devel, michael.roth

[-- Attachment #1: Type: text/plain, Size: 1024 bytes --]

Done. thanks.

On Wed, Feb 21, 2024 at 6:00 PM Konstantin Kostiuk <kkostiuk@redhat.com>
wrote:

>
>
> On Wed, Feb 21, 2024 at 11:51 AM Dehan Meng <demeng@redhat.com> wrote:
>
>> Add support of Windows Server 2025 in get-osinfo command
>>
>> Signed-off-by: Dehan Meng <demeng@redhat.com>
>> ---
>>  qga/commands-win32.c | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/qga/commands-win32.c b/qga/commands-win32.c
>> index 697c65507c..f3c7e604c9 100644
>> --- a/qga/commands-win32.c
>> +++ b/qga/commands-win32.c
>> @@ -2154,6 +2154,7 @@ static ga_win_10_0_t const
>> WIN_10_0_SERVER_VERSION_MATRIX[4] = {
>>
>
> You don't update the array size, there are out of range elements
>
>
>>      {14393, "Microsoft Windows Server 2016",    "2016"},
>>      {17763, "Microsoft Windows Server 2019",    "2019"},
>>      {20344, "Microsoft Windows Server 2022",    "2022"},
>> +    {26040, "MIcrosoft Windows Server 2025",    "2025"},
>>      {0, 0}
>>  };
>>
>> --
>> 2.35.1
>>
>>

[-- Attachment #2: Type: text/html, Size: 1962 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2024-02-22  2:56 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-02-21  9:51 [PATCH] qga-win: Add support of Windows Server 2025 in get-osinfo command Dehan Meng
2024-02-21 10:00 ` Konstantin Kostiuk
2024-02-22  2:56   ` Dehan Meng

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).