qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: peterx@redhat.com
To: qemu-devel@nongnu.org
Cc: "Fabiano Rosas" <farosas@suse.de>,
	peterx@redhat.com, "Avihai Horon" <avihaih@nvidia.com>,
	"Daniel P . Berrangé" <berrange@redhat.com>
Subject: [PATCH v2 3/5] migration/multifd: Make multifd_channel_connect() return void
Date: Thu, 22 Feb 2024 17:52:59 +0800	[thread overview]
Message-ID: <20240222095301.171137-4-peterx@redhat.com> (raw)
In-Reply-To: <20240222095301.171137-1-peterx@redhat.com>

From: Peter Xu <peterx@redhat.com>

It never fails, drop the retval and also the Error**.

Suggested-by: Avihai Horon <avihaih@nvidia.com>
Signed-off-by: Peter Xu <peterx@redhat.com>
---
 migration/multifd.c | 8 +++-----
 1 file changed, 3 insertions(+), 5 deletions(-)

diff --git a/migration/multifd.c b/migration/multifd.c
index da2e7c1db1..f52f01ca85 100644
--- a/migration/multifd.c
+++ b/migration/multifd.c
@@ -925,9 +925,7 @@ static bool multifd_tls_channel_connect(MultiFDSendParams *p,
     return true;
 }
 
-static bool multifd_channel_connect(MultiFDSendParams *p,
-                                    QIOChannel *ioc,
-                                    Error **errp)
+static void multifd_channel_connect(MultiFDSendParams *p, QIOChannel *ioc)
 {
     qio_channel_set_delay(ioc, false);
 
@@ -938,7 +936,6 @@ static bool multifd_channel_connect(MultiFDSendParams *p,
     p->thread_created = true;
     qemu_thread_create(&p->thread, p->name, multifd_send_thread, p,
                        QEMU_THREAD_JOINABLE);
-    return true;
 }
 
 /*
@@ -970,7 +967,8 @@ static void multifd_new_send_channel_async(QIOTask *task, gpointer opaque)
             return;
         }
     } else {
-        ret = multifd_channel_connect(p, ioc, &local_err);
+        multifd_channel_connect(p, ioc);
+        ret = true;
     }
 
 out:
-- 
2.43.0



  parent reply	other threads:[~2024-02-22  9:54 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-02-22  9:52 [PATCH v2 0/5] migration: cleanup TLS channel referencing peterx
2024-02-22  9:52 ` [PATCH v2 1/5] migration/multifd: Cleanup TLS iochannel referencing peterx
2024-02-22 13:55   ` Fabiano Rosas
2024-02-22  9:52 ` [PATCH v2 2/5] migration/multifd: Drop registered_yank peterx
2024-02-22  9:52 ` peterx [this message]
2024-02-22 13:57   ` [PATCH v2 3/5] migration/multifd: Make multifd_channel_connect() return void Fabiano Rosas
2024-02-22  9:53 ` [PATCH v2 4/5] migration/multifd: Cleanup outgoing_args in state destroy peterx
2024-02-22 13:58   ` Fabiano Rosas
2024-02-22  9:53 ` [PATCH v2 5/5] migration/multifd: Drop unnecessary helper to destroy IOC peterx
2024-02-22 14:01   ` Fabiano Rosas
2024-02-26  3:33 ` [PATCH v2 0/5] migration: cleanup TLS channel referencing Peter Xu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240222095301.171137-4-peterx@redhat.com \
    --to=peterx@redhat.com \
    --cc=avihaih@nvidia.com \
    --cc=berrange@redhat.com \
    --cc=farosas@suse.de \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).