qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: qemu-devel@nongnu.org
Cc: philmd@linaro.org, balaton@eik.bme.hu
Subject: [PATCH 00/10] usb cleanups: remove usb_bus_find(), extract sysbus-ohci to a separate file
Date: Fri, 23 Feb 2024 13:43:56 +0100	[thread overview]
Message-ID: <20240223124406.234509-1-pbonzini@redhat.com> (raw)

Patches 1 to 3 start the removal of usb_bus_find() by replacing it
with object_resolve_type_unambiguous(), a function that is included
in the ACPI builder but should arguably be part of the core QOM API.
Because the only USB host controller must be the one created by the
machine init function itself, there is no need for a special functions
that looks for the "first" bus.

Patches 4 to 7 allow machines that have builtin USB devices to make
the USB system merely the default, and not require it.  At this point
usb_bus_find() is not used anymore outside usb.c, and the only remaining
caller can inline it in patch 8.

Patches 9 and 10 do other build system cleanups to the USB subsystem,
extracting sysbus-ohci to a separate file (as is already the case for
EHCI and XHCI sysbus variants) and removing a duplicate file in the
Meson sourcesets.

The diffstat looks unfavorable, but it's mostly due to
improved documentation and to the duplicated header comment
in hw/usb/hcd-ohci-sysbus.c.

Paolo

Paolo Bonzini (10):
  acpi, qom: move object_resolve_type_unambiguous to core QOM
  ppc: sam460ex: do not use usb_bus_find()
  sh4: r2d: do not use usb_bus_find()
  mips/loongson3_virt: do not require CONFIG_USB
  hppa: do not require CONFIG_USB
  mac_newworld: do not require CONFIG_USB
  pseries: do not require CONFIG_USB
  usb: remove usb_bus_find
  usb: extract sysbus-ohci to a separate file
  usb: remove duplicate file in system_ss

 include/hw/usb.h         |  1 -
 include/qom/object.h     | 13 ++++++
 hw/hppa/machine.c        |  7 +--
 hw/i386/acpi-build.c     | 19 ++------
 hw/mips/loongson3_virt.c |  5 +-
 hw/ppc/mac_newworld.c    |  7 ++-
 hw/ppc/sam460ex.c        |  6 ++-
 hw/ppc/spapr.c           |  7 ++-
 hw/sh4/r2d.c             |  4 +-
 hw/usb/bus.c             | 15 +-----
 hw/usb/hcd-ohci-sysbus.c | 91 ++++++++++++++++++++++++++++++++++++++++
 hw/usb/hcd-ohci.c        | 58 ------------------------
 qom/object.c             | 16 +++++++
 hw/arm/Kconfig           | 12 +++--
 hw/display/Kconfig       |  1 +
 hw/hppa/Kconfig          |  2 +-
 hw/ppc/Kconfig           |  5 +-
 hw/sh4/Kconfig           |  1 -
 hw/usb/Kconfig           |  4 ++
 hw/usb/meson.build       |  3 +-
 20 files changed, 163 insertions(+), 114 deletions(-)
 create mode 100644 hw/usb/hcd-ohci-sysbus.c

-- 
2.43.0



             reply	other threads:[~2024-02-23 12:47 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-02-23 12:43 Paolo Bonzini [this message]
2024-02-23 12:43 ` [PATCH 01/10] acpi, qom: move object_resolve_type_unambiguous to core QOM Paolo Bonzini
2024-02-23 17:02   ` Philippe Mathieu-Daudé
2024-02-26  7:00   ` Thomas Huth
2024-02-23 12:43 ` [PATCH 02/10] ppc: sam460ex: do not use usb_bus_find() Paolo Bonzini
2024-02-26  7:03   ` Thomas Huth
2024-02-26  7:39   ` Markus Armbruster
2024-02-26  7:41     ` Markus Armbruster
2024-02-26 10:46       ` BALATON Zoltan
2024-02-26  7:42   ` Markus Armbruster
2024-02-23 12:43 ` [PATCH 03/10] sh4: r2d: " Paolo Bonzini
2024-02-26  7:04   ` Thomas Huth
2024-02-23 12:44 ` [PATCH 04/10] mips/loongson3_virt: do not require CONFIG_USB Paolo Bonzini
2024-02-26  7:05   ` Thomas Huth
2024-02-26  7:42   ` Markus Armbruster
2024-02-23 12:44 ` [PATCH 05/10] hppa: " Paolo Bonzini
2024-02-23 17:19   ` Philippe Mathieu-Daudé
2024-02-23 19:23   ` Thomas Huth
2024-02-23 19:56     ` BALATON Zoltan
2024-02-24 22:38       ` Paolo Bonzini
2024-02-26  6:56         ` Thomas Huth
2024-02-23 12:44 ` [PATCH 06/10] mac_newworld: " Paolo Bonzini
2024-02-23 17:20   ` Philippe Mathieu-Daudé
2024-02-23 12:44 ` [PATCH 07/10] pseries: " Paolo Bonzini
2024-02-23 17:32   ` Philippe Mathieu-Daudé
2024-02-23 17:47     ` Paolo Bonzini
2024-02-23 12:44 ` [PATCH 08/10] usb: remove usb_bus_find Paolo Bonzini
2024-02-23 17:03   ` Philippe Mathieu-Daudé
2024-02-23 12:44 ` [PATCH 09/10] usb: extract sysbus-ohci to a separate file Paolo Bonzini
2024-02-23 17:10   ` Philippe Mathieu-Daudé
2024-02-26  7:14   ` Thomas Huth
2024-02-23 12:44 ` [PATCH 10/10] usb: remove duplicate file in system_ss Paolo Bonzini
2024-02-23 17:40   ` Philippe Mathieu-Daudé
2024-02-26  7:57 ` [PATCH 00/10] usb cleanups: remove usb_bus_find(), extract sysbus-ohci to a separate file Philippe Mathieu-Daudé

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240223124406.234509-1-pbonzini@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=balaton@eik.bme.hu \
    --cc=philmd@linaro.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).