qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Akihiko Odaki <akihiko.odaki@daynix.com>
To: "Peter Maydell" <peter.maydell@linaro.org>,
	"Philippe Mathieu-Daudé" <philmd@linaro.org>,
	"Gerd Hoffmann" <kraxel@redhat.com>,
	"Marc-André Lureau" <marcandre.lureau@redhat.com>,
	"Marek Glogowski" <smarkusg@gmail.com>,
	"BALATON Zoltan" <balaton@eik.bme.hu>,
	"Rene Engel" <ReneEngel80@emailn.de>
Cc: qemu-devel@nongnu.org, Akihiko Odaki <akihiko.odaki@daynix.com>
Subject: [PATCH v12 10/10] ui/cocoa: Remove stretch_video flag
Date: Sat, 24 Feb 2024 21:43:41 +0900	[thread overview]
Message-ID: <20240224-cocoa-v12-10-e89f70bdda71@daynix.com> (raw)
In-Reply-To: <20240224-cocoa-v12-0-e89f70bdda71@daynix.com>

Evaluate [normalWindow styleMask] & NSWindowStyleMaskResizable instead.

Signed-off-by: Akihiko Odaki <akihiko.odaki@daynix.com>
---
 ui/cocoa.m | 19 ++++++-------------
 1 file changed, 6 insertions(+), 13 deletions(-)

diff --git a/ui/cocoa.m b/ui/cocoa.m
index 33d31b82bcab..b33842e70280 100644
--- a/ui/cocoa.m
+++ b/ui/cocoa.m
@@ -102,7 +102,6 @@ static void cocoa_switch(DisplayChangeListener *dcl,
 static int left_command_key_enabled = 1;
 static bool swap_opt_cmd;
 
-static bool stretch_video;
 static NSTextField *pauseLabel;
 
 static bool allow_events;
@@ -514,7 +513,7 @@ - (void) resizeWindow
 {
     [[self window] setContentAspectRatio:NSMakeSize(screen.width, screen.height)];
 
-    if (!stretch_video) {
+    if (!([[self window] styleMask] & NSWindowStyleMaskResizable)) {
         [[self window] setContentSize:NSMakeSize(screen.width, screen.height)];
         [[self window] center];
     } else if ([[self window] styleMask] & NSWindowStyleMaskFullScreen) {
@@ -1346,15 +1345,10 @@ - (void)showQEMUDoc:(id)sender
 /* Stretches video to fit host monitor size */
 - (void)zoomToFit:(id) sender
 {
-    stretch_video = !stretch_video;
-    if (stretch_video == true) {
-        [cocoaView window].styleMask |= NSWindowStyleMaskResizable;
-        [sender setState: NSControlStateValueOn];
-    } else {
-        [cocoaView window].styleMask &= ~NSWindowStyleMaskResizable;
-        [cocoaView resizeWindow];
-        [sender setState: NSControlStateValueOff];
-    }
+    NSWindowStyleMask styleMask = [[cocoaView window] styleMask] ^ NSWindowStyleMaskResizable;
+
+    [[cocoaView window] setStyleMask:styleMask];
+    [sender setState:styleMask & NSWindowStyleMaskResizable ? NSControlStateValueOn : NSControlStateValueOff];
 }
 
 /* Displays the console on the screen */
@@ -1619,7 +1613,7 @@ static void create_initial_menus(void)
     menu = [[NSMenu alloc] initWithTitle:@"View"];
     [menu addItem: [[[NSMenuItem alloc] initWithTitle:@"Enter Fullscreen" action:@selector(doToggleFullScreen:) keyEquivalent:@"f"] autorelease]]; // Fullscreen
     menuItem = [[[NSMenuItem alloc] initWithTitle:@"Zoom To Fit" action:@selector(zoomToFit:) keyEquivalent:@""] autorelease];
-    [menuItem setState: stretch_video ? NSControlStateValueOn : NSControlStateValueOff];
+    [menuItem setState: [[cocoaView window] styleMask] & NSWindowStyleMaskResizable ? NSControlStateValueOn : NSControlStateValueOff];
     [menu addItem: menuItem];
     menuItem = [[[NSMenuItem alloc] initWithTitle:@"View" action:nil keyEquivalent:@""] autorelease];
     [menuItem setSubmenu:menu];
@@ -2005,7 +1999,6 @@ static void cocoa_display_init(DisplayState *ds, DisplayOptions *opts)
     }
 
     if (opts->u.cocoa.has_zoom_to_fit && opts->u.cocoa.zoom_to_fit) {
-        stretch_video = true;
         [cocoaView window].styleMask |= NSWindowStyleMaskResizable;
     }
 

-- 
2.43.2



  parent reply	other threads:[~2024-02-24 12:45 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-02-24 12:43 [PATCH v12 00/10] ui/cocoa: Use NSWindow's ability to resize Akihiko Odaki
2024-02-24 12:43 ` [PATCH v12 01/10] ui/cocoa: Split [-QemuCocoaView handleEventLocked:] Akihiko Odaki
2024-02-26 16:58   ` Peter Maydell
2024-02-24 12:43 ` [PATCH v12 02/10] ui/cocoa: Immediately call [-QemuCocoaView handleMouseEvent:buttons:] Akihiko Odaki
2024-02-26 16:59   ` Peter Maydell
2024-02-24 12:43 ` [PATCH v12 03/10] ui/cocoa: Release specific mouse buttons Akihiko Odaki
2024-02-26 17:00   ` Peter Maydell
2024-02-24 12:43 ` [PATCH v12 04/10] ui/cocoa: Scale with NSView instead of Core Graphics Akihiko Odaki
2024-02-24 12:43 ` [PATCH v12 05/10] ui/cocoa: Fix pause label coordinates Akihiko Odaki
2024-02-26 17:01   ` Peter Maydell
2024-02-24 12:43 ` [PATCH v12 06/10] ui/cocoa: Let the platform toggle fullscreen Akihiko Odaki
2024-02-26 17:14   ` Peter Maydell
2024-02-24 12:43 ` [PATCH v12 07/10] ui/cocoa: Remove normalWindow Akihiko Odaki
2024-02-26 17:04   ` Peter Maydell
2024-02-24 12:43 ` [PATCH v12 08/10] ui/cocoa: Make window resizable Akihiko Odaki
2024-02-24 12:43 ` [PATCH v12 09/10] ui/cocoa: Call console_select() with the BQL Akihiko Odaki
2024-02-24 12:43 ` Akihiko Odaki [this message]
2024-02-26 17:02   ` [PATCH v12 10/10] ui/cocoa: Remove stretch_video flag Peter Maydell
2024-02-26 18:19 ` [PATCH v12 00/10] ui/cocoa: Use NSWindow's ability to resize Philippe Mathieu-Daudé

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240224-cocoa-v12-10-e89f70bdda71@daynix.com \
    --to=akihiko.odaki@daynix.com \
    --cc=ReneEngel80@emailn.de \
    --cc=balaton@eik.bme.hu \
    --cc=kraxel@redhat.com \
    --cc=marcandre.lureau@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=philmd@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=smarkusg@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).