qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Akihiko Odaki <akihiko.odaki@daynix.com>
To: "Peter Maydell" <peter.maydell@linaro.org>,
	"Philippe Mathieu-Daudé" <philmd@linaro.org>,
	"Gerd Hoffmann" <kraxel@redhat.com>,
	"Marc-André Lureau" <marcandre.lureau@redhat.com>,
	"Marek Glogowski" <smarkusg@gmail.com>,
	"BALATON Zoltan" <balaton@eik.bme.hu>,
	"Rene Engel" <ReneEngel80@emailn.de>
Cc: qemu-devel@nongnu.org, Akihiko Odaki <akihiko.odaki@daynix.com>
Subject: [PATCH v12 04/10] ui/cocoa: Scale with NSView instead of Core Graphics
Date: Sat, 24 Feb 2024 21:43:35 +0900	[thread overview]
Message-ID: <20240224-cocoa-v12-4-e89f70bdda71@daynix.com> (raw)
In-Reply-To: <20240224-cocoa-v12-0-e89f70bdda71@daynix.com>

Core Graphics is not accelerated and slow.

Signed-off-by: Akihiko Odaki <akihiko.odaki@daynix.com>
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
---
 ui/cocoa.m | 24 ++++++++++--------------
 1 file changed, 10 insertions(+), 14 deletions(-)

diff --git a/ui/cocoa.m b/ui/cocoa.m
index c73ef8884454..644fd32eaa4d 100644
--- a/ui/cocoa.m
+++ b/ui/cocoa.m
@@ -496,10 +496,8 @@ - (void) drawRect:(NSRect) rect
 
         [self getRectsBeingDrawn:&rectList count:&rectCount];
         for (i = 0; i < rectCount; i++) {
-            clipRect.origin.x = rectList[i].origin.x / cdx;
-            clipRect.origin.y = (float)h - (rectList[i].origin.y + rectList[i].size.height) / cdy;
-            clipRect.size.width = rectList[i].size.width / cdx;
-            clipRect.size.height = rectList[i].size.height / cdy;
+            clipRect = rectList[i];
+            clipRect.origin.y = (float)h - (clipRect.origin.y + clipRect.size.height);
             clipImageRef = CGImageCreateWithImageInRect(
                                                         imageRef,
                                                         clipRect
@@ -545,6 +543,11 @@ - (void) setContentDimensions
     }
 }
 
+- (void) updateBounds
+{
+    [self setBoundsSize:NSMakeSize(screen.width, screen.height)];
+}
+
 - (void) updateUIInfoLocked
 {
     /* Must be called with the BQL, i.e. via updateUIInfo */
@@ -634,6 +637,7 @@ - (void) switchSurface:(pixman_image_t *)image
         screen.height = h;
         [self setContentDimensions];
         [self setFrame:NSMakeRect(cx, cy, cw, ch)];
+        [self updateBounds];
     }
 
     // update screenBuffer
@@ -1297,6 +1301,7 @@ - (void)windowDidChangeScreen:(NSNotification *)notification
 
 - (void)windowDidResize:(NSNotification *)notification
 {
+    [cocoaView updateBounds];
     [cocoaView updateUIInfo];
 }
 
@@ -1945,16 +1950,7 @@ static void cocoa_update(DisplayChangeListener *dcl,
     COCOA_DEBUG("qemu_cocoa: cocoa_update\n");
 
     dispatch_async(dispatch_get_main_queue(), ^{
-        NSRect rect;
-        if ([cocoaView cdx] == 1.0) {
-            rect = NSMakeRect(x, [cocoaView gscreen].height - y - h, w, h);
-        } else {
-            rect = NSMakeRect(
-                x * [cocoaView cdx],
-                ([cocoaView gscreen].height - y - h) * [cocoaView cdy],
-                w * [cocoaView cdx],
-                h * [cocoaView cdy]);
-        }
+        NSRect rect = NSMakeRect(x, [cocoaView gscreen].height - y - h, w, h);
         [cocoaView setNeedsDisplayInRect:rect];
     });
 }

-- 
2.43.2



  parent reply	other threads:[~2024-02-24 12:45 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-02-24 12:43 [PATCH v12 00/10] ui/cocoa: Use NSWindow's ability to resize Akihiko Odaki
2024-02-24 12:43 ` [PATCH v12 01/10] ui/cocoa: Split [-QemuCocoaView handleEventLocked:] Akihiko Odaki
2024-02-26 16:58   ` Peter Maydell
2024-02-24 12:43 ` [PATCH v12 02/10] ui/cocoa: Immediately call [-QemuCocoaView handleMouseEvent:buttons:] Akihiko Odaki
2024-02-26 16:59   ` Peter Maydell
2024-02-24 12:43 ` [PATCH v12 03/10] ui/cocoa: Release specific mouse buttons Akihiko Odaki
2024-02-26 17:00   ` Peter Maydell
2024-02-24 12:43 ` Akihiko Odaki [this message]
2024-02-24 12:43 ` [PATCH v12 05/10] ui/cocoa: Fix pause label coordinates Akihiko Odaki
2024-02-26 17:01   ` Peter Maydell
2024-02-24 12:43 ` [PATCH v12 06/10] ui/cocoa: Let the platform toggle fullscreen Akihiko Odaki
2024-02-26 17:14   ` Peter Maydell
2024-02-24 12:43 ` [PATCH v12 07/10] ui/cocoa: Remove normalWindow Akihiko Odaki
2024-02-26 17:04   ` Peter Maydell
2024-02-24 12:43 ` [PATCH v12 08/10] ui/cocoa: Make window resizable Akihiko Odaki
2024-02-24 12:43 ` [PATCH v12 09/10] ui/cocoa: Call console_select() with the BQL Akihiko Odaki
2024-02-24 12:43 ` [PATCH v12 10/10] ui/cocoa: Remove stretch_video flag Akihiko Odaki
2024-02-26 17:02   ` Peter Maydell
2024-02-26 18:19 ` [PATCH v12 00/10] ui/cocoa: Use NSWindow's ability to resize Philippe Mathieu-Daudé

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240224-cocoa-v12-4-e89f70bdda71@daynix.com \
    --to=akihiko.odaki@daynix.com \
    --cc=ReneEngel80@emailn.de \
    --cc=balaton@eik.bme.hu \
    --cc=kraxel@redhat.com \
    --cc=marcandre.lureau@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=philmd@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=smarkusg@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).