From: Akihiko Odaki <akihiko.odaki@daynix.com>
To: "Philippe Mathieu-Daudé" <philmd@linaro.org>,
"Michael S. Tsirkin" <mst@redhat.com>,
"Marcel Apfelbaum" <marcel.apfelbaum@gmail.com>,
"Alex Williamson" <alex.williamson@redhat.com>,
"Cédric Le Goater" <clg@redhat.com>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Daniel P. Berrangé" <berrange@redhat.com>,
"Eduardo Habkost" <eduardo@habkost.net>,
"Sriram Yagnaraman" <sriram.yagnaraman@est.tech>,
"Jason Wang" <jasowang@redhat.com>,
"Keith Busch" <kbusch@kernel.org>,
"Klaus Jensen" <its@irrelevant.dk>
Cc: qemu-devel@nongnu.org, qemu-block@nongnu.org,
Akihiko Odaki <akihiko.odaki@daynix.com>
Subject: [PATCH v7 07/16] pcie_sriov: Do not manually unrealize
Date: Sat, 24 Feb 2024 18:24:39 +0900 [thread overview]
Message-ID: <20240224-reuse-v7-7-29c14bcb952e@daynix.com> (raw)
In-Reply-To: <20240224-reuse-v7-0-29c14bcb952e@daynix.com>
A device gets automatically unrealized when being unparented.
Signed-off-by: Akihiko Odaki <akihiko.odaki@daynix.com>
---
hw/pci/pcie_sriov.c | 5 -----
1 file changed, 5 deletions(-)
diff --git a/hw/pci/pcie_sriov.c b/hw/pci/pcie_sriov.c
index e9b23221d713..8b1fd2a89ad7 100644
--- a/hw/pci/pcie_sriov.c
+++ b/hw/pci/pcie_sriov.c
@@ -17,7 +17,6 @@
#include "hw/qdev-properties.h"
#include "qemu/error-report.h"
#include "qemu/range.h"
-#include "qapi/error.h"
#include "trace.h"
static PCIDevice *register_vf(PCIDevice *pf, int devfn,
@@ -204,11 +203,7 @@ static void unregister_vfs(PCIDevice *dev)
trace_sriov_unregister_vfs(dev->name, PCI_SLOT(dev->devfn),
PCI_FUNC(dev->devfn), num_vfs);
for (i = 0; i < num_vfs; i++) {
- Error *err = NULL;
PCIDevice *vf = dev->exp.sriov_pf.vf[i];
- if (!object_property_set_bool(OBJECT(vf), "realized", false, &err)) {
- error_reportf_err(err, "Failed to unplug: ");
- }
object_unparent(OBJECT(vf));
object_unref(OBJECT(vf));
}
--
2.43.2
next prev parent reply other threads:[~2024-02-24 9:26 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-24 9:24 [PATCH v7 00/16] hw/pci: SR-IOV related fixes and improvements Akihiko Odaki
2024-02-24 9:24 ` [PATCH v7 01/16] hw/nvme: Use pcie_sriov_num_vfs() Akihiko Odaki
2024-02-24 9:24 ` [PATCH v7 02/16] pcie_sriov: Validate NumVFs Akihiko Odaki
2024-02-24 9:24 ` [PATCH v7 03/16] pcie_sriov: Reset SR-IOV extended capability Akihiko Odaki
2024-02-24 9:24 ` [PATCH v7 04/16] pcie_sriov: Do not reset NumVFs after disabling VFs Akihiko Odaki
2024-02-24 9:24 ` [PATCH v7 05/16] hw/pci: Always call pcie_sriov_pf_reset() Akihiko Odaki
2024-02-24 9:24 ` [PATCH v7 06/16] hw/pci: Rename has_power to enabled Akihiko Odaki
2024-02-24 9:24 ` Akihiko Odaki [this message]
2024-02-24 9:24 ` [PATCH v7 08/16] pcie_sriov: Reuse SR-IOV VF device instances Akihiko Odaki
2024-02-24 9:24 ` [PATCH v7 09/16] pcie_sriov: Release VFs failed to realize Akihiko Odaki
2024-02-24 9:24 ` [PATCH v7 10/16] pcie_sriov: Remove num_vfs from PCIESriovPF Akihiko Odaki
2024-02-24 9:24 ` [PATCH v7 11/16] pcie_sriov: Register VFs after migration Akihiko Odaki
2024-02-24 9:24 ` [PATCH v7 12/16] hw/pci: Replace -1 with UINT32_MAX for romsize Akihiko Odaki
2024-02-28 9:17 ` Markus Armbruster
2024-02-24 9:24 ` [PATCH v7 13/16] hw/pci: Use UINT32_MAX as a default value for rombar Akihiko Odaki
2024-02-24 9:24 ` [PATCH v7 14/16] hw/pci: Determine if rombar is explicitly enabled Akihiko Odaki
2024-02-28 9:24 ` Markus Armbruster
2024-02-24 9:24 ` [PATCH v7 15/16] vfio: Avoid inspecting option QDict for rombar Akihiko Odaki
2024-02-28 9:25 ` Markus Armbruster
2024-02-24 9:24 ` [PATCH v7 16/16] hw/qdev: Remove opts member Akihiko Odaki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240224-reuse-v7-7-29c14bcb952e@daynix.com \
--to=akihiko.odaki@daynix.com \
--cc=alex.williamson@redhat.com \
--cc=berrange@redhat.com \
--cc=clg@redhat.com \
--cc=eduardo@habkost.net \
--cc=its@irrelevant.dk \
--cc=jasowang@redhat.com \
--cc=kbusch@kernel.org \
--cc=marcel.apfelbaum@gmail.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=philmd@linaro.org \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=sriram.yagnaraman@est.tech \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).