From: Markus Armbruster <armbru@redhat.com>
To: qemu-devel@nongnu.org
Cc: michael.roth@amd.com, jsnow@redhat.com, eblake@redhat.com,
kkostiuk@redhat.com
Subject: [PATCH 00/13] Subject: [PATCH 00/15] qapi: Improve command response documentation
Date: Tue, 27 Feb 2024 12:39:08 +0100 [thread overview]
Message-ID: <20240227113921.236097-1-armbru@redhat.com> (raw)
We use doc comment "Returns" sections both for success and error
response. This series moves the latter to new "Errors" sections.
Enables some cleanup, visible in the diffstat.q
Markus Armbruster (13):
qapi: Memorize since & returns sections
qapi: Slightly clearer error message for invalid "Returns" section
qapi: New documentation section tag "Errors"
qapi: Move error documentation to new "Errors" sections
qapi: Delete useless "Returns" sections
qapi: Clean up "Returns" sections
qapi/yank: Tweak @yank's error description for consistency
qga/qapi-schema: Move error documentation to new "Errors" sections
qga/qapi-schema: Delete useless "Returns" sections
qga/qapi-schema: Clean up "Returns" sections
qga/qapi-schema: Tweak documentation of fsfreeze commands
qga/qapi-schema: Fix guest-set-memory-blocks documentation
qapi: Reject "Returns" section when command doesn't return anything
docs/devel/qapi-code-gen.rst | 6 +-
qapi/block-core.json | 74 ++++++++--------------
qapi/block-export.json | 23 ++++---
qapi/block.json | 10 ++-
qapi/char.json | 6 --
qapi/dump.json | 2 -
qapi/machine-target.json | 37 ++++++-----
qapi/machine.json | 19 ++----
qapi/migration.json | 26 --------
qapi/misc-target.json | 3 -
qapi/misc.json | 25 +++-----
qapi/net.json | 17 +++--
qapi/qdev.json | 3 +-
qapi/qom.json | 6 +-
qapi/run-state.json | 5 +-
qapi/tpm.json | 2 -
qapi/transaction.json | 5 +-
qapi/ui.json | 17 +----
qapi/yank.json | 5 +-
qga/qapi-schema.json | 72 +++++++++------------
scripts/qapi/parser.py | 50 ++++++++++-----
tests/qapi-schema/doc-good.json | 2 +
tests/qapi-schema/doc-good.out | 2 +
tests/qapi-schema/doc-good.txt | 6 ++
tests/qapi-schema/doc-invalid-return.err | 2 +-
tests/qapi-schema/doc-invalid-return2.err | 1 +
tests/qapi-schema/doc-invalid-return2.json | 7 ++
tests/qapi-schema/doc-invalid-return2.out | 0
tests/qapi-schema/meson.build | 1 +
29 files changed, 189 insertions(+), 245 deletions(-)
create mode 100644 tests/qapi-schema/doc-invalid-return2.err
create mode 100644 tests/qapi-schema/doc-invalid-return2.json
create mode 100644 tests/qapi-schema/doc-invalid-return2.out
--
2.43.0
next reply other threads:[~2024-02-27 11:41 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-27 11:39 Markus Armbruster [this message]
2024-02-27 11:39 ` [PATCH 01/13] qapi: Memorize since & returns sections Markus Armbruster
2024-02-27 11:39 ` [PATCH 02/13] qapi: Slightly clearer error message for invalid "Returns" section Markus Armbruster
2024-02-27 11:39 ` [PATCH 03/13] qapi: New documentation section tag "Errors" Markus Armbruster
2024-02-27 11:39 ` [PATCH 04/13] qapi: Move error documentation to new "Errors" sections Markus Armbruster
2024-02-27 11:39 ` [PATCH 05/13] qapi: Delete useless "Returns" sections Markus Armbruster
2024-02-27 11:39 ` [PATCH 06/13] qapi: Clean up " Markus Armbruster
2024-02-27 11:39 ` [PATCH 07/13] qapi/yank: Tweak @yank's error description for consistency Markus Armbruster
2024-02-27 11:39 ` [PATCH 08/13] qga/qapi-schema: Move error documentation to new "Errors" sections Markus Armbruster
2024-03-04 8:23 ` Konstantin Kostiuk
2024-02-27 11:39 ` [PATCH 09/13] qga/qapi-schema: Delete useless "Returns" sections Markus Armbruster
2024-03-04 8:25 ` Konstantin Kostiuk
2024-02-27 11:39 ` [PATCH 10/13] qga/qapi-schema: Clean up " Markus Armbruster
2024-03-04 8:24 ` Konstantin Kostiuk
2024-02-27 11:39 ` [PATCH 11/13] qga/qapi-schema: Tweak documentation of fsfreeze commands Markus Armbruster
2024-03-04 8:21 ` Konstantin Kostiuk
2024-02-27 11:39 ` [PATCH 12/13] qga/qapi-schema: Fix guest-set-memory-blocks documentation Markus Armbruster
2024-03-04 8:16 ` Konstantin Kostiuk
2024-02-27 11:39 ` [PATCH 13/13] qapi: Reject "Returns" section when command doesn't return anything Markus Armbruster
2024-03-11 15:37 ` [PATCH 00/13] Subject: [PATCH 00/15] qapi: Improve command response documentation Konstantin Kostiuk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240227113921.236097-1-armbru@redhat.com \
--to=armbru@redhat.com \
--cc=eblake@redhat.com \
--cc=jsnow@redhat.com \
--cc=kkostiuk@redhat.com \
--cc=michael.roth@amd.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).