* [PATCH] hw/ide/ahci: Rename ahci_internal.h to ahci-internal.h
@ 2024-02-27 13:13 BALATON Zoltan
2024-02-27 13:38 ` Markus Armbruster
` (2 more replies)
0 siblings, 3 replies; 7+ messages in thread
From: BALATON Zoltan @ 2024-02-27 13:13 UTC (permalink / raw)
To: qemu-devel, qemu-block; +Cc: John Snow, Thomas Huth, philmd
Other headers now use dash instead of underscore. Rename
ahci_internal.h accordingly for consistency.
Signed-off-by: BALATON Zoltan <balaton@eik.bme.hu>
---
hw/ide/{ahci_internal.h => ahci-internal.h} | 0
hw/ide/ahci.c | 2 +-
hw/ide/ich.c | 2 +-
3 files changed, 2 insertions(+), 2 deletions(-)
rename hw/ide/{ahci_internal.h => ahci-internal.h} (100%)
diff --git a/hw/ide/ahci_internal.h b/hw/ide/ahci-internal.h
similarity index 100%
rename from hw/ide/ahci_internal.h
rename to hw/ide/ahci-internal.h
diff --git a/hw/ide/ahci.c b/hw/ide/ahci.c
index b8123bc73d..bfefad2965 100644
--- a/hw/ide/ahci.c
+++ b/hw/ide/ahci.c
@@ -37,7 +37,7 @@
#include "hw/ide/pci.h"
#include "hw/ide/ahci-pci.h"
#include "hw/ide/ahci-sysbus.h"
-#include "ahci_internal.h"
+#include "ahci-internal.h"
#include "ide-internal.h"
#include "trace.h"
diff --git a/hw/ide/ich.c b/hw/ide/ich.c
index 3ea793d790..9b909c87f3 100644
--- a/hw/ide/ich.c
+++ b/hw/ide/ich.c
@@ -70,7 +70,7 @@
#include "sysemu/dma.h"
#include "hw/ide/pci.h"
#include "hw/ide/ahci-pci.h"
-#include "ahci_internal.h"
+#include "ahci-internal.h"
#define ICH9_MSI_CAP_OFFSET 0x80
#define ICH9_SATA_CAP_OFFSET 0xA8
--
2.30.9
^ permalink raw reply related [flat|nested] 7+ messages in thread* Re: [PATCH] hw/ide/ahci: Rename ahci_internal.h to ahci-internal.h
2024-02-27 13:13 [PATCH] hw/ide/ahci: Rename ahci_internal.h to ahci-internal.h BALATON Zoltan
@ 2024-02-27 13:38 ` Markus Armbruster
2024-02-27 14:06 ` Thomas Huth
2024-02-27 16:39 ` Philippe Mathieu-Daudé
2 siblings, 0 replies; 7+ messages in thread
From: Markus Armbruster @ 2024-02-27 13:38 UTC (permalink / raw)
To: BALATON Zoltan; +Cc: qemu-devel, qemu-block, John Snow, Thomas Huth, philmd
BALATON Zoltan <balaton@eik.bme.hu> writes:
> Other headers now use dash instead of underscore. Rename
> ahci_internal.h accordingly for consistency.
>
> Signed-off-by: BALATON Zoltan <balaton@eik.bme.hu>
Reviewed-by: Markus Armbruster <armbru@redhat.com>
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] hw/ide/ahci: Rename ahci_internal.h to ahci-internal.h
2024-02-27 13:13 [PATCH] hw/ide/ahci: Rename ahci_internal.h to ahci-internal.h BALATON Zoltan
2024-02-27 13:38 ` Markus Armbruster
@ 2024-02-27 14:06 ` Thomas Huth
2024-02-27 16:39 ` Philippe Mathieu-Daudé
2 siblings, 0 replies; 7+ messages in thread
From: Thomas Huth @ 2024-02-27 14:06 UTC (permalink / raw)
To: BALATON Zoltan, qemu-devel, qemu-block; +Cc: John Snow, philmd, QEMU Trivial
On 27/02/2024 14.13, BALATON Zoltan wrote:
> Other headers now use dash instead of underscore. Rename
> ahci_internal.h accordingly for consistency.
>
> Signed-off-by: BALATON Zoltan <balaton@eik.bme.hu>
> ---
> hw/ide/{ahci_internal.h => ahci-internal.h} | 0
> hw/ide/ahci.c | 2 +-
> hw/ide/ich.c | 2 +-
> 3 files changed, 2 insertions(+), 2 deletions(-)
> rename hw/ide/{ahci_internal.h => ahci-internal.h} (100%)
>
> diff --git a/hw/ide/ahci_internal.h b/hw/ide/ahci-internal.h
> similarity index 100%
> rename from hw/ide/ahci_internal.h
> rename to hw/ide/ahci-internal.h
> diff --git a/hw/ide/ahci.c b/hw/ide/ahci.c
> index b8123bc73d..bfefad2965 100644
> --- a/hw/ide/ahci.c
> +++ b/hw/ide/ahci.c
> @@ -37,7 +37,7 @@
> #include "hw/ide/pci.h"
> #include "hw/ide/ahci-pci.h"
> #include "hw/ide/ahci-sysbus.h"
> -#include "ahci_internal.h"
> +#include "ahci-internal.h"
> #include "ide-internal.h"
>
> #include "trace.h"
> diff --git a/hw/ide/ich.c b/hw/ide/ich.c
> index 3ea793d790..9b909c87f3 100644
> --- a/hw/ide/ich.c
> +++ b/hw/ide/ich.c
> @@ -70,7 +70,7 @@
> #include "sysemu/dma.h"
> #include "hw/ide/pci.h"
> #include "hw/ide/ahci-pci.h"
> -#include "ahci_internal.h"
> +#include "ahci-internal.h"
>
> #define ICH9_MSI_CAP_OFFSET 0x80
> #define ICH9_SATA_CAP_OFFSET 0xA8
Reviewed-by: Thomas Huth <thuth@redhat.com>
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH] hw/ide/ahci: Rename ahci_internal.h to ahci-internal.h
2024-02-27 13:13 [PATCH] hw/ide/ahci: Rename ahci_internal.h to ahci-internal.h BALATON Zoltan
2024-02-27 13:38 ` Markus Armbruster
2024-02-27 14:06 ` Thomas Huth
@ 2024-02-27 16:39 ` Philippe Mathieu-Daudé
2024-03-10 14:27 ` BALATON Zoltan
2 siblings, 1 reply; 7+ messages in thread
From: Philippe Mathieu-Daudé @ 2024-02-27 16:39 UTC (permalink / raw)
To: BALATON Zoltan, qemu-devel, qemu-block; +Cc: John Snow, Thomas Huth
On 27/2/24 14:13, BALATON Zoltan wrote:
> Other headers now use dash instead of underscore. Rename
> ahci_internal.h accordingly for consistency.
>
> Signed-off-by: BALATON Zoltan <balaton@eik.bme.hu>
> ---
> hw/ide/{ahci_internal.h => ahci-internal.h} | 0
> hw/ide/ahci.c | 2 +-
> hw/ide/ich.c | 2 +-
> 3 files changed, 2 insertions(+), 2 deletions(-)
> rename hw/ide/{ahci_internal.h => ahci-internal.h} (100%)
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Thanks!
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH] hw/ide/ahci: Rename ahci_internal.h to ahci-internal.h
2024-02-27 16:39 ` Philippe Mathieu-Daudé
@ 2024-03-10 14:27 ` BALATON Zoltan
2024-03-11 7:05 ` Markus Armbruster
0 siblings, 1 reply; 7+ messages in thread
From: BALATON Zoltan @ 2024-03-10 14:27 UTC (permalink / raw)
To: Philippe Mathieu-Daudé
Cc: qemu-devel, qemu-block, John Snow, Thomas Huth
[-- Attachment #1: Type: text/plain, Size: 749 bytes --]
On Tue, 27 Feb 2024, Philippe Mathieu-Daudé wrote:
> On 27/2/24 14:13, BALATON Zoltan wrote:
>> Other headers now use dash instead of underscore. Rename
>> ahci_internal.h accordingly for consistency.
>>
>> Signed-off-by: BALATON Zoltan <balaton@eik.bme.hu>
>> ---
>> hw/ide/{ahci_internal.h => ahci-internal.h} | 0
>> hw/ide/ahci.c | 2 +-
>> hw/ide/ich.c | 2 +-
>> 3 files changed, 2 insertions(+), 2 deletions(-)
>> rename hw/ide/{ahci_internal.h => ahci-internal.h} (100%)
>
> Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Was this also queued somewhere? I haven't seen it merged neither with the
trivial nor the misc-hw pull requests.
Regards,
BALATON Zoltan
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH] hw/ide/ahci: Rename ahci_internal.h to ahci-internal.h
2024-03-10 14:27 ` BALATON Zoltan
@ 2024-03-11 7:05 ` Markus Armbruster
2024-03-11 8:45 ` Philippe Mathieu-Daudé
0 siblings, 1 reply; 7+ messages in thread
From: Markus Armbruster @ 2024-03-11 7:05 UTC (permalink / raw)
To: BALATON Zoltan
Cc: Philippe Mathieu-Daudé, qemu-devel, qemu-block, John Snow,
Thomas Huth, qemu-trivial
BALATON Zoltan <balaton@eik.bme.hu> writes:
> On Tue, 27 Feb 2024, Philippe Mathieu-Daudé wrote:
>> On 27/2/24 14:13, BALATON Zoltan wrote:
>>> Other headers now use dash instead of underscore. Rename
>>> ahci_internal.h accordingly for consistency.
>>> Signed-off-by: BALATON Zoltan <balaton@eik.bme.hu>
>>> ---
>>> hw/ide/{ahci_internal.h => ahci-internal.h} | 0
>>> hw/ide/ahci.c | 2 +-
>>> hw/ide/ich.c | 2 +-
>>> 3 files changed, 2 insertions(+), 2 deletions(-)
>>> rename hw/ide/{ahci_internal.h => ahci-internal.h} (100%)
>>
>> Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
>
> Was this also queued somewhere? I haven't seen it merged neither with the trivial nor the misc-hw pull requests.
I figure John (our IDE odd fixer) wouldn't mind this going via
qemu-trivial. Cc'ed!
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH] hw/ide/ahci: Rename ahci_internal.h to ahci-internal.h
2024-03-11 7:05 ` Markus Armbruster
@ 2024-03-11 8:45 ` Philippe Mathieu-Daudé
0 siblings, 0 replies; 7+ messages in thread
From: Philippe Mathieu-Daudé @ 2024-03-11 8:45 UTC (permalink / raw)
To: Markus Armbruster, BALATON Zoltan
Cc: qemu-devel, qemu-block, John Snow, Thomas Huth, qemu-trivial
On 11/3/24 08:05, Markus Armbruster wrote:
> BALATON Zoltan <balaton@eik.bme.hu> writes:
>
>> On Tue, 27 Feb 2024, Philippe Mathieu-Daudé wrote:
>>> On 27/2/24 14:13, BALATON Zoltan wrote:
>>>> Other headers now use dash instead of underscore. Rename
>>>> ahci_internal.h accordingly for consistency.
>>>> Signed-off-by: BALATON Zoltan <balaton@eik.bme.hu>
>>>> ---
>>>> hw/ide/{ahci_internal.h => ahci-internal.h} | 0
>>>> hw/ide/ahci.c | 2 +-
>>>> hw/ide/ich.c | 2 +-
>>>> 3 files changed, 2 insertions(+), 2 deletions(-)
>>>> rename hw/ide/{ahci_internal.h => ahci-internal.h} (100%)
>>>
>>> Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
>>
>> Was this also queued somewhere? I haven't seen it merged neither with the trivial nor the misc-hw pull requests.
>
> I figure John (our IDE odd fixer) wouldn't mind this going via
> qemu-trivial. Cc'ed!
I'll take it, thanks.
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2024-03-11 8:46 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-02-27 13:13 [PATCH] hw/ide/ahci: Rename ahci_internal.h to ahci-internal.h BALATON Zoltan
2024-02-27 13:38 ` Markus Armbruster
2024-02-27 14:06 ` Thomas Huth
2024-02-27 16:39 ` Philippe Mathieu-Daudé
2024-03-10 14:27 ` BALATON Zoltan
2024-03-11 7:05 ` Markus Armbruster
2024-03-11 8:45 ` Philippe Mathieu-Daudé
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).