From: Matheus Tavares Bernardino <quic_mathbern@quicinc.com>
To: Taylor Simpson <ltaylorsimpson@gmail.com>
Cc: <qemu-devel@nongnu.org>, <bcain@quicinc.com>,
<quic_mathbern@quicinc.com>, <sidneym@quicinc.com>,
<quic_mliebel@quicinc.com>, <richard.henderson@linaro.org>,
<philmd@linaro.org>, <ale@rev.ng>, <anjo@rev.ng>
Subject: Re: [PATCH 4/9] Hexagon (target/hexagon) Mark has_pred_dest in trans functions
Date: Tue, 27 Feb 2024 11:21:12 -0300 [thread overview]
Message-ID: <20240227142112.56005-1-quic_mathbern@quicinc.com> (raw)
In-Reply-To: <20240226201722.391879-5-ltaylorsimpson@gmail.com>
On Mon, 26 Feb 2024 13:17:17 -0700 Taylor Simpson <ltaylorsimpson@gmail.com> wrote:
>
> diff --git a/target/hexagon/gen_trans_funcs.py b/target/hexagon/gen_trans_funcs.py
> index 07292e0170..f1972fd2dd 100755
> --- a/target/hexagon/gen_trans_funcs.py
> +++ b/target/hexagon/gen_trans_funcs.py
> @@ -86,6 +86,7 @@ def gen_trans_funcs(f):
>
> new_read_idx = -1
> dest_idx = -1
> + has_pred_dest = "false"
> for regno, regstruct in enumerate(regs):
> reg_type, reg_id, _, _ = regstruct
> reg = hex_common.get_register(tag, reg_type, reg_id)
> @@ -96,6 +97,8 @@ def gen_trans_funcs(f):
> new_read_idx = regno
> if reg.is_written() and dest_idx == -1:
> dest_idx = regno
> + if reg_type == "P" and not reg.is_read():
> + has_pred_dest = "true"
I got a bit confused here. Why do we use "not reg.is_read()"? I though this
would be "reg.is_written()".
next prev parent reply other threads:[~2024-02-27 14:21 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-26 20:17 [PATCH 0/9] Hexagon (target/hexagon) Clean up .new decode and scripts Taylor Simpson
2024-02-26 20:17 ` [PATCH 1/9] Hexagon (target/hexagon) Add is_old/is_new to Register class Taylor Simpson
2024-02-29 11:04 ` Philippe Mathieu-Daudé
2024-02-26 20:17 ` [PATCH 2/9] Hexagon (target/hexagon) Mark new_read_idx in trans functions Taylor Simpson
2024-02-27 14:19 ` Matheus Tavares Bernardino
2024-02-27 15:50 ` ltaylorsimpson
2024-02-26 20:17 ` [PATCH 3/9] Hexagon (target/hexagon) Mark dest_idx " Taylor Simpson
2024-02-27 14:20 ` Matheus Tavares Bernardino
2024-02-26 20:17 ` [PATCH 4/9] Hexagon (target/hexagon) Mark has_pred_dest " Taylor Simpson
2024-02-27 14:21 ` Matheus Tavares Bernardino [this message]
2024-02-27 15:50 ` ltaylorsimpson
2024-02-26 20:17 ` [PATCH 5/9] Hexagon (tests/tcg/hexagon) Test HVX .new read from high half of pair Taylor Simpson
2024-02-26 20:17 ` [PATCH 6/9] Hexagon (target/hexagon) Remove uses of op_regs_generated.h.inc Taylor Simpson
2024-02-26 20:17 ` [PATCH 7/9] Hexagon (target/hexagon) Remove gen_op_regs.py Taylor Simpson
2024-02-26 20:17 ` [PATCH 8/9] Hexagon (target/hexagon) Remove gen_shortcode.py Taylor Simpson
2024-02-26 20:17 ` [PATCH 9/9] Hexagon (target/hexagon) Remove hex_common.read_attribs_file Taylor Simpson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240227142112.56005-1-quic_mathbern@quicinc.com \
--to=quic_mathbern@quicinc.com \
--cc=ale@rev.ng \
--cc=anjo@rev.ng \
--cc=bcain@quicinc.com \
--cc=ltaylorsimpson@gmail.com \
--cc=philmd@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=quic_mliebel@quicinc.com \
--cc=richard.henderson@linaro.org \
--cc=sidneym@quicinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).