qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Alex Bennée" <alex.bennee@linaro.org>
To: qemu-devel@nongnu.org
Cc: "Pierrick Bouvier" <pierrick.bouvier@linaro.org>,
	"Richard Henderson" <richard.henderson@linaro.org>,
	"Alex Bennée" <alex.bennee@linaro.org>,
	"Eduardo Habkost" <eduardo@habkost.net>,
	"Marcel Apfelbaum" <marcel.apfelbaum@gmail.com>,
	"Philippe Mathieu-Daudé" <philmd@linaro.org>,
	"Yanan Wang" <wangyanan55@huawei.com>
Subject: [PULL 19/29] cpu: call plugin init hook asynchronously
Date: Wed, 28 Feb 2024 11:56:51 +0000	[thread overview]
Message-ID: <20240228115701.1416107-20-alex.bennee@linaro.org> (raw)
In-Reply-To: <20240228115701.1416107-1-alex.bennee@linaro.org>

From: Pierrick Bouvier <pierrick.bouvier@linaro.org>

This ensures we run during a cpu_exec, which allows to call start/end
exclusive from this init hook (needed for new scoreboard API introduced
later).

async work is run before any tb is translated/executed, so we can
guarantee plugin init will be called before any other hook.

The previous change made sure that any idle/resume cb call will not be
done before initializing plugin for a given vcpu.

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Signed-off-by: Pierrick Bouvier <pierrick.bouvier@linaro.org>
Message-Id: <20240213094009.150349-5-pierrick.bouvier@linaro.org>
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Message-Id: <20240227144335.1196131-20-alex.bennee@linaro.org>

diff --git a/hw/core/cpu-common.c b/hw/core/cpu-common.c
index fe16d0d9df8..68786360ea5 100644
--- a/hw/core/cpu-common.c
+++ b/hw/core/cpu-common.c
@@ -194,6 +194,11 @@ static void cpu_common_parse_features(const char *typename, char *features,
     }
 }
 
+static void qemu_plugin_vcpu_init__async(CPUState *cpu, run_on_cpu_data unused)
+{
+    qemu_plugin_vcpu_init_hook(cpu);
+}
+
 static void cpu_common_realizefn(DeviceState *dev, Error **errp)
 {
     CPUState *cpu = CPU(dev);
@@ -217,9 +222,9 @@ static void cpu_common_realizefn(DeviceState *dev, Error **errp)
         cpu_resume(cpu);
     }
 
-    /* Plugin initialization must wait until the cpu is fully realized. */
+    /* Plugin initialization must wait until the cpu start executing code */
     if (tcg_enabled()) {
-        qemu_plugin_vcpu_init_hook(cpu);
+        async_run_on_cpu(cpu, qemu_plugin_vcpu_init__async, RUN_ON_CPU_NULL);
     }
 
     /* NOTE: latest generic point where the cpu is fully realized */
-- 
2.39.2



  parent reply	other threads:[~2024-02-28 12:06 UTC|newest]

Thread overview: 37+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-02-28 11:56 [PULL 00/29] testing, gdbstub and plugin updates Alex Bennée
2024-02-28 11:56 ` [PULL 01/29] tests/tcg: update licenses to GPLv2 as intended Alex Bennée
2024-02-28 11:56 ` [PULL 02/29] tests/tcg: bump TCG test timeout to 120s Alex Bennée
2024-02-28 11:56 ` [PULL 03/29] tests/vm: avoid re-building the VM images all the time Alex Bennée
2024-02-28 11:56 ` [PULL 04/29] tests/vm: update openbsd image to 7.4 Alex Bennée
2024-02-28 11:56 ` [PULL 05/29] target/arm: Use GDBFeature for dynamic XML Alex Bennée
2024-02-28 11:56 ` [PULL 06/29] target/ppc: " Alex Bennée
2024-02-28 11:56 ` [PULL 07/29] target/riscv: " Alex Bennée
2024-02-28 11:56 ` [PULL 08/29] gdbstub: Use GDBFeature for gdb_register_coprocessor Alex Bennée
2024-02-28 11:56 ` [PULL 09/29] gdbstub: Use GDBFeature for GDBRegisterState Alex Bennée
2024-02-28 11:56 ` [PULL 10/29] gdbstub: Change gdb_get_reg_cb and gdb_set_reg_cb Alex Bennée
2024-02-28 11:56 ` [PULL 11/29] gdbstub: Simplify XML lookup Alex Bennée
2024-02-28 11:56 ` [PULL 12/29] gdbstub: Infer number of core registers from XML Alex Bennée
2024-02-28 11:56 ` [PULL 13/29] hw/core/cpu: Remove gdb_get_dynamic_xml member Alex Bennée
2024-02-28 11:56 ` [PULL 14/29] gdbstub: Add members to identify registers to GDBFeature Alex Bennée
2024-02-28 11:56 ` [PULL 15/29] plugins: remove previous n_vcpus functions from API Alex Bennée
2024-02-28 11:56 ` [PULL 16/29] plugins: add qemu_plugin_num_vcpus function Alex Bennée
2024-02-28 11:56 ` [PULL 17/29] plugins: fix order of init/idle/resume callback Alex Bennée
2024-02-28 11:56 ` [PULL 18/29] linux-user: ensure nios2 processes queued work Alex Bennée
2024-02-28 11:56 ` Alex Bennée [this message]
2024-02-28 11:56 ` [PULL 20/29] plugins: Use different helpers when reading registers Alex Bennée
2024-02-28 11:56 ` [PULL 21/29] gdbstub: expose api to find registers Alex Bennée
2024-02-28 11:56 ` [PULL 22/29] plugins: create CPUPluginState and migrate plugin_mask Alex Bennée
2024-02-28 11:56 ` [PULL 23/29] plugins: add an API to read registers Alex Bennée
2024-02-28 11:56 ` [PULL 24/29] tests/tcg: expand insn test case to exercise register API Alex Bennée
2024-02-28 11:56 ` [PULL 25/29] contrib/plugins: fix imatch Alex Bennée
2024-02-28 11:56 ` [PULL 26/29] contrib/plugins: extend execlog to track register changes Alex Bennée
2024-03-01  7:19   ` Zhao Liu
2024-03-01 10:22     ` Alex Bennée
2024-03-01 15:54       ` Zhao Liu
2024-03-01 16:30         ` Alex Bennée
2024-03-02  7:02           ` Zhao Liu
2024-03-08 13:21   ` Peter Maydell
2024-02-28 11:56 ` [PULL 27/29] docs/devel: lift example and plugin API sections up Alex Bennée
2024-02-28 11:57 ` [PULL 28/29] docs/devel: document some plugin assumptions Alex Bennée
2024-02-28 11:57 ` [PULL 29/29] docs/devel: plugins can trigger a tb flush Alex Bennée
2024-02-28 17:26 ` [PULL 00/29] testing, gdbstub and plugin updates Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240228115701.1416107-20-alex.bennee@linaro.org \
    --to=alex.bennee@linaro.org \
    --cc=eduardo@habkost.net \
    --cc=marcel.apfelbaum@gmail.com \
    --cc=philmd@linaro.org \
    --cc=pierrick.bouvier@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=richard.henderson@linaro.org \
    --cc=wangyanan55@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).