From: Jonathan Cameron via <qemu-devel@nongnu.org>
To: Ankit Agrawal <ankita@nvidia.com>
Cc: Jason Gunthorpe <jgg@nvidia.com>,
"alex.williamson@redhat.com" <alex.williamson@redhat.com>,
"clg@redhat.com" <clg@redhat.com>,
"shannon.zhaosl@gmail.com" <shannon.zhaosl@gmail.com>,
"peter.maydell@linaro.org" <peter.maydell@linaro.org>,
"ani@anisinha.ca" <ani@anisinha.ca>,
"berrange@redhat.com" <berrange@redhat.com>,
"eduardo@habkost.net" <eduardo@habkost.net>,
"imammedo@redhat.com" <imammedo@redhat.com>,
"mst@redhat.com" <mst@redhat.com>,
"eblake@redhat.com" <eblake@redhat.com>,
"armbru@redhat.com" <armbru@redhat.com>,
"david@redhat.com" <david@redhat.com>,
"gshan@redhat.com" <gshan@redhat.com>,
Zhi Wang <zhiw@nvidia.com>, "Matt Ochs" <mochs@nvidia.com>,
"pbonzini@redhat.com" <pbonzini@redhat.com>,
Aniket Agashe <aniketa@nvidia.com>, Neo Jia <cjia@nvidia.com>,
"Kirti Wankhede" <kwankhede@nvidia.com>,
"Tarun Gupta (SW-GPU)" <targupta@nvidia.com>,
Vikram Sethi <vsethi@nvidia.com>,
Andy Currid <acurrid@nvidia.com>,
Dheeraj Nigam <dnigam@nvidia.com>, Uday Dhoke <udhoke@nvidia.com>,
"qemu-arm@nongnu.org" <qemu-arm@nongnu.org>,
"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>
Subject: Re: [PATCH v7 2/2] hw/acpi: Implement the SRAT GI affinity structure
Date: Thu, 29 Feb 2024 12:20:23 +0000 [thread overview]
Message-ID: <20240229122023.0000407e@Huawei.com> (raw)
In-Reply-To: <SA1PR12MB719937D09D2DE7C2ABBF78E8B05F2@SA1PR12MB7199.namprd12.prod.outlook.com>
On Thu, 29 Feb 2024 11:46:27 +0000
Ankit Agrawal <ankita@nvidia.com> wrote:
> >> ---
> >> hw/acpi/acpi-generic-initiator.c | 84 ++++++++++++++++++++++++
> >> hw/arm/virt-acpi-build.c | 3 +
> >> include/hw/acpi/acpi-generic-initiator.h | 26 ++++++++
> > A few more comments.
> >
> > Maybe _ rather than - as more common for acpi include naming.
>
> Ack. will change the name.
>
> > I also wonder if we need the acpi prefix for file names given context?
>
> I tried to keep it to match the object name. If you have preference for
> not having it, I can change that too.
Not my area, so up to maintainers of hw/acpi to comment if they care!
I'd not wait for that though before v8.
*impatient user who has some other stuff queued on top of this!*
:)
Jonathan
prev parent reply other threads:[~2024-02-29 12:20 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-23 12:42 [PATCH v7 0/2] acpi: report numa nodes for device memory using GI ankita
2024-02-23 12:42 ` [PATCH v7 1/2] qom: new object to associate device to numa node ankita
2024-02-27 13:00 ` Jonathan Cameron via
2024-02-28 5:35 ` Ankit Agrawal
2024-02-28 7:35 ` Markus Armbruster
2024-02-28 13:55 ` Jonathan Cameron via
2024-02-28 16:08 ` Markus Armbruster
2024-02-28 16:50 ` Ankit Agrawal
2024-02-29 10:22 ` Jonathan Cameron via
2024-02-29 13:00 ` Ankit Agrawal
2024-02-29 16:32 ` Jonathan Cameron via
2024-03-01 8:33 ` Ankit Agrawal
2024-03-01 16:13 ` Alex Williamson
2024-02-23 12:42 ` [PATCH v7 2/2] hw/acpi: Implement the SRAT GI affinity structure ankita
2024-02-26 16:34 ` Jonathan Cameron via
2024-02-26 16:42 ` Jonathan Cameron via
2024-02-27 8:37 ` Ankit Agrawal
2024-02-27 17:11 ` Jonathan Cameron via
2024-02-27 17:36 ` Jonathan Cameron via
2024-02-29 15:59 ` Jonathan Cameron via
2024-03-01 8:30 ` Ankit Agrawal
2024-02-29 11:43 ` Ankit Agrawal
2024-02-29 12:17 ` Jonathan Cameron via
2024-02-29 12:24 ` Ankit Agrawal
2024-03-05 5:59 ` Ankit Agrawal
2024-03-05 7:11 ` Cédric Le Goater
2024-03-05 8:17 ` Ankit Agrawal
2024-03-05 10:38 ` Jonathan Cameron via
2024-03-06 10:33 ` Ankit Agrawal
2024-03-06 11:46 ` Jonathan Cameron via
2024-03-05 21:06 ` Alex Williamson
2024-03-06 10:36 ` Ankit Agrawal
2024-03-06 9:12 ` Jonathan Cameron via
2024-03-06 10:41 ` Ankit Agrawal
2024-02-27 12:53 ` Jonathan Cameron via
2024-02-29 11:46 ` Ankit Agrawal
2024-02-29 12:20 ` Jonathan Cameron via [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240229122023.0000407e@Huawei.com \
--to=qemu-devel@nongnu.org \
--cc=Jonathan.Cameron@Huawei.com \
--cc=acurrid@nvidia.com \
--cc=alex.williamson@redhat.com \
--cc=ani@anisinha.ca \
--cc=aniketa@nvidia.com \
--cc=ankita@nvidia.com \
--cc=armbru@redhat.com \
--cc=berrange@redhat.com \
--cc=cjia@nvidia.com \
--cc=clg@redhat.com \
--cc=david@redhat.com \
--cc=dnigam@nvidia.com \
--cc=eblake@redhat.com \
--cc=eduardo@habkost.net \
--cc=gshan@redhat.com \
--cc=imammedo@redhat.com \
--cc=jgg@nvidia.com \
--cc=kwankhede@nvidia.com \
--cc=mochs@nvidia.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=shannon.zhaosl@gmail.com \
--cc=targupta@nvidia.com \
--cc=udhoke@nvidia.com \
--cc=vsethi@nvidia.com \
--cc=zhiw@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).