qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Thomas Huth <thuth@redhat.com>
To: qemu-devel@nongnu.org
Cc: Peter Maydell <peter.maydell@linaro.org>,
	Fabiano Rosas <farosas@suse.de>
Subject: [PULL 3/6] hw/intc/Kconfig: Fix GIC settings when using "--without-default-devices"
Date: Fri,  1 Mar 2024 09:09:50 +0100	[thread overview]
Message-ID: <20240301080953.66448-4-thuth@redhat.com> (raw)
In-Reply-To: <20240301080953.66448-1-thuth@redhat.com>

When using "--without-default-devices", the ARM_GICV3_TCG and ARM_GIC_KVM
settings currently get disabled, though the arm virt machine is only of
very limited use in that case. This also causes the migration-test to
fail in such builds. Let's make sure that we always keep the GIC switches
enabled in the --without-default-devices builds, too.

Message-ID: <20240221110059.152665-1-thuth@redhat.com>
Tested-by: Fabiano Rosas <farosas@suse.de>
Signed-off-by: Thomas Huth <thuth@redhat.com>
---
 hw/intc/Kconfig | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/hw/intc/Kconfig b/hw/intc/Kconfig
index 97d550b06b..2b5b2d2301 100644
--- a/hw/intc/Kconfig
+++ b/hw/intc/Kconfig
@@ -12,10 +12,6 @@ config IOAPIC
     bool
     select I8259
 
-config ARM_GIC
-    bool
-    select MSI_NONBROKEN
-
 config OPENPIC
     bool
     select MSI_NONBROKEN
@@ -25,14 +21,18 @@ config APIC
     select MSI_NONBROKEN
     select I8259
 
+config ARM_GIC
+    bool
+    select ARM_GICV3_TCG if TCG
+    select ARM_GIC_KVM if KVM
+    select MSI_NONBROKEN
+
 config ARM_GICV3_TCG
     bool
-    default y
     depends on ARM_GIC && TCG
 
 config ARM_GIC_KVM
     bool
-    default y
     depends on ARM_GIC && KVM
 
 config XICS
-- 
2.44.0



  parent reply	other threads:[~2024-03-01  8:11 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-01  8:09 [PULL 0/6] Misc fixes (libqos vring, Kconfig, TLS io channels, ...) Thomas Huth
2024-03-01  8:09 ` [PULL 1/6] libqos/virtio.c: init all elems in qvring_indirect_desc_setup() Thomas Huth
2024-03-01  8:09 ` [PULL 2/6] libqos/virtio.c: fix 'avail_event' offset in qvring_init() Thomas Huth
2024-03-01  8:09 ` Thomas Huth [this message]
2024-03-01  8:09 ` [PULL 4/6] hw/usb/bus.c: PCAP adding 0xA in Windows version Thomas Huth
2024-03-01  8:09 ` [PULL 5/6] tests/unit/test-util-sockets: Remove temporary file after test Thomas Huth
2024-03-01  8:09 ` [PULL 6/6] chardev/char-socket: Fix TLS io channels sending too much data to the backend Thomas Huth
2024-03-01 14:39 ` [PULL 0/6] Misc fixes (libqos vring, Kconfig, TLS io channels, ...) Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240301080953.66448-4-thuth@redhat.com \
    --to=thuth@redhat.com \
    --cc=farosas@suse.de \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).