* [PATCH] replay: Improve error messages about configuration conflicts
@ 2024-03-01 12:06 Markus Armbruster
2024-03-01 15:47 ` [Spam][PATCH] " Pavel Dovgalyuk
2024-03-01 15:55 ` [PATCH] " Philippe Mathieu-Daudé
0 siblings, 2 replies; 3+ messages in thread
From: Markus Armbruster @ 2024-03-01 12:06 UTC (permalink / raw)
To: qemu-devel; +Cc: pavel.dovgaluk, pbonzini, qemu-trivial
Improve
Record/replay feature is not supported for '-rtc base=localtime'
Record/replay feature is not supported for 'smp'
Record/replay feature is not supported for '-snapshot'
to
Record/replay is not supported with -rtc base=localtime
Record/replay is not supported with multiple CPUs
Record/replay is not supported with -snapshot
Signed-off-by: Markus Armbruster <armbru@redhat.com>
---
replay/replay.c | 2 +-
system/vl.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/replay/replay.c b/replay/replay.c
index 3fd241a4fc..a2c576c16e 100644
--- a/replay/replay.c
+++ b/replay/replay.c
@@ -511,7 +511,7 @@ void replay_add_blocker(const char *feature)
{
Error *reason = NULL;
- error_setg(&reason, "Record/replay feature is not supported for '%s'",
+ error_setg(&reason, "Record/replay is not supported with %s",
feature);
replay_blockers = g_slist_prepend(replay_blockers, reason);
}
diff --git a/system/vl.c b/system/vl.c
index e480afd7a0..cc03a17c09 100644
--- a/system/vl.c
+++ b/system/vl.c
@@ -1932,7 +1932,7 @@ static void qemu_apply_machine_options(QDict *qdict)
}
if (current_machine->smp.cpus > 1) {
- replay_add_blocker("smp");
+ replay_add_blocker("multiple CPUs");
}
}
--
2.43.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [Spam][PATCH] replay: Improve error messages about configuration conflicts
2024-03-01 12:06 [PATCH] replay: Improve error messages about configuration conflicts Markus Armbruster
@ 2024-03-01 15:47 ` Pavel Dovgalyuk
2024-03-01 15:55 ` [PATCH] " Philippe Mathieu-Daudé
1 sibling, 0 replies; 3+ messages in thread
From: Pavel Dovgalyuk @ 2024-03-01 15:47 UTC (permalink / raw)
To: Markus Armbruster, qemu-devel; +Cc: pbonzini, qemu-trivial
Reviewed-by: Pavel Dovgalyuk <Pavel.Dovgalyuk@ispras.ru>
On 01.03.2024 15:06, Markus Armbruster wrote:
> Improve
>
> Record/replay feature is not supported for '-rtc base=localtime'
> Record/replay feature is not supported for 'smp'
> Record/replay feature is not supported for '-snapshot'
>
> to
>
> Record/replay is not supported with -rtc base=localtime
> Record/replay is not supported with multiple CPUs
> Record/replay is not supported with -snapshot
>
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
> ---
> replay/replay.c | 2 +-
> system/vl.c | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/replay/replay.c b/replay/replay.c
> index 3fd241a4fc..a2c576c16e 100644
> --- a/replay/replay.c
> +++ b/replay/replay.c
> @@ -511,7 +511,7 @@ void replay_add_blocker(const char *feature)
> {
> Error *reason = NULL;
>
> - error_setg(&reason, "Record/replay feature is not supported for '%s'",
> + error_setg(&reason, "Record/replay is not supported with %s",
> feature);
> replay_blockers = g_slist_prepend(replay_blockers, reason);
> }
> diff --git a/system/vl.c b/system/vl.c
> index e480afd7a0..cc03a17c09 100644
> --- a/system/vl.c
> +++ b/system/vl.c
> @@ -1932,7 +1932,7 @@ static void qemu_apply_machine_options(QDict *qdict)
> }
>
> if (current_machine->smp.cpus > 1) {
> - replay_add_blocker("smp");
> + replay_add_blocker("multiple CPUs");
> }
> }
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] replay: Improve error messages about configuration conflicts
2024-03-01 12:06 [PATCH] replay: Improve error messages about configuration conflicts Markus Armbruster
2024-03-01 15:47 ` [Spam][PATCH] " Pavel Dovgalyuk
@ 2024-03-01 15:55 ` Philippe Mathieu-Daudé
1 sibling, 0 replies; 3+ messages in thread
From: Philippe Mathieu-Daudé @ 2024-03-01 15:55 UTC (permalink / raw)
To: Markus Armbruster, qemu-devel; +Cc: pavel.dovgaluk, pbonzini, qemu-trivial
On 1/3/24 13:06, Markus Armbruster wrote:
> Improve
>
> Record/replay feature is not supported for '-rtc base=localtime'
> Record/replay feature is not supported for 'smp'
> Record/replay feature is not supported for '-snapshot'
>
> to
>
> Record/replay is not supported with -rtc base=localtime
> Record/replay is not supported with multiple CPUs
> Record/replay is not supported with -snapshot
>
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
> ---
> replay/replay.c | 2 +-
> system/vl.c | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-03-01 15:56 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-03-01 12:06 [PATCH] replay: Improve error messages about configuration conflicts Markus Armbruster
2024-03-01 15:47 ` [Spam][PATCH] " Pavel Dovgalyuk
2024-03-01 15:55 ` [PATCH] " Philippe Mathieu-Daudé
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).