* [RFC PATCH] tests: bump QOS_PATH_MAX_ELEMENT_SIZE again
@ 2024-03-04 19:37 Alex Bennée
2024-03-05 5:55 ` Thomas Huth
2024-03-05 10:02 ` Paolo Bonzini
0 siblings, 2 replies; 3+ messages in thread
From: Alex Bennée @ 2024-03-04 19:37 UTC (permalink / raw)
To: qemu-devel; +Cc: Alex Bennée, Thomas Huth, Laurent Vivier, Paolo Bonzini
We "fixed" a bug with LTO builds with 100c459f194 (tests/qtest: bump
up QOS_PATH_MAX_ELEMENT_SIZE) but it seems it has triggered again.
Lets be more assertive raising QOS_PATH_MAX_ELEMENT_SIZE to make it go
away again.
Resolves: https://gitlab.com/qemu-project/qemu/-/issues/1186 (again)
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
---
tests/qtest/libqos/qgraph.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/qtest/libqos/qgraph.h b/tests/qtest/libqos/qgraph.h
index 287022a67c1..1b5de02e7be 100644
--- a/tests/qtest/libqos/qgraph.h
+++ b/tests/qtest/libqos/qgraph.h
@@ -24,7 +24,7 @@
#include "libqos-malloc.h"
/* maximum path length */
-#define QOS_PATH_MAX_ELEMENT_SIZE 64
+#define QOS_PATH_MAX_ELEMENT_SIZE 128
typedef struct QOSGraphObject QOSGraphObject;
typedef struct QOSGraphNode QOSGraphNode;
--
2.39.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [RFC PATCH] tests: bump QOS_PATH_MAX_ELEMENT_SIZE again
2024-03-04 19:37 [RFC PATCH] tests: bump QOS_PATH_MAX_ELEMENT_SIZE again Alex Bennée
@ 2024-03-05 5:55 ` Thomas Huth
2024-03-05 10:02 ` Paolo Bonzini
1 sibling, 0 replies; 3+ messages in thread
From: Thomas Huth @ 2024-03-05 5:55 UTC (permalink / raw)
To: Alex Bennée, qemu-devel; +Cc: Laurent Vivier, Paolo Bonzini
On 04/03/2024 20.37, Alex Bennée wrote:
> We "fixed" a bug with LTO builds with 100c459f194 (tests/qtest: bump
> up QOS_PATH_MAX_ELEMENT_SIZE) but it seems it has triggered again.
> Lets be more assertive raising QOS_PATH_MAX_ELEMENT_SIZE to make it go
> away again.
>
> Resolves: https://gitlab.com/qemu-project/qemu/-/issues/1186 (again)
> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
> ---
> tests/qtest/libqos/qgraph.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/qtest/libqos/qgraph.h b/tests/qtest/libqos/qgraph.h
> index 287022a67c1..1b5de02e7be 100644
> --- a/tests/qtest/libqos/qgraph.h
> +++ b/tests/qtest/libqos/qgraph.h
> @@ -24,7 +24,7 @@
> #include "libqos-malloc.h"
>
> /* maximum path length */
> -#define QOS_PATH_MAX_ELEMENT_SIZE 64
> +#define QOS_PATH_MAX_ELEMENT_SIZE 128
Reviewed-by: Thomas Huth <thuth@redhat.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [RFC PATCH] tests: bump QOS_PATH_MAX_ELEMENT_SIZE again
2024-03-04 19:37 [RFC PATCH] tests: bump QOS_PATH_MAX_ELEMENT_SIZE again Alex Bennée
2024-03-05 5:55 ` Thomas Huth
@ 2024-03-05 10:02 ` Paolo Bonzini
1 sibling, 0 replies; 3+ messages in thread
From: Paolo Bonzini @ 2024-03-05 10:02 UTC (permalink / raw)
To: Alex Bennée; +Cc: qemu-devel, Thomas Huth, Laurent Vivier
On Mon, Mar 4, 2024 at 10:06 PM Alex Bennée <alex.bennee@linaro.org> wrote:
>
> We "fixed" a bug with LTO builds with 100c459f194 (tests/qtest: bump
> up QOS_PATH_MAX_ELEMENT_SIZE) but it seems it has triggered again.
> Lets be more assertive raising QOS_PATH_MAX_ELEMENT_SIZE to make it go
> away again.
>
> Resolves: https://gitlab.com/qemu-project/qemu/-/issues/1186 (again)
> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
The array is sized according to the maximum anticipated length of a
path on the graph. However, the worst case for a depth-first search is
to push all nodes on the graph. So it's not really LTO, it depends on
the ordering of the constructors.
I had a patch to implement the stack as a linked list, but I never
sent it because IIRC it caused failures that I never had time to
debug. This patch is okay as long as this information is included in
the commit message and/or code.
Paolo
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-03-05 10:03 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-03-04 19:37 [RFC PATCH] tests: bump QOS_PATH_MAX_ELEMENT_SIZE again Alex Bennée
2024-03-05 5:55 ` Thomas Huth
2024-03-05 10:02 ` Paolo Bonzini
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).