From: nifan.cxl@gmail.com
To: qemu-devel@nongnu.org
Cc: jonathan.cameron@huawei.com, linux-cxl@vger.kernel.org,
gregory.price@memverge.com, ira.weiny@intel.com,
dan.j.williams@intel.com, a.manzanares@samsung.com,
dave@stgolabs.net, nmtadam.samsung@gmail.com,
nifan.cxl@gmail.com, jim.harris@samsung.com,
Jorgen.Hansen@wdc.com, wj28.lee@gmail.com,
Fan Ni <fan.ni@samsung.com>
Subject: [PATCH v5 13/13] qapi/cxl.json: Add QMP interfaces to print out accepted and pending DC extents
Date: Mon, 4 Mar 2024 11:34:08 -0800 [thread overview]
Message-ID: <20240304194331.1586191-14-nifan.cxl@gmail.com> (raw)
In-Reply-To: <20240304194331.1586191-1-nifan.cxl@gmail.com>
From: Fan Ni <fan.ni@samsung.com>
With the change, we add the following two QMP interfaces to print out
extents information in the device,
1. cxl-display-accepted-dc-extents: print out the accepted DC extents in
the device;
2. cxl-display-pending-to-add-dc-extents: print out the pending-to-add
DC extents in the device;
The output is appended to a file passed to the command and by default
it is /tmp/dc-extent.txt.
Signed-off-by: Fan Ni <fan.ni@samsung.com>
---
hw/mem/cxl_type3.c | 80 ++++++++++++++++++++++++++++++++++++++++
hw/mem/cxl_type3_stubs.c | 12 ++++++
qapi/cxl.json | 32 ++++++++++++++++
3 files changed, 124 insertions(+)
diff --git a/hw/mem/cxl_type3.c b/hw/mem/cxl_type3.c
index 5bd64e604e..6a08e7ae40 100644
--- a/hw/mem/cxl_type3.c
+++ b/hw/mem/cxl_type3.c
@@ -2089,6 +2089,86 @@ void qmp_cxl_release_dynamic_capacity(const char *path, uint8_t region_id,
region_id, records, errp);
}
+static void cxl_dcd_display_extent_list(const CXLType3Dev *dcd, const char *f,
+ bool accepted_list, Error **errp)
+{
+ const CXLDCExtentList *list;
+ CXLDCExtent *ent;
+ FILE *fp = NULL;
+ int i = 0;
+
+ if (!dcd->dc.num_regions) {
+ error_setg(errp, "No dynamic capacity support from the device");
+ return;
+ }
+
+ if (!f) {
+ fp = fopen("/tmp/dc-extent.txt", "a+");
+ } else {
+ fp = fopen(f, "a+");
+ }
+
+ if (!fp) {
+ error_setg(errp, "Open log file failed");
+ return;
+ }
+ if (accepted_list) {
+ list = &dcd->dc.extents;
+ fprintf(fp, "Print accepted extent info:\n");
+ } else {
+ list = &dcd->dc.extents_pending_to_add;
+ fprintf(fp, "Print pending-to-add extent info:\n");
+ }
+
+ QTAILQ_FOREACH(ent, list, node) {
+ fprintf(fp, "%d: [0x%lx - 0x%lx]\n", i++, ent->start_dpa,
+ ent->start_dpa + ent->len);
+ }
+ fprintf(fp, "In total, %d extents printed!\n", i);
+ fclose(fp);
+}
+
+void qmp_cxl_display_accepted_dc_extents(const char *path, const char *f,
+ Error **errp)
+{
+ Object *obj;
+ CXLType3Dev *dcd;
+
+ obj = object_resolve_path(path, NULL);
+ if (!obj) {
+ error_setg(errp, "Unable to resolve path");
+ return;
+ }
+ if (!object_dynamic_cast(obj, TYPE_CXL_TYPE3)) {
+ error_setg(errp, "Path not point to a valid CXL type3 device");
+ return;
+ }
+
+ dcd = CXL_TYPE3(obj);
+ cxl_dcd_display_extent_list(dcd, f, true, errp);
+}
+
+void qmp_cxl_display_pending_to_add_dc_extents(const char *path, const char *f,
+ Error **errp)
+{
+ Object *obj;
+ CXLType3Dev *dcd;
+
+ obj = object_resolve_path(path, NULL);
+ if (!obj) {
+ error_setg(errp, "Unable to resolve path");
+ return;
+ }
+ if (!object_dynamic_cast(obj, TYPE_CXL_TYPE3)) {
+ error_setg(errp, "Path not point to a valid CXL type3 device");
+ return;
+ }
+
+
+ dcd = CXL_TYPE3(obj);
+ cxl_dcd_display_extent_list(dcd, f, false, errp);
+}
+
static void ct3_class_init(ObjectClass *oc, void *data)
{
DeviceClass *dc = DEVICE_CLASS(oc);
diff --git a/hw/mem/cxl_type3_stubs.c b/hw/mem/cxl_type3_stubs.c
index d913b11b4d..d896758301 100644
--- a/hw/mem/cxl_type3_stubs.c
+++ b/hw/mem/cxl_type3_stubs.c
@@ -81,3 +81,15 @@ void qmp_cxl_release_dynamic_capacity(const char *path, uint8_t region_id,
{
error_setg(errp, "CXL Type 3 support is not compiled in");
}
+
+void qmp_cxl_display_accepted_dc_extents(const char *path, const char *f,
+ Error **errp)
+{
+ error_setg(errp, "CXL Type 3 support is not compiled in");
+}
+
+void qmp_cxl_display_pending_to_add_dc_extents(const char *path, const char *f,
+ Error **errp)
+{
+ error_setg(errp, "CXL Type 3 support is not compiled in");
+}
diff --git a/qapi/cxl.json b/qapi/cxl.json
index 2645004666..6f10300ec6 100644
--- a/qapi/cxl.json
+++ b/qapi/cxl.json
@@ -420,3 +420,35 @@
'extents': [ 'CXLDCExtentRecord' ]
}
}
+
+##
+# @cxl-display-accepted-dc-extents:
+#
+# Command to print out all the accepted DC extents in the device
+#
+# @path: CXL DCD canonical QOM path
+# @output: path of output file to dump the results to
+#
+# Since : 9.0
+##
+{ 'command': 'cxl-display-accepted-dc-extents',
+ 'data': { 'path': 'str',
+ 'output': 'str'
+ }
+}
+
+##
+# @cxl-display-pending-to-add-dc-extents:
+#
+# Command to print out all the pending-to-add DC extents in the device
+#
+# @path: CXL DCD canonical QOM path
+# @output: path of output file to dump the results to
+#
+# Since : 9.0
+##
+{ 'command': 'cxl-display-pending-to-add-dc-extents',
+ 'data': { 'path': 'str',
+ 'output': 'str'
+ }
+}
--
2.43.0
next prev parent reply other threads:[~2024-03-04 19:45 UTC|newest]
Thread overview: 59+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-04 19:33 [PATCH v5 00/13] Enabling DCD emulation support in Qemu nifan.cxl
2024-03-04 19:33 ` [PATCH v5 01/13] hw/cxl/cxl-mailbox-utils: Add dc_event_log_size field to output payload of identify memory device command nifan.cxl
2024-03-06 15:07 ` Jonathan Cameron via
2024-03-04 19:33 ` [PATCH v5 02/13] hw/cxl/cxl-mailbox-utils: Add dynamic capacity region representative and mailbox command support nifan.cxl
2024-03-06 15:24 ` Jonathan Cameron via
2024-03-04 19:33 ` [PATCH v5 03/13] include/hw/cxl/cxl_device: Rename mem_size as static_mem_size for type3 memory devices nifan.cxl
2024-03-06 15:39 ` Jonathan Cameron via
2024-03-04 19:33 ` [PATCH v5 04/13] hw/mem/cxl_type3: Add support to create DC regions to " nifan.cxl
2024-03-06 15:48 ` Jonathan Cameron via
2024-03-04 19:34 ` [PATCH v5 05/13] hw/mem/cxl-type3: Refactor ct3_build_cdat_entries_for_mr to take mr size insead of mr as argument nifan.cxl
2024-03-06 16:02 ` Jonathan Cameron via
2024-03-06 16:03 ` Jonathan Cameron via
2024-03-04 19:34 ` [PATCH v5 06/13] hw/mem/cxl_type3: Add host backend and address space handling for DC regions nifan.cxl
2024-03-06 16:28 ` Jonathan Cameron via
2024-03-06 19:14 ` fan
2024-03-07 12:16 ` Jonathan Cameron via
2024-03-07 23:34 ` fan
2024-03-14 20:43 ` fan
2024-03-04 19:34 ` [PATCH v5 07/13] hw/mem/cxl_type3: Add DC extent list representative and get DC extent list mailbox support nifan.cxl
2024-03-06 16:37 ` Jonathan Cameron via
2024-03-04 19:34 ` [PATCH v5 08/13] hw/cxl/cxl-mailbox-utils: Add mailbox commands to support add/release dynamic capacity response nifan.cxl
2024-03-06 17:28 ` Jonathan Cameron via
2024-03-06 21:39 ` fan
2024-03-07 12:20 ` Jonathan Cameron via
2024-03-06 22:34 ` fan
2024-03-07 12:30 ` Jonathan Cameron via
2024-03-04 19:34 ` [PATCH v5 09/13] hw/cxl/events: Add qmp interfaces to add/release dynamic capacity extents nifan.cxl
2024-03-06 17:48 ` Jonathan Cameron via
2024-03-06 23:15 ` fan
2024-03-07 12:45 ` Jonathan Cameron via
2024-03-09 4:35 ` fan
2024-03-12 12:37 ` Jonathan Cameron via
2024-03-12 16:27 ` fan
2024-03-06 23:36 ` fan
2024-03-07 12:47 ` Jonathan Cameron via
2024-04-24 13:09 ` Markus Armbruster
2024-04-24 17:10 ` fan
2024-04-24 17:26 ` Markus Armbruster
2024-04-24 17:44 ` fan
2024-04-24 17:33 ` Ira Weiny
2024-04-26 15:55 ` Jonathan Cameron via
2024-04-26 16:22 ` Gregory Price
2024-04-24 17:39 ` fan
2024-04-25 5:48 ` Markus Armbruster
2024-04-25 17:30 ` Ira Weiny
2024-04-26 16:00 ` Jonathan Cameron via
2024-03-04 19:34 ` [PATCH v5 10/13] hw/mem/cxl_type3: Add dpa range validation for accesses to DC regions nifan.cxl
2024-03-06 17:50 ` Jonathan Cameron via
2024-03-04 19:34 ` [PATCH v5 11/13] hw/cxl/cxl-mailbox-utils: Add partial and superset extent release mailbox support nifan.cxl
2024-03-06 18:09 ` Jonathan Cameron via
2024-03-04 19:34 ` [PATCH v5 12/13] hw/mem/cxl_type3: Allow to release partial extent and extent superset in QMP interface nifan.cxl
2024-03-06 18:14 ` Jonathan Cameron via
2024-03-04 19:34 ` nifan.cxl [this message]
2024-03-05 16:09 ` [PATCH v5 13/13] qapi/cxl.json: Add QMP interfaces to print out accepted and pending DC extents Jonathan Cameron via
2024-03-05 16:15 ` Daniel P. Berrangé
2024-03-05 17:09 ` fan
2024-03-05 17:14 ` Daniel P. Berrangé
2024-04-24 13:12 ` Markus Armbruster
2024-04-24 17:12 ` fan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240304194331.1586191-14-nifan.cxl@gmail.com \
--to=nifan.cxl@gmail.com \
--cc=Jorgen.Hansen@wdc.com \
--cc=a.manzanares@samsung.com \
--cc=dan.j.williams@intel.com \
--cc=dave@stgolabs.net \
--cc=fan.ni@samsung.com \
--cc=gregory.price@memverge.com \
--cc=ira.weiny@intel.com \
--cc=jim.harris@samsung.com \
--cc=jonathan.cameron@huawei.com \
--cc=linux-cxl@vger.kernel.org \
--cc=nmtadam.samsung@gmail.com \
--cc=qemu-devel@nongnu.org \
--cc=wj28.lee@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).