qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Akihiko Odaki <akihiko.odaki@daynix.com>
To: Viktor Prutyanov <viktor.prutyanov@phystech.edu>,
	 Peter Maydell <peter.maydell@linaro.org>
Cc: qemu-devel@nongnu.org, Akihiko Odaki <akihiko.odaki@daynix.com>
Subject: [PATCH v2 07/13] contrib/elf2dmp: Ensure segment fits in file
Date: Tue, 05 Mar 2024 16:36:24 +0900	[thread overview]
Message-ID: <20240305-elf2dmp-v2-7-86ff2163ad32@daynix.com> (raw)
In-Reply-To: <20240305-elf2dmp-v2-0-86ff2163ad32@daynix.com>

This makes elf2dmp more robust against corrupted inputs.

Signed-off-by: Akihiko Odaki <akihiko.odaki@daynix.com>
---
 contrib/elf2dmp/addrspace.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/contrib/elf2dmp/addrspace.c b/contrib/elf2dmp/addrspace.c
index e01860d15b07..81295a11534a 100644
--- a/contrib/elf2dmp/addrspace.c
+++ b/contrib/elf2dmp/addrspace.c
@@ -88,11 +88,12 @@ void pa_space_create(struct pa_space *ps, QEMU_Elf *qemu_elf)
     ps->block = g_new(struct pa_block, ps->block_nr);
 
     for (i = 0; i < phdr_nr; i++) {
-        if (phdr[i].p_type == PT_LOAD) {
+        if (phdr[i].p_type == PT_LOAD && phdr[i].p_offset < qemu_elf->size) {
             ps->block[block_i] = (struct pa_block) {
                 .addr = (uint8_t *)qemu_elf->map + phdr[i].p_offset,
                 .paddr = phdr[i].p_paddr,
-                .size = phdr[i].p_filesz,
+                .size = MIN(phdr[i].p_filesz,
+                            qemu_elf->size - phdr[i].p_offset),
             };
             pa_block_align(&ps->block[block_i]);
             block_i = ps->block[block_i].size ? (block_i + 1) : block_i;

-- 
2.44.0



  parent reply	other threads:[~2024-03-05  7:38 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-05  7:36 [PATCH v2 00/13] contrib/elf2dmp: Improve robustness Akihiko Odaki
2024-03-05  7:36 ` [PATCH v2 01/13] contrib/elf2dmp: Remove unnecessary err flags Akihiko Odaki
2024-03-05 13:24   ` Peter Maydell
2024-03-05  7:36 ` [PATCH v2 02/13] contrib/elf2dmp: Assume error by default Akihiko Odaki
2024-03-05 13:24   ` Peter Maydell
2024-03-05  7:36 ` [PATCH v2 03/13] contrib/elf2dmp: Continue even contexts are lacking Akihiko Odaki
2024-03-05  7:36 ` [PATCH v2 04/13] contrib/elf2dmp: Conform to the error reporting pattern Akihiko Odaki
2024-03-05 13:28   ` Peter Maydell
2024-03-06  5:00     ` Akihiko Odaki
2024-03-06 12:53       ` Peter Maydell
2024-03-05  7:36 ` [PATCH v2 05/13] contrib/elf2dmp: Always check for PA resolution failure Akihiko Odaki
2024-03-05 13:29   ` Peter Maydell
2024-03-05  7:36 ` [PATCH v2 06/13] contrib/elf2dmp: Always destroy PA space Akihiko Odaki
2024-03-05  7:36 ` Akihiko Odaki [this message]
2024-03-05 13:31   ` [PATCH v2 07/13] contrib/elf2dmp: Ensure segment fits in file Peter Maydell
2024-03-05  7:36 ` [PATCH v2 08/13] contrib/elf2dmp: Use lduw_le_p() to read PDB Akihiko Odaki
2024-03-05 13:32   ` Peter Maydell
2024-03-05  7:36 ` [PATCH v2 09/13] contrib/elf2dmp: Use rol64() to decode Akihiko Odaki
2024-03-05  7:36 ` [PATCH v2 10/13] MAINTAINERS: Add Akihiko Odaki as a elf2dmp reviewer Akihiko Odaki
2024-03-05  7:36 ` [PATCH v2 11/13] contrib/elf2dmp: Build only for little endian host Akihiko Odaki
2024-03-05 13:33   ` Peter Maydell
2024-03-06  5:03     ` Akihiko Odaki
2024-03-05  7:36 ` [PATCH v2 12/13] contrib/elf2dmp: Use GPtrArray Akihiko Odaki
2024-03-05 13:35   ` Peter Maydell
2024-03-05  7:36 ` [PATCH v2 13/13] contrib/elf2dmp: Clamp QEMU note to file size Akihiko Odaki
2024-03-05 13:38   ` Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240305-elf2dmp-v2-7-86ff2163ad32@daynix.com \
    --to=akihiko.odaki@daynix.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=viktor.prutyanov@phystech.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).