qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Alex Bennée" <alex.bennee@linaro.org>
To: qemu-devel@nongnu.org
Cc: "Wainer dos Santos Moschetta" <wainersm@redhat.com>,
	"Alistair Francis" <Alistair.Francis@wdc.com>,
	"Nicholas Piggin" <npiggin@gmail.com>,
	"Liu Zhiwei" <zhiwei_liu@linux.alibaba.com>,
	"Richard Henderson" <richard.henderson@linaro.org>,
	"Yanan Wang" <wangyanan55@huawei.com>,
	qemu-s390x@nongnu.org,
	"Edgar E. Iglesias" <edgar.iglesias@gmail.com>,
	"Eduardo Habkost" <eduardo@habkost.net>,
	"Daniel Henrique Barboza" <dbarboza@ventanamicro.com>,
	"Michael Rolnik" <mrolnik@gmail.com>,
	"Daniel Henrique Barboza" <danielhb413@gmail.com>,
	"Alex Bennée" <alex.bennee@linaro.org>,
	"Laurent Vivier" <lvivier@redhat.com>,
	"Yoshinori Sato" <ysato@users.sourceforge.jp>,
	"Laurent Vivier" <laurent@vivier.eu>,
	"Thomas Huth" <thuth@redhat.com>,
	"Peter Maydell" <peter.maydell@linaro.org>,
	"Mahmoud Mandour" <ma.mandourr@gmail.com>,
	"Brad Smith" <brad@comstyle.com>,
	"Alistair Francis" <alistair.francis@wdc.com>,
	"Brian Cain" <bcain@quicinc.com>,
	"Cleber Rosa" <crosa@redhat.com>, "John Snow" <jsnow@redhat.com>,
	"Marcel Apfelbaum" <marcel.apfelbaum@gmail.com>,
	"Pierrick Bouvier" <pierrick.bouvier@linaro.org>,
	"Palmer Dabbelt" <palmer@dabbelt.com>,
	"Riku Voipio" <riku.voipio@iki.fi>,
	qemu-arm@nongnu.org, qemu-ppc@nongnu.org,
	"Weiwei Li" <liwei1518@gmail.com>,
	"Bin Meng" <bin.meng@windriver.com>,
	"Cédric Le Goater" <clg@kaod.org>,
	"Beraldo Leal" <bleal@redhat.com>,
	"Kyle Evans" <kevans@freebsd.org>,
	"David Hildenbrand" <david@redhat.com>,
	"Song Gao" <gaosong@loongson.cn>,
	"Philippe Mathieu-Daudé" <philmd@linaro.org>,
	"Paolo Bonzini" <pbonzini@redhat.com>,
	"Alexandre Iooss" <erdnaxe@crans.org>,
	"Warner Losh" <imp@bsdimp.com>,
	qemu-riscv@nongnu.org, "Ilya Leoshkevich" <iii@linux.ibm.com>
Subject: [PATCH 01/29] tests: bump QOS_PATH_MAX_ELEMENT_SIZE again
Date: Tue,  5 Mar 2024 12:09:37 +0000	[thread overview]
Message-ID: <20240305121005.3528075-2-alex.bennee@linaro.org> (raw)
In-Reply-To: <20240305121005.3528075-1-alex.bennee@linaro.org>

We "fixed" a bug with LTO builds with 100c459f194 (tests/qtest: bump
up QOS_PATH_MAX_ELEMENT_SIZE) but it seems it has triggered again.

The array is sized according to the maximum anticipated length of a
path on the graph. However, the worst case for a depth-first search is
to push all nodes on the graph. So it's not really LTO, it depends on
the ordering of the constructors.

Lets be more assertive raising QOS_PATH_MAX_ELEMENT_SIZE to make it go
away again.

Resolves: https://gitlab.com/qemu-project/qemu/-/issues/1186 (again)
Reviewed-by: Thomas Huth <thuth@redhat.com>
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Message-Id: <20240304193702.3195255-1-alex.bennee@linaro.org>
---
 tests/qtest/libqos/qgraph.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tests/qtest/libqos/qgraph.h b/tests/qtest/libqos/qgraph.h
index 287022a67c1..1b5de02e7be 100644
--- a/tests/qtest/libqos/qgraph.h
+++ b/tests/qtest/libqos/qgraph.h
@@ -24,7 +24,7 @@
 #include "libqos-malloc.h"
 
 /* maximum path length */
-#define QOS_PATH_MAX_ELEMENT_SIZE 64
+#define QOS_PATH_MAX_ELEMENT_SIZE 128
 
 typedef struct QOSGraphObject QOSGraphObject;
 typedef struct QOSGraphNode QOSGraphNode;
-- 
2.39.2



  reply	other threads:[~2024-03-05 12:11 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-05 12:09 [PATCH 00/29] maintainer/next for 9.0 (testing, gdbstub, plugins, disas) Alex Bennée
2024-03-05 12:09 ` Alex Bennée [this message]
2024-03-05 12:09 ` [PATCH 02/29] gdbstub: Support disablement in a multi-threaded process Alex Bennée
2024-03-05 12:09 ` [PATCH 03/29] {linux,bsd}-user: Introduce get_task_state() Alex Bennée
2024-03-05 12:09 ` [PATCH 04/29] {linux,bsd}-user: Update ts_tid after fork() Alex Bennée
2024-03-05 20:44   ` Richard Henderson
2024-03-05 12:09 ` [PATCH 05/29] gdbstub: Introduce gdbserver_fork_start() Alex Bennée
2024-03-05 12:09 ` [PATCH 06/29] {linux,bsd}-user: Pass pid to fork_end() Alex Bennée
2024-03-05 12:09 ` [PATCH 07/29] {linux,bsd}-user: Pass pid to gdbserver_fork() Alex Bennée
2024-03-05 12:09 ` [PATCH 08/29] gdbstub: Call gdbserver_fork() both in parent and in child Alex Bennée
2024-03-05 12:09 ` [PATCH 09/29] gdbstub: Introduce gdb_handle_query_supported_user() Alex Bennée
2024-03-05 12:09 ` [PATCH 10/29] gdbstub: Introduce gdb_handle_set_thread_user() Alex Bennée
2024-03-05 12:09 ` [PATCH 11/29] gdbstub: Introduce gdb_handle_detach_user() Alex Bennée
2024-03-05 12:09 ` [PATCH 12/29] gdbstub: Implement follow-fork-mode child Alex Bennée
2024-03-05 12:09 ` [PATCH 13/29] tests/tcg: Add two follow-fork-mode tests Alex Bennée
2024-03-05 12:09 ` [PATCH 14/29] plugins: scoreboard API Alex Bennée
2024-03-05 12:09 ` [PATCH 15/29] plugins: define qemu_plugin_u64 Alex Bennée
2024-03-05 12:09 ` [PATCH 16/29] plugins: implement inline operation relative to cpu_index Alex Bennée
2024-03-05 12:09 ` [PATCH 17/29] plugins: add inline operation per vcpu Alex Bennée
2024-03-05 12:09 ` [PATCH 18/29] tests/plugin: add test plugin for inline operations Alex Bennée
2024-03-05 12:09 ` [PATCH 19/29] tests/plugin/mem: migrate to new per_vcpu API Alex Bennée
2024-03-05 12:09 ` [PATCH 20/29] tests/plugin/insn: " Alex Bennée
2024-03-05 12:09 ` [PATCH 21/29] tests/plugin/bb: " Alex Bennée
2024-03-05 12:09 ` [PATCH 22/29] contrib/plugins/hotblocks: " Alex Bennée
2024-03-05 12:09 ` [PATCH 23/29] contrib/plugins/howvec: " Alex Bennée
2024-03-05 12:10 ` [PATCH 24/29] plugins: remove non per_vcpu inline operation from API Alex Bennée
2024-03-05 12:10 ` [PATCH 25/29] plugins: cleanup codepath for previous inline operation Alex Bennée
2024-03-05 12:10 ` [PATCH 26/29] disas: introduce show_opcodes Alex Bennée
2024-03-05 20:46   ` Richard Henderson
2024-03-05 12:10 ` [PATCH 27/29] disas/hppa: honour show_opcodes Alex Bennée
2024-03-05 20:46   ` Richard Henderson
2024-03-05 12:10 ` [PATCH 28/29] target/loongarch: honour show_opcodes when disassembling Alex Bennée
2024-03-05 20:47   ` Richard Henderson
2024-03-05 12:10 ` [PATCH 29/29] target/riscv: " Alex Bennée
2024-03-05 20:48   ` Richard Henderson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240305121005.3528075-2-alex.bennee@linaro.org \
    --to=alex.bennee@linaro.org \
    --cc=Alistair.Francis@wdc.com \
    --cc=bcain@quicinc.com \
    --cc=bin.meng@windriver.com \
    --cc=bleal@redhat.com \
    --cc=brad@comstyle.com \
    --cc=clg@kaod.org \
    --cc=crosa@redhat.com \
    --cc=danielhb413@gmail.com \
    --cc=david@redhat.com \
    --cc=dbarboza@ventanamicro.com \
    --cc=edgar.iglesias@gmail.com \
    --cc=eduardo@habkost.net \
    --cc=erdnaxe@crans.org \
    --cc=gaosong@loongson.cn \
    --cc=iii@linux.ibm.com \
    --cc=imp@bsdimp.com \
    --cc=jsnow@redhat.com \
    --cc=kevans@freebsd.org \
    --cc=laurent@vivier.eu \
    --cc=liwei1518@gmail.com \
    --cc=lvivier@redhat.com \
    --cc=ma.mandourr@gmail.com \
    --cc=marcel.apfelbaum@gmail.com \
    --cc=mrolnik@gmail.com \
    --cc=npiggin@gmail.com \
    --cc=palmer@dabbelt.com \
    --cc=pbonzini@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=philmd@linaro.org \
    --cc=pierrick.bouvier@linaro.org \
    --cc=qemu-arm@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-ppc@nongnu.org \
    --cc=qemu-riscv@nongnu.org \
    --cc=qemu-s390x@nongnu.org \
    --cc=richard.henderson@linaro.org \
    --cc=riku.voipio@iki.fi \
    --cc=thuth@redhat.com \
    --cc=wainersm@redhat.com \
    --cc=wangyanan55@huawei.com \
    --cc=ysato@users.sourceforge.jp \
    --cc=zhiwei_liu@linux.alibaba.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).