From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2A521C5475B for ; Wed, 6 Mar 2024 15:05:52 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rhspJ-00071G-Ff; Wed, 06 Mar 2024 10:05:02 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rhspH-00070o-MN for qemu-devel@nongnu.org; Wed, 06 Mar 2024 10:04:59 -0500 Received: from frasgout.his.huawei.com ([185.176.79.56]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rhspE-0003LC-0y for qemu-devel@nongnu.org; Wed, 06 Mar 2024 10:04:59 -0500 Received: from mail.maildlp.com (unknown [172.18.186.231]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4TqbFY5msBz6K6F8; Wed, 6 Mar 2024 23:00:01 +0800 (CST) Received: from lhrpeml500005.china.huawei.com (unknown [7.191.163.240]) by mail.maildlp.com (Postfix) with ESMTPS id ACF08140D30; Wed, 6 Mar 2024 23:04:48 +0800 (CST) Received: from localhost (10.202.227.76) by lhrpeml500005.china.huawei.com (7.191.163.240) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Wed, 6 Mar 2024 15:04:05 +0000 Date: Wed, 6 Mar 2024 15:04:04 +0000 To: Richard Henderson CC: , Peter Maydell , "Gregory Price" , Alex =?ISO-8859-1?Q?Benn=E9e?= , Sajjan Rao , Dimitrios Palyvos , Paolo Bonzini , Eduardo Habkost , , Subject: Re: [PATCH v2 0/3 qemu] tcg/i386: Page tables in MMIO memory fixes (CXL) Message-ID: <20240306150404.000063cc@Huawei.com> In-Reply-To: <1cf87044-8830-49da-92c8-406316260e51@linaro.org> References: <20240219173153.12114-1-Jonathan.Cameron@huawei.com> <1cf87044-8830-49da-92c8-406316260e51@linaro.org> Organization: Huawei Technologies Research and Development (UK) Ltd. X-Mailer: Claws Mail 4.1.0 (GTK 3.24.33; x86_64-w64-mingw32) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.202.227.76] X-ClientProxiedBy: lhrpeml500004.china.huawei.com (7.191.163.9) To lhrpeml500005.china.huawei.com (7.191.163.240) Received-SPF: pass client-ip=185.176.79.56; envelope-from=jonathan.cameron@huawei.com; helo=frasgout.his.huawei.com X-Spam_score_int: -41 X-Spam_score: -4.2 X-Spam_bar: ---- X-Spam_report: (-4.2 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-to: Jonathan Cameron From: Jonathan Cameron via Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On Thu, 22 Feb 2024 09:07:03 -1000 Richard Henderson wrote: > On 2/19/24 07:31, Jonathan Cameron wrote: > > v2: Changes documented in patch 3. > > - I have not addressed Richard's comment on recursive locks as that > > seems to be a more general issue not specific to this patch set. > > > > CXL memory is interleaved at granularities as fine as 64 bytes. > > To emulate this each read and write access undergoes address translation > > similar to that used in physical hardware. This is done using > > cfmws_ops for a memory region per CXL Fixed Memory Window (the PA address > > range in the host that is interleaved across host bridges and beyond. > > The OS programs interleaved decoders in the CXL Root Bridges, switch > > upstream ports and the corresponding decoders CXL type 3 devices who > > have to know the Host PA to Device PA mappings). > > > > Unfortunately this CXL memory may be used as normal memory and anything > > that can end up in RAM can be placed within it. As Linux has become > > more capable of handling this memory we've started to get quite a few > > bug reports for the QEMU support. However terrible the performance is > > people seem to like running actual software stacks on it :( > > > > This doesn't work for KVM - so for now CXL emulation remains TCG only. > > (unless you are very careful on how it is used!) I plan to add some > > safety guards at a later date to make it slightly harder for people > > to shoot themselves in the foot + a more limited set of CXL functionality > > that is safe (no interleaving!) > > > > Previously we had some issues with TCG reading instructions from CXL > > memory but that is now all working. This time the issues are around > > the Page Tables being in the CXL memory + DMA buffers being placed in it. > > > > The test setup I've been using is simple 2 way interleave via 2 root > > ports below a single CXL root complex. After configuration in Linux > > these are mapped to their own Numa Node and > > numactl --membind=1 ls > > followed by powering down the machine is sufficient to hit all the bugs > > addressed in this series. > > > > Thanks to Gregory, Peter and Alex for their help figuring this lot > > out. Note that I've included one patch from Peter without a SoB > > because so far it has only be posted in the discussion thread. > > > > Whilst thread started back at: > > https://lore.kernel.org/all/CAAg4PaqsGZvkDk_=PH+Oz-yeEUVcVsrumncAgegRKuxe_YoFhA@mail.gmail.com/ > > The QEMU part is from. > > https://lore.kernel.org/all/20240201130438.00001384@Huawei.com/ > > > > > > Gregory Price (1): > > target/i386: Enable page walking from MMIO memory > > > > Jonathan Cameron (1): > > tcg: Avoid double lock if page tables happen to be in mmio memory. > > > > Peter Maydell (1): > > accel/tcg: Set can_do_io at at start of lookup_tb_ptr helper > > Thanks. Queued patches 1 and 3 to tcg-next, and adjusted patch 3 to use BQL_LOCK_GUARD as > suggested by Alex. > Thanks. For patch 2, I assume this goes via an x86 specific path. Paolo? Looks like most such patches go through you. Jonathan > > r~ >