From: Taylor Simpson <ltaylorsimpson@gmail.com>
To: qemu-devel@nongnu.org
Cc: bcain@quicinc.com, quic_mathbern@quicinc.com,
sidneym@quicinc.com, quic_mliebel@quicinc.com,
richard.henderson@linaro.org, philmd@linaro.org, ale@rev.ng,
anjo@rev.ng, ltaylorsimpson@gmail.com
Subject: [PATCH v2 0/9] Clean up .new decode and scripts
Date: Wed, 6 Mar 2024 20:23:18 -0700 [thread overview]
Message-ID: <20240307032327.4799-1-ltaylorsimpson@gmail.com> (raw)
During .new decode, there are several places where strchr is used.
We remove these by generating the values that are needed.
Once we have generated the proper values, we no longer need
op_regs_generated.h.inc. We remove the script that generates it as
well as the code in meson.build
We also remove the script and meson.build code that creates
shortcode_generated.h.inc. The data structure that includes it is
not used.
We remove hex_common.read_attribs_file. The Python data structures built
during this step are not used.
**** Changes in v2 ****
Address feedback from Matheus Tavares Bernardino <quic_mathbern@quicinc.com>
Mark Philippe's Reviewed-by on patch 01
Update example comment in gen_trans_funcs.py
Taylor Simpson (9):
Hexagon (target/hexagon) Add is_old/is_new to Register class
Hexagon (target/hexagon) Mark new_read_idx in trans functions
Hexagon (target/hexagon) Mark dest_idx in trans functions
Hexagon (target/hexagon) Mark has_pred_dest in trans functions
Hexagon (tests/tcg/hexagon) Test HVX .new read from high half of pair
Hexagon (target/hexagon) Remove uses of op_regs_generated.h.inc
Hexagon (target/hexagon) Remove gen_op_regs.py
Hexagon (target/hexagon) Remove gen_shortcode.py
Hexagon (target/hexagon) Remove hex_common.read_attribs_file
target/hexagon/insn.h | 5 +-
target/hexagon/opcodes.h | 4 -
target/hexagon/decode.c | 50 ++--------
target/hexagon/mmvec/decode_ext_mmvec.c | 30 ++----
target/hexagon/opcodes.c | 35 -------
tests/tcg/hexagon/hvx_misc.c | 16 ++-
target/hexagon/README | 2 -
target/hexagon/gen_analyze_funcs.py | 21 +---
target/hexagon/gen_helper_funcs.py | 21 +---
target/hexagon/gen_helper_protos.py | 21 +---
target/hexagon/gen_idef_parser_funcs.py | 5 +-
target/hexagon/gen_op_attribs.py | 5 +-
target/hexagon/gen_op_regs.py | 125 ------------------------
target/hexagon/gen_opcodes_def.py | 4 +-
target/hexagon/gen_printinsn.py | 5 +-
target/hexagon/gen_shortcode.py | 63 ------------
target/hexagon/gen_tcg_func_table.py | 5 +-
target/hexagon/gen_tcg_funcs.py | 21 +---
target/hexagon/gen_trans_funcs.py | 26 ++++-
target/hexagon/hex_common.py | 49 +++++++---
target/hexagon/meson.build | 55 ++++-------
21 files changed, 122 insertions(+), 446 deletions(-)
delete mode 100755 target/hexagon/gen_op_regs.py
delete mode 100755 target/hexagon/gen_shortcode.py
--
2.34.1
next reply other threads:[~2024-03-07 3:24 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-07 3:23 Taylor Simpson [this message]
2024-03-07 3:23 ` [PATCH v2 1/9] Hexagon (target/hexagon) Add is_old/is_new to Register class Taylor Simpson
2024-03-29 1:05 ` Brian Cain
2024-03-07 3:23 ` [PATCH v2 2/9] Hexagon (target/hexagon) Mark new_read_idx in trans functions Taylor Simpson
2024-03-29 1:05 ` Brian Cain
2024-03-07 3:23 ` [PATCH v2 3/9] Hexagon (target/hexagon) Mark dest_idx " Taylor Simpson
2024-03-29 1:05 ` Brian Cain
2024-03-07 3:23 ` [PATCH v2 4/9] Hexagon (target/hexagon) Mark has_pred_dest " Taylor Simpson
2024-03-29 1:04 ` Brian Cain
2024-03-07 3:23 ` [PATCH v2 5/9] Hexagon (tests/tcg/hexagon) Test HVX .new read from high half of pair Taylor Simpson
2024-03-29 1:05 ` Brian Cain
2024-03-07 3:23 ` [PATCH v2 6/9] Hexagon (target/hexagon) Remove uses of op_regs_generated.h.inc Taylor Simpson
2024-03-29 1:04 ` Brian Cain
2024-03-07 3:23 ` [PATCH v2 7/9] Hexagon (target/hexagon) Remove gen_op_regs.py Taylor Simpson
2024-03-29 1:04 ` Brian Cain
2024-03-07 3:23 ` [PATCH v2 8/9] Hexagon (target/hexagon) Remove gen_shortcode.py Taylor Simpson
2024-03-07 10:07 ` Philippe Mathieu-Daudé
2024-03-29 1:03 ` Brian Cain
2024-03-07 3:23 ` [PATCH v2 9/9] Hexagon (target/hexagon) Remove hex_common.read_attribs_file Taylor Simpson
2024-03-07 10:09 ` Philippe Mathieu-Daudé
2024-03-29 1:03 ` Brian Cain
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240307032327.4799-1-ltaylorsimpson@gmail.com \
--to=ltaylorsimpson@gmail.com \
--cc=ale@rev.ng \
--cc=anjo@rev.ng \
--cc=bcain@quicinc.com \
--cc=philmd@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=quic_mathbern@quicinc.com \
--cc=quic_mliebel@quicinc.com \
--cc=richard.henderson@linaro.org \
--cc=sidneym@quicinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).