From: Thomas Huth <thuth@redhat.com>
To: "Paolo Bonzini" <pbonzini@redhat.com>,
"Alex Bennée" <alex.bennee@linaro.org>,
qemu-devel@nongnu.org
Cc: qemu-stable@nongnu.org
Subject: [PATCH] configure: Fix error message when C compiler is not working
Date: Fri, 8 Mar 2024 07:00:34 +0100 [thread overview]
Message-ID: <20240308060034.139670-1-thuth@redhat.com> (raw)
If you try to run the configure script on a system without a working
C compiler, you get a very misleading error message:
ERROR: Unrecognized host OS (uname -s reports 'Linux')
We should rather tell the user that we were not able to use the C
compiler instead, otherwise they will have a hard time to figure
out what was going wrong.
Fixes: 264b803721 ("configure: remove compiler sanity check")
Signed-off-by: Thomas Huth <thuth@redhat.com>
---
configure | 12 +++++++-----
1 file changed, 7 insertions(+), 5 deletions(-)
diff --git a/configure b/configure
index 3cd736b139..a036923dee 100755
--- a/configure
+++ b/configure
@@ -411,7 +411,7 @@ else
# Using uname is really broken, but it is just a fallback for architectures
# that are going to use TCI anyway
cpu=$(uname -m)
- echo "WARNING: unrecognized host CPU, proceeding with 'uname -m' output '$cpu'"
+ echo "WARNING: could not determine host CPU, proceeding with 'uname -m' output '$cpu'"
fi
# Normalise host CPU name to the values used by Meson cross files and in source
@@ -1000,10 +1000,12 @@ if test -z "$ninja"; then
fi
if test "$host_os" = "bogus"; then
- # Now that we know that we're not printing the help and that
- # the compiler works (so the results of the check_defines we used
- # to identify the OS are reliable), if we didn't recognize the
- # host OS we should stop now.
+ # Now that we know that we're not printing the help, we should stop now
+ # if we didn't recognize the host OS (or the C compiler is not working).
+ write_c_skeleton;
+ if ! compile_object ; then
+ error_exit "C compiler \"$cc\" is not usable"
+ fi
error_exit "Unrecognized host OS (uname -s reports '$(uname -s)')"
fi
--
2.44.0
next reply other threads:[~2024-03-08 6:01 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-08 6:00 Thomas Huth [this message]
2024-03-08 11:26 ` [PATCH] configure: Fix error message when C compiler is not working Peter Maydell
2024-03-08 11:32 ` Thomas Huth
2024-03-18 16:08 ` Thomas Huth
2024-03-19 13:12 ` Peter Maydell
2024-03-20 14:38 ` Thomas Huth
2024-03-20 14:47 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240308060034.139670-1-thuth@redhat.com \
--to=thuth@redhat.com \
--cc=alex.bennee@linaro.org \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-stable@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).