From: Zhao Liu <zhao1.liu@linux.intel.com>
To: "Eduardo Habkost" <eduardo@habkost.net>,
"Marcel Apfelbaum" <marcel.apfelbaum@gmail.com>,
"Philippe Mathieu-Daudé" <philmd@linaro.org>,
"Yanan Wang" <wangyanan55@huawei.com>,
"Daniel P . Berrangé" <berrange@redhat.com>,
"Thomas Huth" <thuth@redhat.com>,
"Igor Mammedov" <imammedo@redhat.com>,
"Prasad Pandit" <ppandit@redhat.com>,
qemu-devel@nongnu.org
Cc: Xiaoling Song <xiaoling.song@intel.com>, Zhao Liu <zhao1.liu@intel.com>
Subject: [PATCH v2 06/13] tests/unit/test-smp-parse: Bump max_cpus to 4096
Date: Sat, 9 Mar 2024 00:01:41 +0800 [thread overview]
Message-ID: <20240308160148.3130837-7-zhao1.liu@linux.intel.com> (raw)
In-Reply-To: <20240308160148.3130837-1-zhao1.liu@linux.intel.com>
From: Zhao Liu <zhao1.liu@intel.com>
The q35 machine is trying to support up to 4096 vCPUs [1], so it's
necessary to bump max_cpus in test-smp-parse to 4096 to cover the
topological needs of future machines.
[1]: https://lore.kernel.org/qemu-devel/20240228143351.3967-1-anisinha@redhat.com/
Signed-off-by: Zhao Liu <zhao1.liu@intel.com>
Tested-by: Xiaoling Song <xiaoling.song@intel.com>
Reviewed-by: Thomas Huth <thuth@redhat.com>
---
tests/unit/test-smp-parse.c | 14 +++++++-------
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/tests/unit/test-smp-parse.c b/tests/unit/test-smp-parse.c
index 84e342277452..2eb9533bc505 100644
--- a/tests/unit/test-smp-parse.c
+++ b/tests/unit/test-smp-parse.c
@@ -20,8 +20,8 @@
#define T true
#define F false
-#define MIN_CPUS 1 /* set the min CPUs supported by the machine as 1 */
-#define MAX_CPUS 512 /* set the max CPUs supported by the machine as 512 */
+#define MIN_CPUS 1 /* set the min CPUs supported by the machine as 1 */
+#define MAX_CPUS 4096 /* set the max CPUs supported by the machine as 4096 */
#define SMP_MACHINE_NAME "TEST-SMP"
@@ -333,13 +333,13 @@ static const struct SMPTestData data_generic_invalid[] = {
"by machine '" SMP_MACHINE_NAME "' is 2",
}, {
/*
- * config: -smp 512
+ * config: -smp 4096
* The test machine should tweak the supported max CPUs to
- * 511 (MAX_CPUS - 1) for testing.
+ * 4095 (MAX_CPUS - 1) for testing.
*/
- .config = SMP_CONFIG_GENERIC(T, MAX_CPUS, F, 0, F, 0, F, 0, F, 0),
- .expect_error = "Invalid SMP CPUs 512. The max CPUs supported "
- "by machine '" SMP_MACHINE_NAME "' is 511",
+ .config = SMP_CONFIG_GENERIC(T, 4096, F, 0, F, 0, F, 0, F, 0),
+ .expect_error = "Invalid SMP CPUs 4096. The max CPUs supported "
+ "by machine '" SMP_MACHINE_NAME "' is 4095",
},
};
--
2.34.1
next prev parent reply other threads:[~2024-03-08 15:49 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-08 16:01 [PATCH v2 00/13] Cleanup on SMP and its test Zhao Liu
2024-03-08 16:01 ` [PATCH v2 01/13] hw/core/machine-smp: Remove deprecated "parameter=0" SMP configurations Zhao Liu
2024-03-08 16:01 ` [PATCH v2 02/13] hw/core/machine-smp: Deprecate unsupported "parameter=1" " Zhao Liu
2024-03-08 16:12 ` Thomas Huth
2024-03-08 16:01 ` [PATCH v2 03/13] hw/core/machine-smp: Calculate total CPUs once in machine_parse_smp_config() Zhao Liu
2024-03-08 16:01 ` [PATCH v2 04/13] tests/unit/test-smp-parse: Drop the unsupported "dies=1" case Zhao Liu
2024-03-08 16:01 ` [PATCH v2 05/13] tests/unit/test-smp-parse: Use CPU number macros in invalid topology case Zhao Liu
2024-03-08 16:01 ` Zhao Liu [this message]
2024-03-08 16:01 ` [PATCH v2 07/13] tests/unit/test-smp-parse: Make test cases aware of the book/drawer Zhao Liu
2024-03-08 16:01 ` [PATCH v2 08/13] tests/unit/test-smp-parse: Test "books" parameter in -smp Zhao Liu
2024-03-08 16:01 ` [PATCH v2 09/13] tests/unit/test-smp-parse: Test "drawers" " Zhao Liu
2024-03-08 16:01 ` [PATCH v2 10/13] tests/unit/test-smp-parse: Test "drawers" and "books" combination case Zhao Liu
2024-03-08 16:01 ` [PATCH v2 11/13] tests/unit/test-smp-parse: Test the full 7-levels topology hierarchy Zhao Liu
2024-03-08 16:01 ` [PATCH v2 12/13] tests/unit/test-smp-parse: Test smp_props.has_clusters Zhao Liu
2024-03-08 16:01 ` [PATCH v2 13/13] tests/unit/test-smp-parse: Test "parameter=0" SMP configurations Zhao Liu
2024-03-08 16:31 ` [PATCH v2 00/13] Cleanup on SMP and its test Philippe Mathieu-Daudé
2024-03-09 0:46 ` Zhao Liu
2024-03-09 13:49 ` Philippe Mathieu-Daudé
2024-03-10 13:03 ` Zhao Liu
2024-03-12 6:46 ` Zhao Liu
2024-03-12 6:43 ` Thomas Huth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240308160148.3130837-7-zhao1.liu@linux.intel.com \
--to=zhao1.liu@linux.intel.com \
--cc=berrange@redhat.com \
--cc=eduardo@habkost.net \
--cc=imammedo@redhat.com \
--cc=marcel.apfelbaum@gmail.com \
--cc=philmd@linaro.org \
--cc=ppandit@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=thuth@redhat.com \
--cc=wangyanan55@huawei.com \
--cc=xiaoling.song@intel.com \
--cc=zhao1.liu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).