From: Zhao Liu <zhao1.liu@linux.intel.com>
To: "Eduardo Habkost" <eduardo@habkost.net>,
"Marcel Apfelbaum" <marcel.apfelbaum@gmail.com>,
"Philippe Mathieu-Daudé" <philmd@linaro.org>,
"Yanan Wang" <wangyanan55@huawei.com>,
"Peter Maydell" <peter.maydell@linaro.org>,
"Thomas Huth" <thuth@redhat.com>,
qemu-devel@nongnu.org
Cc: Zhao Liu <zhao1.liu@intel.com>
Subject: [PATCH v3 3/3] hw/core: Cleanup unused included headers in numa.c
Date: Mon, 11 Mar 2024 15:56:21 +0800 [thread overview]
Message-ID: <20240311075621.3224684-4-zhao1.liu@linux.intel.com> (raw)
In-Reply-To: <20240311075621.3224684-1-zhao1.liu@linux.intel.com>
From: Zhao Liu <zhao1.liu@intel.com>
Remove unused header in numa.c:
* qemu/bitmap.h
* migration/vmstate.h
Note: Though parse_numa_hmat_lb() has the variable named "bitmap_copy",
it doesn't use the normal bitmap ops so that it's safe to exclude
qemu/bitmap.h header.
Tested by "./configure" and then "make".
Signed-off-by: Zhao Liu <zhao1.liu@intel.com>
---
v3: Re-included hw/core/cpu.h since CPU_UNSET_NUMA_NODE_ID is defined
in this header.
---
hw/core/numa.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/hw/core/numa.c b/hw/core/numa.c
index f08956ddb0ff..81d21243498e 100644
--- a/hw/core/numa.c
+++ b/hw/core/numa.c
@@ -28,7 +28,6 @@
#include "sysemu/numa.h"
#include "exec/cpu-common.h"
#include "exec/ramlist.h"
-#include "qemu/bitmap.h"
#include "qemu/error-report.h"
#include "qapi/error.h"
#include "qapi/opts-visitor.h"
@@ -36,7 +35,6 @@
#include "sysemu/qtest.h"
#include "hw/core/cpu.h"
#include "hw/mem/pc-dimm.h"
-#include "migration/vmstate.h"
#include "hw/boards.h"
#include "hw/mem/memory-device.h"
#include "qemu/option.h"
--
2.34.1
next prev parent reply other threads:[~2024-03-11 7:44 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-11 7:56 [PATCH v3 0/3] hw/core: Cleanup and reorder headers Zhao Liu
2024-03-11 7:56 ` [PATCH v3 1/3] hw/core: Cleanup unused included headers in cpu-common.c Zhao Liu
2024-03-11 11:40 ` Philippe Mathieu-Daudé
2024-03-11 11:44 ` Philippe Mathieu-Daudé
2024-03-11 15:44 ` Zhao Liu
2024-03-11 18:26 ` Philippe Mathieu-Daudé
2024-03-12 2:17 ` Zhao Liu
2024-03-11 7:56 ` [PATCH v3 2/3] hw/core: Cleanup unused included header in machine-qmp-cmds.c Zhao Liu
2024-03-11 8:52 ` Philippe Mathieu-Daudé
2024-03-11 7:56 ` Zhao Liu [this message]
2024-03-11 8:50 ` [PATCH v3 3/3] hw/core: Cleanup unused included headers in numa.c Philippe Mathieu-Daudé
2024-03-11 11:40 ` [PATCH v3 0/3] hw/core: Cleanup and reorder headers Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240311075621.3224684-4-zhao1.liu@linux.intel.com \
--to=zhao1.liu@linux.intel.com \
--cc=eduardo@habkost.net \
--cc=marcel.apfelbaum@gmail.com \
--cc=peter.maydell@linaro.org \
--cc=philmd@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=thuth@redhat.com \
--cc=wangyanan55@huawei.com \
--cc=zhao1.liu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).